Checkpatch reports multiple instances of the following in HDD:
WARNING: else is not generally useful after a break or return
Fix all such instances.
Change-Id: I1a0ed6ea49ada6f26c760f084337433b74a3bf83
CRs-Fixed: 2005433
The kernel checkpatch script has identified code in function
iw_get_policy_manager_ut_ops() that is not compliant with the coding
style, so fix it.
Change-Id: Icff0907c649fb7d7f7d72d1bc486e5c5c7c177d2
CRs-Fixed: 2005296
Hardware support max tx power as 22 instead of 30.
Fix this by supporting max power as 22.
Change-Id: I3645b47a575ffa8b8bcc85fe0dcbba4a630b078b
CRs-Fixed: 2005749
If user is issuing connect command again and again with some AP,
driver should first do a disconnect and wait for completion of disconnect.
Once disconnect is done, driver should start new connection.
Change-Id: I8d64384ea1feef1173800a6f2910945d9046020b
CRs-Fixed: 1114683
Remove all calls to cdp_remove_peers_for_vdev().
cdp_remove_peers_for_vdev() is called from vdev_resp_handler
to remove all vdev peers. All the peers associated with the vdev
are deleted before vdev stop and hence this call to
cdp_remove_peers_for_vdev() is redundant.
Delete only the self peer and remove the code to delete the
vdev peers.
Change-Id: I8a91509917a371b860058a66831d8417b3a78671
CRs-Fixed: 2002372
De-reference tso list element in ol_tso_seg_list_init and
ol_tso_num_seg_list_init functions after NULL check.
Change-Id: I89581e5c57275804d967ab734d6bcc714b6745e4
CRs-Fixed: 2004503
Access to TSO stats related parameters are not protected by spinlock.
Due to this, race condition is happening in concurrency scenario where
processing of 2 packets is going on simultaneously and crash is happening
as we are writing in out of bound memory and then tries to access it.
Use spinlock and local variable store to avoid race condition.
Change-Id: I37413ab7ccf6bd5171815af0038401925aa7831b
CRs-Fixed: 1114150
qcacld-2.0 to qcacld-3.0 propagation
Currently host only report connected frequency and noise in
survey dump.
Add changes to report all supported frequencies, active time,
TX time, busy time and noise.
CRs-Fixed: 1061040
Change-Id: I2fa509f53b47d65ba0f4abbc438834b85b9c21f6
Add changes to enabled driver to use external auto selection
logic instead of current driver based implementation.
In case external application is not present, driver will fall
back to current solution.
Change-Id: Ib7474e82bc7f5878af46c91ea09711775a7c046a
CRs-Fixed: 1110061
If channel set is coming from external application, it could be
possible that it doesn't fall into valid channel criteria.
Add APIs to validate the channel.
Change-Id: I1aa855b64c7702418471111d59c92ebaebe8be49
CRs-Fixed: 1110061
Vendor ACS requires regulatory channel info for each channel.
Add changes to collect channel information of each channel
and save it in sap config.
Change-Id: Ib96c3f7ddfc8476306e9a13127472be9dd0a9488
CRs-Fixed: 1110061
In monitor mode, wma_set_channel api is filling the
vdev response wait queue before sending the WMI_PDEV_SET_CHANNEL_CMDID
command to firmware and expecting it will be dequeued after response
from firmware but firmware doesn't send any response
to PDEV set channel command which is causing WMA timeout.
Don't fill the vdev request wait queue for WMI_PDEV_SET_CHANNEL_CMDID
command as firmware doesn't send any response.
Change-Id: If1849440143ed671e0261685a53b8a86f4f8e29c
CRs-Fixed: 2003707
Currently in lim_update_sta_run_time_ht_switch_chnl_params
"RoC is in progress" is coming frequently in dmesg due to
error log level which leads to crash.
Fix is to change the log level to debug.
Change-Id: Ib089e7187b6056728e8b6fd18b69c89c761fb1c9
CRs-Fixed: 2005093
There is no vendor command support for QDF Debug Framework.
Add vendor command support to dynamically update the trace levels
for modules.
Change-Id: I807365ec035d75372d4ff0f1ea27ba6f7bbff62d
CRs-Fixed: 2003455
On a change of the mode ( from the current one to the FTM mode ) ,
the clean up of the adapters are again done though they are already
cleaned ( signified by device_status = DRIVER_MODULES_CLOSED ). Hence
check for this device_status while to avoid a redundant clean up of the
adapters.
Change-Id: I2a851b235809db5cd47ec5d738067d1553f83129
CRs-Fixed: 1115243
pktlog deinit should not use cds_get_context.
Using cds_get_context for the txrx context was
causing the device to crash on the next insmod
because the deinit is happenning durring the deinitialization
of the txrx context after it has allready been unlinked from
as a global context.
Change-Id: I487951a6dd50680884223e7027e5bce1c8ddfa07
CRs-Fixed: 2004404
According to RFC 5227, both the source and target addresses in a
gratuitous ARP packet should be the same. When enabling gratuitous ARP
keepalive, set both source and target addresses to the host's IPv4
address.
Change-Id: If467cc7d93adb67f88539ebed727689b61d42089
CRs-Fixed: 2004770
qcacld-2.0 to qcacld-3.0 propagation
SAP keys should be retained at HDD layer when wlan driver
performs internal restarting due to MCC to SCC switch
Change-Id: I5458f7602a0e3851d678981e107ef3b5bda17dd7
CRs-Fixed: 1095584
This is a qcacld-2.0 to qcacld-3.0 propagation.
In wma_remove_peer, sometimes when peer detach is in progress,
and it has set the peer as invalid, but WMI_PEER_DELETE_CMDID
is still not sent to FW, so msdu for the peer still can be
received. In htt_rx_amsdu_rx_in_order_pop_ll, it will print
a lot of error log, which will cause watch dog.
Send peer delete cmd to FW firstly, then detach peer in host.
In qcacld-3.0, it doesn't have watch dog issue, as the print has
been removed from htt_rx_amsdu_rx_in_order_pop_ll, but it is still
worth to adjust to the right sequence.
Change-Id: Ia26aa5e673a48ca1d9ccf4f184d0bfab0d6e98ef
CRs-Fixed: 1070216
This is a qcacld-2.0 to qcacld-3.0 propagation.
Currently the min value of gTDLSPrefOffChanBandwidth
is set to zero which is invalid, min value should be
1 (zeroth bit set) for 20MHz.
Change-Id: Ibc2da1c2cca7e704b21686ab795224462dd9f913
CRs-Fixed: 2004116
In some scenarios TDLS connection tracker is not
enabled correctly, When the system comes out of
concurrency. Due to this TDLS connection problem
observed in some corner cases.
Enable TDLS connection tracker exclusively, when
TDLS reenabled in the system.
Change-Id: Ibabcb8887708bd3bde3d7a9819d5bcc4ebda47bf
CRs-Fixed: 2003045
Although the wlan driver currently utilizes nl80211/cfg80211 as its
primary configuration interface, it still contains support for the
legacy wireless extensions ioctl interface. This interface, however,
is not being maintained and at some point in the future it should be
removed. But before it can be removed all applications which depend
upon this interface must be converted to use other supported
interfaces such as nl80211. To aid in this effort add a framework for
detecting and logging when wireless extensions ioctls are being used.
Change-Id: Ib2f3b64f74e673f3857f14ae12ff372a9f60de8d
CRs-Fixed: 2004194
Currently for both SIOCGIWRTS and SIOCGIWFRAG there are two separate
but identical handlers, one for STA-like interfaces and one for
SAP-like interfaces. For each ioctl consolidate the code into a single
handler. This is a prerequisite for further ioctl cleanup.
Change-Id: I4d4f288198bed2124ec96cf3ca1929e89705d4de
CRs-Fixed: 2004191
There are currently several error paths in __iw_get_bitrate() which
incorrectly return internal status enumerations instead of returning
negative errno values. Fix these paths to correctly return negative
errno values.
Change-Id: I42254dbe1b362fb42b87418419b97ccbabfac355
CRs-Fixed: 2004190
Currently __iw_softap_stopbss() uses a variable of type QDF_STATUS to
hold a potentially negative errno value. Since errno values do not
adhere to the QDF_STATUS enumerations, use an int variable for the
value. In addition appropriately convert QDF_STATUS to errno values
when returning status to userspace.
Change-Id: I105c6db4287384802b2f86d35fa5251954ea051d
CRs-Fixed: 2004188
The struct hdd_wext_state_s currently contains the field
collectedAuthType. This field is currently written, but is
never read, and hence it is useless, so remove all traces of it.
Change-Id: Ica2fc7a54cc92c8d4394cdcdd9470f624f705848
CRs-Fixed: 2004184
Desk review of hdd_wlan_startup() revealed improper use of the adapter
returned by hdd_open_interfaces() since in the failure case multiple
calls will be made to hdd_debugfs_exit() for that returned adapter.
Further review revealed the fact that having hdd_open_interfaces()
return an adapter is illogical since hdd_open_interfaces() can
legitimately open multiple interfaces, and hence the return value
should simply indicate whether all required interfaces were opened or
not. So update hdd_open_interfaces() to return errno instead of an
adapter.
Change-Id: I71117c32f053dad97a5c4bcaef33af27a903f511
CRs-Fixed: 2001662
Currently in the error-handling path of hdd_wlan_startup() there are
two issues with respect to the rtnl_lock:
1) hdd_close_all_adapters() may be called with the rtnl_lock parameter
set to false even though the rtnl_lock is being held.
2) the function could possibly take the rtnl_lock and never release it.
Fix these issues in hdd_wlan_startup().
Change-Id: Iaa69d540dd7663355ceb66f6bc8ba0e5dd8c228e
CRs-Fixed: 2001611
When CONFIG_WLAN_FEATURE_DSRC is enabled the resulting build fails
because there is no rule to make wma_ocb.o. The issue is that there is
a typo in the rule, so fix the rule.
Change-Id: I1b724736fcac175b9bf83e4a98878e1333a54b57
CRs-Fixed: 2002874
