Masami Hiramatsu e96e4078e9 perf machine: Fix machine__destroy_kernel_maps to drop vmlinux_maps references ... Fix machine__destroy_kernel_maps() to drop vmlinux_maps references before filling it with NULL. Refcnt debugger shows ==== [1] ==== Unreclaimed map: 0x36b1070 Refcount +1 => 1 at ./perf(map__new2+0xb5) [0x4bdec5] ./perf(machine__create_kernel_maps+0x72) [0x4bb152] ./perf(machine__new_host+0xfa) [0x4bb41a] ./perf(init_probe_symbol_maps+0x93) [0x5062d3] ./perf() [0x455ffa] ./perf(cmd_probe+0x6c) [0x4566bc] ./perf() [0x47abc5] ./perf(main+0x610) [0x421f90] /lib64/libc.so.6(__libc_start_main+0xf5) [0x7f1fc9fc4af5] ./perf() [0x4220a9] Refcount +1 => 2 at ./perf(maps__insert+0x9a) [0x4bfd6a] ./perf(machine__create_kernel_maps+0xc3) [0x4bb1a3] ./perf(machine__new_host+0xfa) [0x4bb41a] ./perf(init_probe_symbol_maps+0x93) [0x5062d3] ./perf() [0x455ffa] ./perf(cmd_probe+0x6c) [0x4566bc] ./perf() [0x47abc5] ./perf(main+0x610) [0x421f90] /lib64/libc.so.6(__libc_start_main+0xf5) [0x7f1fc9fc4af5] ./perf() [0x4220a9] Refcount -1 => 1 at ./perf(map_groups__exit+0x94) [0x4bea74] ./perf(machine__delete+0x3d) [0x4b91fd] ./perf(exit_probe_symbol_maps+0x28) [0x506378] ./perf() [0x45628a] ./perf(cmd_probe+0x6c) [0x4566bc] ./perf() [0x47abc5] ./perf(main+0x610) [0x421f90] /lib64/libc.so.6(__libc_start_main+0xf5) [0x7f1fc9fc4af5] ./perf() [0x4220a9] map__new2() returns map with refcnt = 1, and also map_groups__insert gets it again in__machine__create_kernel_maps(). machine__destroy_kernel_maps() calls map_groups__remove() to decrement the refcnt, but before decrement it again (corresponding to map__new2), it makes vmlinux_maps[type] = NULL. And this may cause a refcnt leak. Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20151118064022.30709.3897.stgit@localhost.localdomain Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2015-11-19 13:19:18 -03:00
..
arch	tools include: Add basic atomic.h implementation from the kernel sources	2015-05-08 16:11:05 -03:00
build	tools build: Fix libiberty feature detection	2015-10-29 17:46:35 -03:00
cgroup	cgroups: fix cgroup_event_listener error handling	2013-01-08 10:00:44 -08:00
firewire	tools/firewire: nosy-dump: check for allocation failure	2012-12-02 20:10:18 +01:00
hv	tools: hv: add a python script lsvmbus to list VMBus devices	2015-08-05 11:44:29 -07:00
iio	iio: lsiio: fix error code handling error	2015-08-12 19:26:22 +01:00
include	tools: Clone the kernel's strtobool function	2015-11-18 17:51:02 -03:00
laptop/freefall	Move freefall program from Documentation/ to tools/	2015-06-08 16:42:07 -06:00
lguest	tools/lguest: Clean up include dir	2015-08-26 06:12:35 +02:00
lib	bpf tools: Load a program with different instances using preprocessor	2015-11-18 17:51:03 -03:00
net	bpf_jit_disasm: also support reading jit dump from file	2015-07-31 15:13:14 -07:00
nfsd
perf	perf machine: Fix machine__destroy_kernel_maps to drop vmlinux_maps references	2015-11-19 13:19:18 -03:00
power	tools/power turbosat: update version number	2015-09-26 09:49:55 -04:00
scripts	tools lib traceevent: Add global QUIET_CC_FPIC build output	2013-12-19 16:18:10 -03:00
testing	Merge branch 'x86-fpu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-11-03 20:50:26 -08:00
thermal/tmon	tools/thermal: tmon: fixed the 'make install' command	2015-05-09 13:36:58 +08:00
time	tools: add script to test udelay	2014-07-23 10:16:38 -07:00
usb	tools: ffs-aio-example: use endpoint addresses from descriptors	2015-01-15 09:41:49 -06:00
virtio	tools/virtio: propagate V=X to kernel build	2015-09-16 12:48:07 +03:00
vm	tools vm: Fix build due to removal of tools/lib/api/fs/debugfs.h	2015-09-22 22:42:39 -03:00
Makefile	tools: Fix selftests_install Makefile rule	2015-11-18 17:46:29 -03:00