Julia Lawall
d67b1b0325
fs/xfs: Correct NULL test
...
Test the value that was just allocated rather than the previously tested one.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/ )
// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@
if (x == NULL || ...) {
... when forall
return ...; }
... when != goto l;
when != x = e
when != &x
*x == NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
2010-02-13 13:22:53 -06:00
..
2010-02-12 13:43:57 -06:00
2010-02-13 13:22:53 -06:00
2009-12-14 23:08:16 -06:00
2009-06-10 17:07:47 +02:00
2010-01-26 15:10:15 +11:00
2010-01-20 10:47:48 +11:00
2010-01-15 15:34:39 -06:00
2010-01-15 15:33:12 -06:00
2008-10-30 17:14:34 +11:00
2010-01-21 13:44:49 -06:00
2009-12-14 23:08:16 -06:00
2009-06-10 17:07:47 +02:00
2010-01-21 13:44:36 -06:00
2009-01-09 15:46:44 +11:00
2010-01-20 10:47:48 +11:00
2010-01-21 13:44:36 -06:00
2010-01-20 10:47:48 +11:00
2008-08-13 15:41:12 +10:00
2009-01-09 15:53:54 +11:00
2010-01-15 15:31:38 -06:00
2010-01-15 15:31:38 -06:00
2010-01-20 10:50:06 +11:00
2009-12-14 23:08:16 -06:00
2008-10-30 16:58:50 +11:00
2009-12-14 23:08:16 -06:00
2010-01-21 13:44:36 -06:00
2009-08-31 14:46:20 -05:00
2010-02-02 10:13:42 +11:00
2009-12-14 23:08:16 -06:00
2010-01-20 10:47:17 +11:00
2010-01-20 10:47:17 +11:00
2010-01-15 15:31:23 -06:00
2010-01-15 15:31:23 -06:00
2009-03-29 09:51:14 +02:00
2010-01-20 10:48:05 +11:00
2007-10-15 16:49:49 +10:00
2008-07-28 16:58:36 +10:00
2009-03-29 09:55:42 +02:00
2010-01-20 10:48:05 +11:00
2007-10-15 16:49:49 +10:00
2010-01-15 15:31:38 -06:00
2010-01-15 15:31:38 -06:00
2010-01-20 10:48:05 +11:00
2008-12-01 11:37:35 +11:00
2010-01-20 10:48:05 +11:00
2010-01-20 10:47:25 +11:00
2008-08-23 12:14:12 -07:00
2008-10-30 17:53:24 +11:00
2008-12-22 18:02:01 +11:00
2008-12-22 18:02:01 +11:00
2010-01-21 13:44:43 -06:00
2009-01-22 14:07:31 +11:00
2010-01-15 15:34:22 -06:00
2010-01-15 15:34:22 -06:00
2009-09-21 15:14:54 +02:00
2010-01-15 15:33:52 -06:00
2009-01-09 16:54:42 -08:00
2009-03-29 09:55:42 +02:00
2009-02-09 08:37:14 +01:00
2010-01-21 13:44:36 -06:00
2009-09-01 12:45:39 -05:00
2010-01-15 15:33:02 -06:00
2010-02-02 10:13:42 +11:00
2010-02-02 10:13:42 +11:00
2010-02-06 12:39:36 +11:00
2010-02-06 12:39:36 +11:00
2009-08-31 14:46:22 -05:00
2009-12-14 23:08:16 -06:00
2009-12-14 23:08:16 -06:00
2010-01-21 13:44:56 -06:00
2009-08-31 14:46:20 -05:00
2010-01-15 15:31:38 -06:00
2010-01-21 13:44:49 -06:00
2010-01-15 15:31:51 -06:00
2010-01-21 13:44:49 -06:00
2010-01-21 13:44:49 -06:00
2010-02-06 12:39:36 +11:00
2010-02-08 17:41:48 -06:00
2010-01-15 15:34:22 -06:00
2010-01-15 15:34:22 -06:00
2010-02-04 09:48:58 +11:00
2009-12-14 23:08:16 -06:00
2010-01-15 13:46:19 -06:00
2009-03-29 09:55:42 +02:00
2010-02-12 13:43:57 -06:00
2010-02-12 13:43:57 -06:00
2009-01-19 14:45:55 +11:00
2010-02-02 10:13:42 +11:00
2010-01-21 13:44:36 -06:00
2007-10-15 16:50:50 +10:00
2009-09-01 12:46:16 -05:00
2009-03-29 09:55:42 +02:00
2008-10-30 17:39:58 +11:00
2009-02-09 08:37:14 +01:00
2010-01-21 13:44:49 -06:00
2010-02-02 10:13:42 +11:00
2010-01-20 10:44:58 +11:00
2009-06-08 15:33:32 +02:00
2008-08-13 16:13:45 +10:00
2010-02-12 13:45:14 -06:00
2010-01-20 10:47:48 +11:00
2009-12-14 23:08:16 -06:00