Mike Tipton cc426a91d3 clk: Don't parent clks until the parent is fully registered ... [ Upstream commit 54baf56eaa40aa5cdcd02b3c20d593e4e1211220 ] Before commit fc0c209c14 ("clk: Allow parents to be specified without string names") child clks couldn't find their parent until the parent clk was added to a list in __clk_core_init(). After that commit, child clks can reference their parent clks directly via a clk_hw pointer, or they can lookup that clk_hw pointer via DT if the parent clk is registered with an OF clk provider. The common clk framework treats hw->core being non-NULL as "the clk is registered" per the logic within clk_core_fill_parent_index(): parent = entry->hw->core; /* * We have a direct reference but it isn't registered yet? * Orphan it and let clk_reparent() update the orphan status * when the parent is registered. */ if (!parent) Therefore we need to be extra careful to not set hw->core until the clk is fully registered with the clk framework. Otherwise we can get into a situation where a child finds a parent clk and we move the child clk off the orphan list when the parent isn't actually registered, wrecking our enable accounting and breaking critical clks. Consider the following scenario: CPU0 CPU1 ---- ---- struct clk_hw clkBad; struct clk_hw clkA; clkA.init.parent_hws = { &clkBad }; clk_hw_register(&clkA) clk_hw_register(&clkBad) ... __clk_register() hw->core = core ... __clk_register() __clk_core_init() clk_prepare_lock() __clk_init_parent() clk_core_get_parent_by_index() clk_core_fill_parent_index() if (entry->hw) { parent = entry->hw->core; At this point, 'parent' points to clkBad even though clkBad hasn't been fully registered yet. Ouch! A similar problem can happen if a clk controller registers orphan clks that are referenced in the DT node of another clk controller. Let's fix all this by only setting the hw->core pointer underneath the clk prepare lock in __clk_core_init(). This way we know that clk_core_fill_parent_index() can't see hw->core be non-NULL until the clk is fully registered. Fixes: fc0c209c14 ("clk: Allow parents to be specified without string names") Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com> Link: https://lore.kernel.org/r/20211109043438.4639-1-quic_mdtipton@quicinc.com [sboyd@kernel.org: Reword commit text, update comment] Signed-off-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-12-22 09:30:52 +01:00
..
actions	clk: actions: Fix AHPPREDIV-H-AHB clock chain on Owl S500 SoC	2021-07-14 16:56:31 +02:00
analogbits	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
at91	clk: at91: sam9x60-pll: use DIV_ROUND_CLOSEST_ULL	2021-11-18 14:04:21 +01:00
axis	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
axs10x	clk: axs10x: use devm_platform_ioremap_resource() to simplify code	2019-10-16 16:17:50 -07:00
baikal-t1	clk: baikal-t1: Mark Ethernet PLL as critical	2020-10-13 19:48:34 -07:00
bcm	clk: bcm: dvp: Add MODULE_DEVICE_TABLE()	2020-12-30 11:54:00 +01:00
berlin	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
davinci	This pull request contains zero diff to the core framework. It is a collection	2020-10-22 12:53:28 -07:00
h8300	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
hisilicon	Merge branches 'clk-hisi', 'clk-amlogic', 'clk-samsung', 'clk-renesas' and 'clk-imx' into clk-next	2019-11-27 08:14:17 -08:00
imgtec	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
imx	clk: imx: use module_platform_driver	2021-12-14 11:32:41 +01:00
ingenic	clk: ingenic: Fix bugs with divided dividers	2021-11-26 10:39:12 +01:00
keystone	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
loongson1	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
mediatek	Merge branches 'clk-simplify', 'clk-ti', 'clk-tegra', 'clk-rockchip' and 'clk-mediatek' into clk-next	2020-10-20 11:46:47 -07:00
meson	clk: meson: g12a: fix gp0 and hifi ranges	2021-07-14 16:56:16 +02:00
microchip	clk: let init callback return an error code	2019-12-23 18:53:13 -08:00
mmp	clk: mmp2: fix build without CONFIG_PM	2021-02-03 23:28:44 +01:00
mvebu	clk: mvebu: ap-cpu-clk: Fix a memory leak in error handling paths	2021-11-18 14:04:14 +01:00
mxs	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 159	2019-05-30 11:26:37 -07:00
nxp	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 159	2019-05-30 11:26:37 -07:00
pistachio	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 422	2019-06-05 17:37:15 +02:00
pxa	clk: pxa: Constify static struct clk_ops	2020-10-13 19:49:11 -07:00
qcom	clk: qcom: regmap-mux: fix parent clock lookup	2021-12-14 11:32:39 +01:00
renesas	clk: renesas: rcar-usb2-clock-sel: Fix kernel NULL pointer dereference	2021-09-03 10:09:26 +02:00
rockchip	clk: rockchip: drop GRF dependency for rk3328/rk3036 pll types	2021-09-18 13:40:11 +02:00
samsung	clk: exynos7: Mark aclk_fsys1_200 as critical	2021-05-19 10:13:19 +02:00
sifive	clk: sifive: allocate sufficient memory for struct __prci_data	2020-06-25 15:04:13 -07:00
sirf	clk: clk-prima2: fix return value check in prima2_clk_init()	2020-10-13 19:54:30 -07:00
socfpga	clk: socfpga: agilex: fix duplicate s2f_user0_clk	2021-10-20 11:44:58 +02:00
spear	clk: spear: Remove uninitialized_var() usage	2020-07-16 12:32:26 -07:00
sprd	This time around we have 4 lines of diff in the core framework, removing a	2020-06-10 11:42:19 -07:00
st	clk: st: Remove uninitialized_var() usage	2020-07-16 12:32:25 -07:00
sunxi	clk: sunxi: Fix incorrect usage of round_down()	2020-04-14 09:21:05 +02:00
sunxi-ng	clk: sunxi-ng: h6: Fix clock divider range on some clocks	2021-03-04 11:37:58 +01:00
tegra	clk: tegra: Implement disable_unused() of tegra_clk_sdmmc_mux_ops	2021-08-12 13:22:04 +02:00
ti	clk: ti: Fix memleak in ti_fapll_synth_setup	2020-12-30 11:53:58 +01:00
uniphier	clk: uniphier: Fix potential infinite loop	2021-05-14 09:50:26 +02:00
ux500	clk: ux500: Fix up the SGA clock for some variants	2020-01-04 23:27:15 -08:00
versatile	clk: versatile: Add of_node_put() before return statement	2020-09-10 00:57:42 -07:00
x86	More ACPI updates for 5.9-rc1	2020-08-15 08:18:22 -07:00
zte	clk: zx296718: Don't reference clk_init_data after registration	2019-08-16 10:20:15 -07:00
zynq	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 401	2019-06-05 17:37:13 +02:00
zynqmp	clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable	2021-05-14 09:50:26 +02:00
clk-asm9260.c	clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo	2020-04-13 12:20:06 -07:00
clk-aspeed.c	clk: aspeed: Add RMII RCLK gates for both AST2500 MACs	2019-11-26 10:02:48 -08:00
clk-aspeed.h	clk: aspeed: Move structures to header	2019-09-06 15:17:02 -07:00
clk-ast2600.c	clk/ast2600: Fix soc revision for AHB	2021-11-26 10:39:12 +01:00
clk-axi-clkgen.c	clk: axi-clkgen: Set power bits for fractional mode	2020-10-13 19:44:40 -07:00
clk-axm5516.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
clk-bd718x7.c	clk: bd718x7: Support ROHM BD71828 clk block	2020-01-24 07:22:47 +00:00
clk-bm1880.c	clk: bm1800: Remove set but not used variable 'fref'	2019-12-24 00:10:33 -08:00
clk-bulk.c	clk: Make clk_bulk_get_all() return a valid "id"	2019-09-17 13:26:31 -07:00
clk-cdce706.c	Replace HTTP links with HTTPS ones: Common CLK framework	2020-07-10 17:15:34 -07:00
clk-cdce925.c	clk: clk-cdce925: Add regulator support	2019-09-06 10:31:16 -07:00
clk-clps711x.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
clk-composite.c	clk: composite: Export clk_hw_register_composite()	2020-08-22 12:38:06 +08:00
clk-conf.c	clk: Tag clk core files with SPDX	2018-12-11 09:57:47 -08:00
clk-cs2000-cp.c	clk: cs2000-cp: convert to SPDX identifiers	2018-08-02 13:55:00 -07:00
clk-devres.c	clk: fix leak on devm_clk_bulk_get_all() unwind	2021-08-12 13:22:11 +02:00
clk-divider.c	clk: divider: fix initialization with parent_hw	2021-03-04 11:38:06 +01:00
clk-efm32gg.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
clk-fixed-factor.c	clk: fixed: add missing kerneldoc	2020-09-22 12:44:14 -07:00
clk-fixed-mmio.c	clk: Remove io.h from clk-provider.h	2019-05-15 13:21:37 -07:00
clk-fixed-rate.c	clk: fixed: add missing kerneldoc	2020-09-22 12:44:14 -07:00
clk-fractional-divider.c	clk: Remove io.h from clk-provider.h	2019-05-15 13:21:37 -07:00
clk-fsl-sai.c	clk: fsl-sai: fix memory leak	2020-12-30 11:53:42 +01:00
clk-gate.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
clk-gemini.c	treewide: Use struct_size() for kmalloc()-family	2018-06-06 11:15:43 -07:00
clk-gpio.c	Replace HTTP links with HTTPS ones: Common CLK framework	2020-07-10 17:15:34 -07:00
clk-hi655x.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288	2019-06-05 17:36:37 +02:00
clk-highbank.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
clk-hsdk-pll.c	CLK: HSDK: CGU: add support for 148.5MHz clock	2020-05-28 21:06:39 -07:00
clk-lochnagar.c	clk: lochnagar: Don't reference clk_init_data after registration	2019-08-16 10:20:07 -07:00
clk-max9485.c	clk: Add driver for MAX9485	2018-07-06 13:44:06 -07:00
clk-max77686.c	clk: clk-max77686: Clean clkdev lookup leak and use devm	2019-02-06 10:35:03 -08:00
clk-milbeaut.c	clk: milbeaut: Don't reference clk_init_data after registration	2019-08-16 10:20:15 -07:00
clk-moxart.c
clk-multiplier.c	clk: Remove io.h from clk-provider.h	2019-05-15 13:21:37 -07:00
clk-mux.c	clk: mux: Add support for specifying parents via DT/pointers	2020-01-06 23:10:05 -08:00
clk-nomadik.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194	2019-05-30 11:29:22 -07:00
clk-npcm7xx.c	This time it looks like a quieter release cycle in the clk tree. I guess that's	2018-10-31 11:08:30 -07:00
clk-nspire.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
clk-oxnas.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
clk-palmas.c	clk: palmas: constify clk_ops structure	2018-11-06 09:41:44 -08:00
clk-plldig.c	clk: ls1028a: fix a dereference of pointer 'parent' before a null check	2020-02-03 23:03:49 -08:00
clk-pwm.c	clk: pwm: Use 64-bit division function	2020-06-17 20:42:10 +02:00
clk-qoriq.c	clk: qoriq: modify MAX_PLL_DIV to 32	2020-10-13 19:48:09 -07:00
clk-rk808.c	- Core Frameworks	2019-07-15 20:18:40 -07:00
clk-s2mps11.c	clk: s2mps11: Fix a resource leak in error handling paths in the probe function	2020-12-30 11:54:01 +01:00
clk-scmi.c	clk: scmi: Fix min and max rate when registering clocks with discrete rates	2020-07-13 09:40:21 +01:00
clk-scpi.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
clk-si514.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
clk-si544.c	clk: clk-si544: Implement small frequency change support	2019-06-27 13:45:38 -07:00
clk-si570.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
clk-si5341.c	clk: si5341: Update initialization magic	2021-07-14 16:56:31 +02:00
clk-si5351.c	Replace HTTP links with HTTPS ones: Common CLK framework	2020-07-10 17:15:34 -07:00
clk-si5351.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
clk-sparx5.c	clk: sparx5: Add Sparx5 SoC DPLL clock driver	2020-07-28 18:17:56 -07:00
clk-stm32f4.c	clk: stm32f4: fix post divisor setup for I2S/SAI PLLs	2021-08-12 13:22:03 +02:00
clk-stm32h7.c	clk: Convert to using %pOFn instead of device_node.name	2018-08-30 09:50:20 -07:00
clk-stm32mp1.c	clk: stm32mp1: Add ddrperfm clock	2019-04-29 11:13:23 -07:00
clk-tango4.c	clk: Convert to using %pOFn instead of device_node.name	2018-08-30 09:50:20 -07:00
clk-twl6040.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336	2019-06-05 17:37:07 +02:00
clk-u300.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194	2019-05-30 11:29:22 -07:00
clk-versaclock5.c	clk: vc5: fix output disabling when enabling a FOD	2021-07-14 16:56:19 +02:00
clk-vt8500.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
clk-wm831x.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
clk-xgene.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
clk.c	clk: Don't parent clks until the parent is fully registered	2021-12-22 09:30:52 +01:00
clk.h	clk: consoldiate the __clk_get_hw() declarations	2019-07-12 11:00:14 -07:00
clkdev.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
Kconfig	Merge branches 'clk-ingenic', 'clk-at91', 'clk-kconfig', 'clk-imx', 'clk-qcom', 'clk-prima2' and 'clk-bcm' into clk-next	2020-10-20 11:47:07 -07:00
Makefile	clk: sparx5: Add Sparx5 SoC DPLL clock driver	2020-07-28 18:17:56 -07:00