8470060019
[ Upstream commit b434422c45282a0573d8123239abc41fa72665d4 ]
A problem about modprobe s5p_fimc failed is triggered with the
following log given:
[ 272.075275] Error: Driver 'exynos4-fimc' is already registered, aborting...
modprobe: ERROR: could not insert 's5p_fimc': Device or resource busy
The reason is that fimc_md_init() returns platform_driver_register()
directly without checking its return value, if platform_driver_register()
failed, it returns without unregister fimc_driver, resulting the
s5p_fimc can never be installed later.
A simple call graph is shown as below:
fimc_md_init()
fimc_register_driver() # register fimc_driver
platform_driver_register()
platform_driver_register()
driver_register()
bus_add_driver()
dev = kzalloc(...) # OOM happened
# return without unregister fimc_driver
Fix by unregister fimc_driver when platform_driver_register() returns
error.
Fixes:
|
||
|---|---|---|
| .. | ||
| common.c | ||
| common.h | ||
| fimc-capture.c | ||
| fimc-core.c | ||
| fimc-core.h | ||
| fimc-is-command.h | ||
| fimc-is-errno.c | ||
| fimc-is-errno.h | ||
| fimc-is-i2c.c | ||
| fimc-is-i2c.h | ||
| fimc-is-param.c | ||
| fimc-is-param.h | ||
| fimc-is-regs.c | ||
| fimc-is-regs.h | ||
| fimc-is-sensor.c | ||
| fimc-is-sensor.h | ||
| fimc-is.c | ||
| fimc-is.h | ||
| fimc-isp-video.c | ||
| fimc-isp-video.h | ||
| fimc-isp.c | ||
| fimc-isp.h | ||
| fimc-lite-reg.c | ||
| fimc-lite-reg.h | ||
| fimc-lite.c | ||
| fimc-lite.h | ||
| fimc-m2m.c | ||
| fimc-reg.c | ||
| fimc-reg.h | ||
| Kconfig | ||
| Makefile | ||
| media-dev.c | ||
| media-dev.h | ||
| mipi-csis.c | ||
| mipi-csis.h | ||