Tejun Heo 9f56f38331 blk-iocost: Fix an UBSAN shift-out-of-bounds warning ... [ Upstream commit 2a427b49d02995ea4a6ff93a1432c40fa4d36821 ] When iocg_kick_delay() is called from a CPU different than the one which set the delay, @now may be in the past of @iocg->delay_at leading to the following warning: UBSAN: shift-out-of-bounds in block/blk-iocost.c:1359:23 shift exponent 18446744073709 is too large for 64-bit type 'u64' (aka 'unsigned long long') ... Call Trace: <TASK> dump_stack_lvl+0x79/0xc0 __ubsan_handle_shift_out_of_bounds+0x2ab/0x300 iocg_kick_delay+0x222/0x230 ioc_rqos_merge+0x1d7/0x2c0 __rq_qos_merge+0x2c/0x80 bio_attempt_back_merge+0x83/0x190 blk_attempt_plug_merge+0x101/0x150 blk_mq_submit_bio+0x2b1/0x720 submit_bio_noacct_nocheck+0x320/0x3e0 __swap_writepage+0x2ab/0x9d0 The underflow itself doesn't really affect the behavior in any meaningful way; however, the past timestamp may exaggerate the delay amount calculated later in the code, which shouldn't be a material problem given the nature of the delay mechanism. If @now is in the past, this CPU is racing another CPU which recently set up the delay and there's nothing this CPU can contribute w.r.t. the delay. Let's bail early from iocg_kick_delay() in such cases. Reported-by: Breno Leitão <leitao@debian.org> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: 5160a5a53c ("blk-iocost: implement delay adjustment hysteresis") Link: https://lore.kernel.org/r/ZVvc9L_CYk5LO1fT@slm.duckdns.org Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-02-23 08:42:21 +01:00
..
partitions	block/partition: fix signedness issue for Amiga partitions	2023-07-27 08:44:18 +02:00
badblocks.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
bfq-cgroup.c	block, bfq: fix uaf for bfqq in bic_set_bfqq()	2023-03-17 08:45:14 +01:00
bfq-iosched.c	block, bfq: fix uaf for bfqq in bic_set_bfqq()	2023-03-17 08:45:14 +01:00
bfq-iosched.h	bfq: Get rid of __bio_blkcg() usage	2022-06-09 10:21:31 +02:00
bfq-wf2q.c	bfq: fix blkio cgroup leakage v4	2020-08-18 07:48:08 -07:00
bio-integrity.c	block: bio-integrity: Copy flags when bio_integrity_payload is cloned	2023-03-11 16:39:16 +01:00
bio.c	block: prevent an integer overflow in bvec_try_merge_hw_page	2024-02-23 08:42:09 +01:00
blk-cgroup-rwstat.c	blk-cgroup: Fix the recursive blkg rwstat	2021-03-30 14:31:48 +02:00
blk-cgroup-rwstat.h	blk-cgroup: separate out blkg_rwstat under CONFIG_BLK_CGROUP_RWSTAT	2019-11-07 12:28:13 -07:00
blk-cgroup.c	blk-cgroup: fix missing pd_online_fn() while activating policy	2023-02-06 07:56:15 +01:00
blk-core.c	block: fix use-after-free of q->q_usage_counter	2023-10-10 21:53:36 +02:00
blk-crypto-fallback.c	block: rename generic_make_request to submit_bio_noacct	2020-07-01 07:27:24 -06:00
blk-crypto-internal.h	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-17 11:47:32 +02:00
blk-crypto.c	blk-crypto: make blk_crypto_evict_key() more robust	2023-05-17 11:47:32 +02:00
blk-exec.c	block: add a blk_account_io_merge_bio helper	2020-05-27 05:21:23 -06:00
blk-flush.c	block: Fix fsync always failed if once failed	2022-01-27 10:54:30 +01:00
blk-integrity.c	block: flush the integrity workqueue in blk_integrity_unregister	2021-09-30 10:11:06 +02:00
blk-ioc.c	block: remove retry loop in ioc_release_fn()	2020-07-16 10:22:15 -06:00
blk-iocost.c	blk-iocost: Fix an UBSAN shift-out-of-bounds warning	2024-02-23 08:42:21 +01:00
blk-iolatency.c	blk-iolatency: Fix inflight count imbalances and IO hangs on offline	2022-06-09 10:21:29 +02:00
blk-lib.c	block: add a bdev_is_partition helper	2020-09-25 08:18:57 -06:00
blk-map.c	block-map: add __GFP_ZERO flag for alloc_page in function bio_copy_kern	2022-05-12 12:25:45 +02:00
blk-merge.c	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-17 11:47:32 +02:00
blk-mq-cpumap.c	blk-mq: remove the calling of local_memory_node()	2020-10-20 07:08:17 -06:00
blk-mq-debugfs-zoned.c	block: Cleanup license notice	2019-01-17 21:21:40 -07:00
blk-mq-debugfs.c	blk-mq: don't create hctx debugfs dir until q->debugfs_dir is created	2022-08-21 15:15:35 +02:00
blk-mq-debugfs.h	blk-mq: no need to check return value of debugfs_create functions	2019-06-13 03:00:30 -06:00
blk-mq-pci.c	block: Fix blk_mq_*_map_queues() kernel-doc headers	2019-05-31 15:12:34 -06:00
blk-mq-rdma.c	block: Fix blk_mq_*_map_queues() kernel-doc headers	2019-05-31 15:12:34 -06:00
blk-mq-sched.c	blk-mq: correct stale comment of .get_budget	2023-03-11 16:39:15 +01:00
blk-mq-sched.h	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
blk-mq-sysfs.c	blk-mq: fix possible memleak when register 'hctx' failed	2023-01-14 10:16:19 +01:00
blk-mq-tag.c	blk-mq: avoid to iterate over stale request	2021-09-30 10:11:05 +02:00
blk-mq-tag.h	blk-mq: clear stale request in tags->rq[] before freeing one request pool	2021-07-14 16:55:58 +02:00
blk-mq-virtio.c	blk-mq: Fix typo in comment	2020-03-17 20:55:21 +01:00
blk-mq.c	blk-mq: fix IO hang from sbitmap wakeup race	2024-02-23 08:42:14 +01:00
blk-mq.h	blk-mq: grab rq->refcount before calling ->fn in blk_mq_tagset_busy_iter	2021-07-14 16:55:58 +02:00
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2022-01-27 10:54:08 +01:00
blk-pm.h	scsi: block: Do not accept any requests while suspended	2021-01-12 20:18:17 +01:00
blk-rq-qos.c	rq-qos: fix missed wake-ups in rq_qos_throttle try two	2021-07-19 09:45:00 +02:00
blk-rq-qos.h	block: fix race between adding/removing rq qos and normal IO	2021-07-14 16:56:00 +02:00
blk-settings.c	blk-settings: align max_sectors on "logical_block_size" boundary	2021-03-04 11:38:22 +01:00
blk-stat.c	blk-stat: make q->stats->lock irqsafe	2020-09-01 16:48:46 -06:00
blk-stat.h	block: deactivate blk_stat timer in wbt_disable_default()	2018-12-12 06:47:51 -07:00
blk-sysfs.c	block: fix use-after-free of q->q_usage_counter	2023-10-10 21:53:36 +02:00
blk-throttle.c	blk-throttle: fix lockdep warning of "cgroup_mutex or RCU read lock required!"	2023-12-20 15:44:31 +01:00
blk-timeout.c	block: blk-timeout: delete duplicated word	2020-07-31 16:29:47 -06:00
blk-wbt.c	blk-wbt: fix that 'rwb->wc' is always set to 1 in wbt_init()	2022-10-30 09:41:19 +01:00
blk-wbt.h	blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()	2021-07-14 16:56:12 +02:00
blk-zoned.c	blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN	2021-09-18 13:40:06 +02:00
blk.h	block: bump max plugged deferred size from 16 to 32	2021-11-18 14:03:57 +01:00
bounce.c	block: make bio_crypt_clone() able to fail	2020-10-05 10:47:43 -06:00
bsg-lib.c	block: drop double zeroing	2020-09-23 09:18:13 -06:00
bsg.c	scsi: bsg: Remove support for SCSI_IOCTL_SEND_COMMAND	2021-09-18 13:40:11 +02:00
cmdline-parser.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
elevator.c	block/wbt: fix negative inflight counter when remove scsi device	2022-02-23 12:01:04 +01:00
genhd.c	block: Suppress uevent for hidden device when removed	2021-03-30 14:31:52 +02:00
ioctl.c	block/compat_ioctl: fix range check in BLKGETSIZE	2022-04-27 13:53:57 +02:00
ioprio.c	block: fix ioprio_get(IOPRIO_WHO_PGRP) vs setuid(2)	2021-12-14 11:32:40 +01:00
Kconfig	blk-wbt: Remove obsolete multiqueue I/O scheduling comment	2020-09-01 16:49:26 -06:00
Kconfig.iosched	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
keyslot-manager.c	blk-crypto: make blk_crypto_evict_key() more robust	2023-05-17 11:47:32 +02:00
kyber-iosched.c	kyber: fix out of bounds access when preempted	2021-05-19 10:13:13 +02:00
Makefile	blk-mq: merge blk-softirq.c into blk-mq.c	2020-06-24 09:15:56 -06:00
mq-deadline.c	block: return ELEVATOR_DISCARD_MERGE if possible	2021-09-15 09:50:28 +02:00
opal_proto.h	block: sed-opal: Change the check condition for regular session validity	2020-03-12 08:00:10 -06:00
scsi_ioctl.c	drivers-5.10-2020-10-12	2020-10-13 13:04:41 -07:00
sed-opal.c	block: sed-opal: kmalloc the cmd/resp buffers	2022-11-25 17:45:43 +01:00
t10-pi.c	block: Allow t10-pi to be modular	2020-01-06 20:59:04 -07:00