Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
2009-03-16 07:55:37 -07:00
2008-10-16 11:21:45 -07:00
2008-03-10 18:01:20 -07:00
2008-07-24 10:47:37 -07:00
2009-01-08 16:29:41 +00:00
2009-01-12 20:56:32 +01:00
2007-05-04 17:59:05 -07:00
2007-05-04 17:59:05 -07:00
2007-05-04 17:59:05 -07:00
2007-05-04 17:59:05 -07:00
2007-05-04 17:59:05 -07:00
2009-02-22 09:23:02 -08:00
2007-05-04 17:59:05 -07:00
2009-01-12 20:56:32 +01:00
2008-07-24 10:47:34 -07:00
2008-11-19 18:49:59 -08:00
2008-02-03 17:31:49 +02:00
2008-05-18 13:28:49 -07:00
2007-05-08 11:15:26 -07:00
2008-02-06 10:41:16 -08:00
2009-03-27 14:51:15 +01:00
2008-04-28 08:58:41 -07:00
2009-01-06 15:59:27 -08:00
2009-01-06 15:59:27 -08:00
2009-03-17 09:30:36 +09:00
2008-07-26 12:00:12 -07:00
2007-10-16 09:43:22 -07:00
2008-10-16 11:21:42 -07:00
2007-05-08 11:15:32 -07:00
2008-07-04 10:40:08 -07:00