Theodore Ts'o d76a3a7711 ext4/jbd2: don't wait (forever) for stale tid caused by wraparound
In the case where an inode has a very stale transaction id (tid) in
i_datasync_tid or i_sync_tid, it's possible that after a very large
(2**31) number of transactions, that the tid number space might wrap,
causing tid_geq()'s calculations to fail.

Commit deeeaf13 "jbd2: fix fsync() tid wraparound bug", later modified
by commit e7b04ac0 "jbd2: don't wake kjournald unnecessarily",
attempted to fix this problem, but it only avoided kjournald spinning
forever by fixing the logic in jbd2_log_start_commit().

Unfortunately, in the codepaths in fs/ext4/fsync.c and fs/ext4/inode.c
that might call jbd2_log_start_commit() with a stale tid, those
functions will subsequently call jbd2_log_wait_commit() with the same
stale tid, and then wait for a very long time.  To fix this, we
replace the calls to jbd2_log_start_commit() and
jbd2_log_wait_commit() with a call to a new function,
jbd2_complete_transaction(), which will correctly handle stale tid's.

As a bonus, jbd2_complete_transaction() will avoid locking
j_state_lock for writing unless a commit needs to be started.  This
should have a small (but probably not measurable) improvement for
ext4's scalability.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Reported-by: George Barnett <gbarnett@atlassian.com>
Cc: stable@vger.kernel.org
2013-04-03 22:02:52 -04:00
..
2013-03-02 16:33:54 -08:00
2013-02-21 15:27:22 -08:00
2013-03-01 13:39:00 -08:00
2013-03-28 15:51:33 -07:00
2013-01-02 17:36:10 -08:00
2013-02-21 12:11:44 -08:00
2013-03-02 16:46:07 -08:00
2013-01-03 14:34:06 -08:00
2012-07-30 17:25:21 -07:00
2012-10-08 13:50:20 +10:30
2012-12-02 00:05:12 +00:00
2012-09-20 14:31:45 +02:00
2012-07-30 17:25:11 -07:00
2013-02-25 09:24:55 -05:00
2013-02-21 12:05:51 -08:00
2012-11-08 16:58:31 +01:00
2012-12-24 09:36:38 -07:00
2012-09-30 18:02:20 -07:00
2012-10-16 18:49:15 -07:00
2013-02-26 02:46:08 -05:00
2012-11-22 13:43:27 +09:00
2013-01-24 09:04:04 +01:00
2012-11-28 21:49:02 -05:00
2013-02-22 23:31:31 -05:00
2012-11-08 16:58:30 +01:00
2013-01-25 21:03:54 -08:00
2012-11-23 12:23:40 +01:00
2013-02-06 15:59:47 -05:00
2012-12-14 13:05:26 +10:30
2013-01-29 13:59:57 -05:00
2012-09-07 14:57:45 -04:00
2012-09-11 10:15:02 +02:00
2012-11-21 15:09:26 -08:00
2013-01-10 11:44:38 -06:00
2012-07-17 09:13:37 -07:00
2013-01-29 19:32:58 -08:00
2012-11-20 16:15:02 +10:00
2012-11-03 14:50:15 -04:00
2012-10-10 01:15:44 -04:00
2012-12-12 17:38:33 -08:00
2013-03-22 16:41:20 -07:00
2013-01-21 17:18:20 +10:30
2012-12-14 13:06:40 +10:30
2012-12-25 18:45:06 -05:00
2013-03-02 16:46:07 -08:00
2012-12-11 17:22:27 -08:00
2012-11-13 09:13:50 -05:00
2012-10-17 15:53:02 -05:00
2012-10-10 22:41:05 -04:00
2012-07-31 18:42:43 -07:00
2013-02-25 21:18:18 -08:00
2013-02-21 12:05:51 -08:00
2013-02-21 13:41:04 -08:00
2013-01-24 15:37:26 +01:00
2013-01-03 15:57:14 -08:00
2013-02-26 09:34:29 -08:00
2013-01-23 13:44:00 -05:00
2012-11-16 14:33:04 -08:00
2012-10-06 03:05:01 +09:00
2013-02-21 12:05:51 -08:00
2013-02-19 08:43:34 +01:00
2013-02-03 15:09:26 -05:00
2012-12-18 15:02:13 -08:00
2012-12-18 15:02:14 -08:00
2013-02-10 19:41:08 -05:00
2012-12-24 09:36:38 -07:00
2013-02-14 09:21:15 -05:00
2013-02-21 14:58:40 -08:00
2012-08-21 16:28:31 +02:00
2012-10-09 16:22:32 +09:00
2012-07-22 23:57:55 +04:00
2013-01-15 22:43:15 -08:00
2013-03-20 12:10:38 -04:00
2013-02-08 18:28:04 +01:00
2012-09-05 17:21:36 -07:00
2013-01-25 15:06:01 -08:00