android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
android_kernel_xiaomi_sm8450/net/sched
History
Davide Caratti 81fbdd4565 net/sched: sch_ets: don't remove idle classes from the round-robin list 
[ Upstream commit c062f2a0b04d86c5b8c9d973bea43493eaca3d32 ]

Shuang reported that the following script:

 1) tc qdisc add dev ddd0 handle 10: parent 1: ets bands 8 strict 4 priomap 7 7 7 7 7 7 7 7 7 7 7 7 7 7 7 7
 2) mausezahn ddd0  -A 10.10.10.1 -B 10.10.10.2 -c 0 -a own -b 00:c1:a0:c1:a0:00 -t udp &
 3) tc qdisc change dev ddd0 handle 10: ets bands 4 strict 2 quanta 2500 2500 priomap 3 3 3 3 3 3 3 3 3 3 3 3 3 3 3 3

crashes systematically when line 2) is commented:

 list_del corruption, ffff8e028404bd30->next is LIST_POISON1 (dead000000000100)
 ------------[ cut here ]------------
 kernel BUG at lib/list_debug.c:47!
 invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
 CPU: 0 PID: 954 Comm: tc Not tainted 5.16.0-rc4+ #478
 Hardware name: Red Hat KVM, BIOS 1.11.1-4.module+el8.1.0+4066+0f1aadab 04/01/2014
 RIP: 0010:__list_del_entry_valid.cold.1+0x12/0x47
 Code: fe ff 0f 0b 48 89 c1 4c 89 c6 48 c7 c7 08 42 1b 87 e8 1d c5 fe ff 0f 0b 48 89 fe 48 89 c2 48 c7 c7 98 42 1b 87 e8 09 c5 fe ff <0f> 0b 48 c7 c7 48 43 1b 87 e8 fb c4 fe ff 0f 0b 48 89 f2 48 89 fe
 RSP: 0018:ffffae46807a3888 EFLAGS: 00010246
 RAX: 000000000000004e RBX: 0000000000000007 RCX: 0000000000000202
 RDX: 0000000000000000 RSI: ffffffff871ac536 RDI: 00000000ffffffff
 RBP: ffffae46807a3a10 R08: 0000000000000000 R09: c0000000ffff7fff
 R10: 0000000000000001 R11: ffffae46807a36a8 R12: ffff8e028404b800
 R13: ffff8e028404bd30 R14: dead000000000100 R15: ffff8e02fafa2400
 FS:  00007efdc92e4480(0000) GS:ffff8e02fb600000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000682f48 CR3: 00000001058be000 CR4: 0000000000350ef0
 Call Trace:
  <TASK>
  ets_qdisc_change+0x58b/0xa70 [sch_ets]
  tc_modify_qdisc+0x323/0x880
  rtnetlink_rcv_msg+0x169/0x4a0
  netlink_rcv_skb+0x50/0x100
  netlink_unicast+0x1a5/0x280
  netlink_sendmsg+0x257/0x4d0
  sock_sendmsg+0x5b/0x60
  ____sys_sendmsg+0x1f2/0x260
  ___sys_sendmsg+0x7c/0xc0
  __sys_sendmsg+0x57/0xa0
  do_syscall_64+0x3a/0x80
  entry_SYSCALL_64_after_hwframe+0x44/0xae
 RIP: 0033:0x7efdc8031338
 Code: 89 02 48 c7 c0 ff ff ff ff eb b5 0f 1f 80 00 00 00 00 f3 0f 1e fa 48 8d 05 25 43 2c 00 8b 00 85 c0 75 17 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 58 c3 0f 1f 80 00 00 00 00 41 54 41 89 d4 55
 RSP: 002b:00007ffdf1ce9828 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
 RAX: ffffffffffffffda RBX: 0000000061b37a97 RCX: 00007efdc8031338
 RDX: 0000000000000000 RSI: 00007ffdf1ce9890 RDI: 0000000000000003
 RBP: 0000000000000000 R08: 0000000000000001 R09: 000000000078a940
 R10: 000000000000000c R11: 0000000000000246 R12: 0000000000000001
 R13: 0000000000688880 R14: 0000000000000000 R15: 0000000000000000
  </TASK>
 Modules linked in: sch_ets sch_tbf dummy rfkill iTCO_wdt iTCO_vendor_support intel_rapl_msr intel_rapl_common joydev pcspkr i2c_i801 virtio_balloon i2c_smbus lpc_ich ip_tables xfs libcrc32c crct10dif_pclmul crc32_pclmul crc32c_intel serio_raw ghash_clmulni_intel ahci libahci libata virtio_blk virtio_console virtio_net net_failover failover sunrpc dm_mirror dm_region_hash dm_log dm_mod [last unloaded: sch_ets]
 ---[ end trace f35878d1912655c2 ]---
 RIP: 0010:__list_del_entry_valid.cold.1+0x12/0x47
 Code: fe ff 0f 0b 48 89 c1 4c 89 c6 48 c7 c7 08 42 1b 87 e8 1d c5 fe ff 0f 0b 48 89 fe 48 89 c2 48 c7 c7 98 42 1b 87 e8 09 c5 fe ff <0f> 0b 48 c7 c7 48 43 1b 87 e8 fb c4 fe ff 0f 0b 48 89 f2 48 89 fe
 RSP: 0018:ffffae46807a3888 EFLAGS: 00010246
 RAX: 000000000000004e RBX: 0000000000000007 RCX: 0000000000000202
 RDX: 0000000000000000 RSI: ffffffff871ac536 RDI: 00000000ffffffff
 RBP: ffffae46807a3a10 R08: 0000000000000000 R09: c0000000ffff7fff
 R10: 0000000000000001 R11: ffffae46807a36a8 R12: ffff8e028404b800
 R13: ffff8e028404bd30 R14: dead000000000100 R15: ffff8e02fafa2400
 FS:  00007efdc92e4480(0000) GS:ffff8e02fb600000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000682f48 CR3: 00000001058be000 CR4: 0000000000350ef0
 Kernel panic - not syncing: Fatal exception in interrupt
 Kernel Offset: 0x4e00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
 ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]---

we can remove 'q->classes[i].alist' only if DRR class 'i' was part of the
active list. In the ETS scheduler DRR classes belong to that list only if
the queue length is greater than zero: we need to test for non-zero value
of 'q->classes[i].qdisc->q.qlen' before removing from the list, similarly
to what has been done elsewhere in the ETS code.

Fixes: de6d25924c2a ("net/sched: sch_ets: don't peek at classes beyond 'nbands'")
Reported-by: Shuang Li <shuali@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-12-22 09:30:54 +01:00
..
act_api.c
net: sched: fix error return code in tcf_del_walker()
2021-07-19 09:44:51 +02:00
act_bpf.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_connmark.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_csum.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_ct.c
net/sched: act_ct: remove and free nf_table callbacks
2021-07-25 14:36:19 +02:00
act_ctinfo.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
act_gact.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_gate.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
act_ife.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_ipt.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_meta_mark.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_mirred.c
net: sched: act_mirred: drop dst for the direction from egress to ingress
2021-11-26 10:39:16 +01:00
act_mpls.c
net/sched: act_mpls: ensure LSE is pullable before reading it
2020-12-03 11:13:37 -08:00
act_nat.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_pedit.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_police.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_sample.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_simple.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_skbedit.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_skbmod.c
net/sched: act_skbmod: Skip non-Ethernet packets
2021-07-28 14:35:40 +02:00
act_tunnel_key.c
net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels
2020-10-20 21:10:41 -07:00
act_vlan.c
net/sched: act_vlan: Fix modify to allow 0
2021-07-14 16:56:19 +02:00
cls_api.c
net: Fix offloading indirect devices dependency on qdisc order creation
2021-09-18 13:40:30 +02:00
cls_basic.c
net_sched: fix ops->bind_class() implementations
2020-01-27 10:51:43 +01:00
cls_bpf.c
net_sched: fix ops->bind_class() implementations
2020-01-27 10:51:43 +01:00
cls_cgroup.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_flow.c
Remove uninitialized_var() macro for v5.9-rc1
2020-08-04 13:49:43 -07:00
cls_flower.c
net: sched: flower: protect fl_walk() with rcu
2021-10-06 15:55:58 +02:00
cls_fw.c
net_sched: fix ops->bind_class() implementations
2020-01-27 10:51:43 +01:00
cls_matchall.c
net: qos offload add flow status with dropped count
2020-06-19 12:53:30 -07:00
cls_route.c
net_sched: cls_route: remove the right filter from hashtable
2020-03-16 01:59:32 -07:00
cls_rsvp6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.h
cls_rsvp: fix rsvp_policy
2020-02-01 12:25:06 -08:00
cls_tcindex.c
net: sched: fix memory leak in tcindex_partial_destroy_work
2021-07-28 14:35:38 +02:00
cls_u32.c
net/sched: cls_u32: Replace one-element array with flexible-array member
2020-09-28 18:48:42 -07:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_nbyte.c
net: sched: Replace zero-length array with flexible-array member
2020-02-29 21:27:02 -08:00
em_text.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_u32.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ematch.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
Kconfig
net: sched: incorrect Kconfig dependencies on Netfilter modules
2021-02-23 15:53:23 +01:00
Makefile
net: qos: introduce a gate control flow action
2020-05-01 16:08:19 -07:00
sch_api.c
net: prevent user from passing illegal stab size
2021-10-17 10:43:33 +02:00
sch_atm.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
sch_cake: do not call cake_destroy() from cake_init()
2021-12-22 09:30:53 +01:00
sch_cbq.c
net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed
2021-09-15 09:50:45 +02:00
sch_cbs.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_choke.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_codel.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_drr.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_dsmark.c
sch_dsmark: fix a NULL deref in qdisc_reset()
2021-06-03 09:00:50 +02:00
sch_etf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_ets.c
net/sched: sch_ets: don't remove idle classes from the round-robin list
2021-12-22 09:30:54 +01:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-13 10:04:26 +02:00
sch_fq_codel.c
fq_codel: reject silly quantum parameters
2021-09-22 12:28:05 +02:00
sch_fq_pie.c
net/sched: fq_pie: prevent dismantle issue
2021-12-14 11:32:37 +01:00
sch_fq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_generic.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 14:03:53 +01:00
sch_gred.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_hfsc.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
sch_hhf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_htb.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
sch_ingress.c
net: sched: Pass ingress block to tcf_classify_ingress
2020-02-19 17:49:48 -08:00
sch_mq.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 14:03:53 +01:00
sch_mqprio.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 14:03:53 +01:00
sch_multiq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_netem.c
netem: fix zero division in tabledist
2020-10-29 11:45:47 -07:00
sch_pie.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_plug.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_prio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_qfq.c
pkt_sched: sch_qfq: fix qfq_change_class() error path
2021-07-14 16:56:25 +02:00
sch_red.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_sfb.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_sfq.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_skbprio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_taprio.c
net/sched: sch_taprio: fix undefined behavior in ktime_mono_to_any
2021-11-18 14:04:27 +01:00
sch_tbf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_teql.c
net: sched: sch_teql: fix null-pointer dereference
2021-04-14 08:42:02 +02:00