Matthieu Baerts (NGI0) f291dc4cbc mptcp: fix sometimes-uninitialized warning ... Nathan reported this issue: $ make -skj"$(nproc)" ARCH=x86_64 LLVM=1 LLVM_IAS=1 mrproper allmodconfig net/mptcp/subflow.o net/mptcp/subflow.c:877:6: warning: variable 'incr' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 877 | if (WARN_ON_ONCE(offset > skb->len)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:101:33: note: expanded from macro 'WARN_ON_ONCE' 101 | #define WARN_ON_ONCE(condition) ({ \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 102 | int __ret_warn_on = !!(condition); \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 103 | if (unlikely(__ret_warn_on)) \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 104 | __WARN_FLAGS(BUGFLAG_ONCE | \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 105 | BUGFLAG_TAINT(TAINT_WARN)); \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 106 | unlikely(__ret_warn_on); \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 107 | }) | ~~ net/mptcp/subflow.c:893:6: note: uninitialized use occurs here 893 | if (incr) | ^~~~ net/mptcp/subflow.c:877:2: note: remove the 'if' if its condition is always false 877 | if (WARN_ON_ONCE(offset > skb->len)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 878 | goto out; | ~~~~~~~~ net/mptcp/subflow.c:874:18: note: initialize the variable 'incr' to silence this warning 874 | u32 offset, incr, avail_len; | ^ | = 0 1 warning generated. As mentioned by Nathan, this issue is present because 5.10 does not include commit ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling"), which removed the use of 'incr' in the error path added by this change. This other commit does not really look suitable for stable, hence this dedicated patch for 5.10. Fixes: e93fa44f07 ("mptcp: fix duplicate data handling") Reported-by: Nathan Chancellor <nathan@kernel.org> Closes: https://lore.kernel.org/20240928175524.GA1713144@thelio-3990X Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-10-17 15:07:59 +02:00
..
crypto_test.c	mptcp: move crypto test to KUNIT	2020-06-26 16:21:39 -07:00
crypto.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-08-05 20:13:21 -07:00
ctrl.c	mptcp: enable JOIN requests even if cookies are in use	2020-07-31 16:55:32 -07:00
diag.c	mptcp: correct MPTCP_SUBFLOW_ATTR_SSN_OFFSET reserved size	2024-09-04 13:17:32 +02:00
Kconfig	mptcp: depends on IPV6 but not as a module	2020-10-21 08:05:40 -07:00
Makefile	mptcp: enable JOIN requests even if cookies are in use	2020-07-31 16:55:32 -07:00
mib.c	mptcp: mib: count MPJ with backup flag	2024-08-19 05:41:21 +02:00
mib.h	mptcp: mib: count MPJ with backup flag	2024-08-19 05:41:21 +02:00
mptcp_diag.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
options.c	mptcp: validate 'id' when stopping the ADD_ADDR retransmit timer	2024-10-17 15:07:37 +02:00
pm_netlink.c	mptcp: pm: Fix uaf in __timer_delete_sync	2024-10-17 15:07:37 +02:00
pm.c	mptcp: pr_debug: add missing \n at the end	2024-09-12 11:06:44 +02:00
protocol.c	mptcp: pr_debug: add missing \n at the end	2024-09-12 11:06:44 +02:00
protocol.h	mptcp: validate 'id' when stopping the ADD_ADDR retransmit timer	2024-10-17 15:07:37 +02:00
subflow.c	mptcp: fix sometimes-uninitialized warning	2024-10-17 15:07:59 +02:00
syncookies.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
token_test.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
token.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00