Hans de Goede
6fb08f1a5f
HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices
...
Commit dbcbabf7da92 ("HID: logitech-dj: fix return value of
logi_dj_recv_query_hidpp_devices") made logi_dj_recv_query_hidpp_devices
return the return value of hid_hw_raw_request instead of unconditionally
returning 0.
But hid_hw_raw_request returns the report-size on a successful request
(and a negative error-code on failure) where as the callers of
logi_dj_recv_query_hidpp_devices expect a 0 return on success.
This commit fixes things so that either the negative error gets returned
or 0 on success, fixing HID++ receivers such as the Logitech nano receivers
no longer working.
Cc: YueHaibing <yuehaibing@huawei.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices")
Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reported-by: Rafael J. Wysocki <rjw@rjwysocki.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Rafael J. Wysocki <rjw@rjwysocki.net>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2019-08-05 12:49:28 +02:00
..
2019-05-24 17:36:47 +02:00
2019-07-11 11:17:09 -07:00
2019-06-19 17:09:55 +02:00
2019-06-13 10:35:55 +02:00
2019-07-09 10:59:26 -07:00
2019-05-30 11:26:41 -07:00
2019-07-09 12:34:26 -07:00
2019-07-09 10:28:47 -07:00
2019-07-09 12:34:26 -07:00
2019-07-06 21:44:25 +02:00
2019-06-21 09:58:42 -07:00
2019-06-14 14:20:46 -06:00
2019-07-08 20:57:08 -07:00
2019-06-28 08:50:09 +08:00
2019-07-10 11:05:26 +02:00
2019-05-30 11:26:35 -07:00
2019-06-17 22:28:29 +02:00
2019-07-08 11:00:02 +02:00
2019-06-19 17:09:55 +02:00
2019-07-08 20:57:08 -07:00
2019-06-13 17:34:56 -10:00
2019-05-24 17:27:11 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:46 +02:00
2019-07-06 10:06:37 -07:00
2019-06-19 17:09:07 +02:00
2019-06-27 10:24:47 -07:00
2019-05-30 11:29:53 -07:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-07-09 12:34:26 -07:00
2019-06-08 12:52:42 -07:00
2019-06-19 17:09:11 +02:00
2019-05-21 10:50:46 +02:00
2019-07-09 09:15:03 -07:00
2019-07-09 12:34:26 -07:00
2019-08-05 12:49:28 +02:00
2019-06-05 17:37:07 +02:00
2019-07-08 17:49:45 -07:00
2019-07-11 14:44:13 -07:00
2019-05-21 10:50:46 +02:00
2019-07-11 10:55:49 -07:00
2019-07-09 09:04:31 -07:00
2019-07-09 12:34:26 -07:00
2019-06-05 17:37:06 +02:00
2019-07-03 10:50:21 +02:00
2019-07-11 15:14:01 -07:00
2019-07-09 10:05:22 -07:00
2019-05-21 10:50:46 +02:00
2019-07-04 17:26:48 +02:00
2019-06-05 17:37:17 +02:00
2019-07-10 11:04:17 +02:00
2019-07-11 10:55:49 -07:00
2019-07-09 08:59:39 -07:00
2019-06-21 03:14:30 -06:00
2019-06-19 17:09:08 +02:00
2019-06-19 17:09:55 +02:00
2019-06-05 17:37:17 +02:00
2019-07-10 18:43:43 -07:00
2019-07-11 10:55:49 -07:00
2019-07-09 09:07:00 -07:00
2019-06-19 17:09:55 +02:00
2019-07-11 15:14:01 -07:00
2019-07-09 08:59:39 -07:00
2019-07-09 12:34:26 -07:00
2019-06-21 09:58:42 -07:00
2019-07-09 12:34:26 -07:00
2019-07-11 10:55:49 -07:00
2019-07-02 12:00:50 -07:00
2019-06-05 17:36:37 +02:00
2019-05-21 10:50:46 +02:00
2019-07-10 18:43:43 -07:00
2019-07-11 15:17:41 -07:00
2019-06-19 17:09:55 +02:00
2019-06-05 17:37:16 +02:00
2019-06-26 10:53:57 +02:00
2019-06-08 12:52:42 -07:00
2019-07-09 12:34:26 -07:00
2019-07-11 10:55:49 -07:00
2019-07-09 12:34:26 -07:00
2019-07-08 09:54:55 -07:00
2019-06-19 17:09:55 +02:00
2019-06-29 16:51:10 +08:00
2019-07-09 12:34:26 -07:00
2019-05-30 11:25:19 -07:00
2019-07-08 10:59:38 +02:00
2019-07-08 18:28:44 -07:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:39 -07:00
2019-06-15 13:43:06 -07:00
2019-07-09 08:57:45 -07:00
2019-05-30 11:26:37 -07:00
2019-06-08 17:40:28 +02:00
2019-07-09 12:34:26 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-07-11 15:17:41 -07:00
2019-05-24 17:36:45 +02:00
2019-07-11 15:17:41 -07:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-07-09 10:05:22 -07:00
2019-06-10 18:07:39 +02:00
2019-07-04 17:35:11 +01:00
2019-06-05 17:36:37 +02:00
2019-06-25 08:05:34 +03:00
2019-07-11 15:17:41 -07:00
2019-07-11 15:14:01 -07:00
2019-05-21 10:50:46 +02:00
2019-06-05 17:36:37 +02:00
2019-07-08 18:28:44 -07:00
2019-06-14 14:25:43 +03:00
2019-07-09 12:34:26 -07:00
2019-06-19 17:09:55 +02:00
2019-07-11 15:17:41 -07:00
2019-06-19 17:09:07 +02:00
2019-06-19 17:09:55 +02:00
2019-07-11 10:55:49 -07:00
2019-07-09 12:34:26 -07:00
2019-05-21 10:50:46 +02:00
2019-05-27 11:08:22 -04:00
2019-05-21 10:50:46 +02:00
2019-05-24 17:39:00 +02:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2019-07-09 12:34:26 -07:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:46 +02:00
2019-06-12 14:23:50 +02:00
2019-06-12 14:23:50 +02:00