Tommi Rantala
642a8439dd
tipc: fix tipc_mon_delete() oops in tipc_enable_bearer() error path
Calling tipc_mon_delete() before the monitor has been created will oops.
This can happen in tipc_enable_bearer() error path if tipc_disc_create()
fails.
[ 48.589074] BUG: unable to handle kernel paging request at 0000000000001008
[ 48.590266] IP: tipc_mon_delete+0xea/0x270 [tipc]
[ 48.591223] PGD 1e60c5067 P4D 1e60c5067 PUD 1eb0cf067 PMD 0
[ 48.592230] Oops: 0000 [#1] SMP KASAN
[ 48.595610] CPU: 5 PID: 1199 Comm: tipc Tainted: G B 4.15.0-rc4-pc64-dirty #5
[ 48.597176] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-2.fc27 04/01/2014
[ 48.598489] RIP: 0010:tipc_mon_delete+0xea/0x270 [tipc]
[ 48.599347] RSP: 0018:ffff8801d827f668 EFLAGS: 00010282
[ 48.600705] RAX: ffff8801ee813f00 RBX: 0000000000000204 RCX: 0000000000000000
[ 48.602183] RDX: 1ffffffff1de6a75 RSI: 0000000000000297 RDI: 0000000000000297
[ 48.604373] RBP: 0000000000000000 R08: 0000000000000000 R09: fffffbfff1dd1533
[ 48.605607] R10: ffffffff8eafbb05 R11: fffffbfff1dd1534 R12: 0000000000000050
[ 48.607082] R13: dead000000000200 R14: ffffffff8e73f310 R15: 0000000000001020
[ 48.608228] FS: 00007fc686484800(0000) GS:ffff8801f5540000(0000) knlGS:0000000000000000
[ 48.610189] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 48.611459] CR2: 0000000000001008 CR3: 00000001dda70002 CR4: 00000000003606e0
[ 48.612759] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 48.613831] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 48.615038] Call Trace:
[ 48.615635] tipc_enable_bearer+0x415/0x5e0 [tipc]
[ 48.620623] tipc_nl_bearer_enable+0x1ab/0x200 [tipc]
[ 48.625118] genl_family_rcv_msg+0x36b/0x570
[ 48.631233] genl_rcv_msg+0x5a/0xa0
[ 48.631867] netlink_rcv_skb+0x1cc/0x220
[ 48.636373] genl_rcv+0x24/0x40
[ 48.637306] netlink_unicast+0x29c/0x350
[ 48.639664] netlink_sendmsg+0x439/0x590
[ 48.642014] SYSC_sendto+0x199/0x250
[ 48.649912] do_syscall_64+0xfd/0x2c0
[ 48.650651] entry_SYSCALL64_slow_path+0x25/0x25
[ 48.651843] RIP: 0033:0x7fc6859848e3
[ 48.652539] RSP: 002b:00007ffd25dff938 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
[ 48.654003] RAX: ffffffffffffffda RBX: 00007ffd25dff990 RCX: 00007fc6859848e3
[ 48.655303] RDX: 0000000000000054 RSI: 00007ffd25dff990 RDI: 0000000000000003
[ 48.656512] RBP: 00007ffd25dff980 R08: 00007fc685c35fc0 R09: 000000000000000c
[ 48.657697] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000d13010
[ 48.658840] R13: 00007ffd25e009c0 R14: 0000000000000000 R15: 0000000000000000
[ 48.662972] RIP: tipc_mon_delete+0xea/0x270 [tipc] RSP: ffff8801d827f668
[ 48.664073] CR2: 0000000000001008
[ 48.664576] ---[ end trace e811818d54d5ce88 ]---
Acked-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-12-27 10:55:00 -05:00
..
2015-05-14 12:24:45 -04:00
2016-07-26 14:26:42 -07:00
2017-10-13 08:46:00 -07:00
2017-01-20 12:10:17 -05:00
2017-12-27 10:54:59 -05:00
2017-09-01 17:42:05 -07:00
2016-11-18 10:59:15 -05:00
2017-10-13 08:46:00 -07:00
2017-11-01 12:38:45 +09:00
2016-04-07 17:00:13 -04:00
2015-02-27 18:18:48 -05:00
2017-12-26 13:06:36 -05:00
2017-10-13 08:46:01 -07:00
2015-02-27 18:18:48 -05:00
2015-03-05 22:08:42 -05:00
2017-11-11 15:36:05 +09:00
2016-09-02 17:10:24 -07:00
2017-11-04 09:26:51 +09:00
2017-12-27 10:55:00 -05:00
2016-07-26 14:26:42 -07:00
2017-11-16 10:49:00 +09:00
2017-11-16 10:49:00 +09:00
2017-01-16 13:31:53 -05:00
2015-11-20 14:06:10 -05:00
2017-10-26 09:38:34 +09:00
2017-10-13 08:46:00 -07:00
2017-04-13 13:58:22 -04:00
2016-08-18 23:36:07 -07:00
2017-08-23 22:31:38 -07:00
2017-04-13 13:58:22 -04:00
2016-07-26 14:26:42 -07:00
2017-11-16 10:49:00 +09:00
2017-10-13 08:46:00 -07:00
2017-12-05 14:52:41 -05:00
2017-10-13 08:46:00 -07:00
2017-12-13 13:44:36 -05:00
2016-05-03 15:51:16 -04:00
2017-11-01 12:38:45 +09:00
2017-03-28 18:03:33 -07:00
2014-09-01 17:51:48 -07:00
2017-12-01 15:14:22 -05:00
2016-08-26 21:38:41 -07:00