Pavel Skripkin 2b1c85f565 NFC: port100: fix use-after-free in port100_send_complete ... [ Upstream commit f80cfe2f26581f188429c12bd937eb905ad3ac7b ] Syzbot reported UAF in port100_send_complete(). The root case is in missing usb_kill_urb() calls on error handling path of ->probe function. port100_send_complete() accesses devm allocated memory which will be freed on probe failure. We should kill this urbs before returning an error from probe function to prevent reported use-after-free Fail log: BUG: KASAN: use-after-free in port100_send_complete+0x16e/0x1a0 drivers/nfc/port100.c:935 Read of size 1 at addr ffff88801bb59540 by task ksoftirqd/2/26 ... Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description.constprop.0.cold+0x8d/0x303 mm/kasan/report.c:255 __kasan_report mm/kasan/report.c:442 [inline] kasan_report.cold+0x83/0xdf mm/kasan/report.c:459 port100_send_complete+0x16e/0x1a0 drivers/nfc/port100.c:935 __usb_hcd_giveback_urb+0x2b0/0x5c0 drivers/usb/core/hcd.c:1670 ... Allocated by task 1255: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track mm/kasan/common.c:45 [inline] set_alloc_info mm/kasan/common.c:436 [inline] ____kasan_kmalloc mm/kasan/common.c:515 [inline] ____kasan_kmalloc mm/kasan/common.c:474 [inline] __kasan_kmalloc+0xa6/0xd0 mm/kasan/common.c:524 alloc_dr drivers/base/devres.c:116 [inline] devm_kmalloc+0x96/0x1d0 drivers/base/devres.c:823 devm_kzalloc include/linux/device.h:209 [inline] port100_probe+0x8a/0x1320 drivers/nfc/port100.c:1502 Freed by task 1255: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track+0x21/0x30 mm/kasan/common.c:45 kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370 ____kasan_slab_free mm/kasan/common.c:366 [inline] ____kasan_slab_free+0xff/0x140 mm/kasan/common.c:328 kasan_slab_free include/linux/kasan.h:236 [inline] __cache_free mm/slab.c:3437 [inline] kfree+0xf8/0x2b0 mm/slab.c:3794 release_nodes+0x112/0x1a0 drivers/base/devres.c:501 devres_release_all+0x114/0x190 drivers/base/devres.c:530 really_probe+0x626/0xcc0 drivers/base/dd.c:670 Reported-and-tested-by: syzbot+16bcb127fb73baeecb14@syzkaller.appspotmail.com Fixes: 0347a6ab30 ("NFC: port100: Commands mechanism implementation") Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Link: https://lore.kernel.org/r/20220308185007.6987-1-paskripkin@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-16 14:15:59 +01:00
..
fdp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
microread	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
nfcmrvl	nfc: Fix Kconfig indentation	2019-11-20 12:30:40 -08:00
nxp-nci	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
pn533	nfc: pn533: Fix double free when pn533_fill_fragment_skbs() fails	2021-11-18 14:04:27 +01:00
pn544	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
s3fwrn5	nfc: s3fwrn5: Release the nfc firmware	2020-12-30 11:53:53 +01:00
st21nfca	NFC: st21nfca: Fix memory leak in device probe and remove	2022-01-05 12:40:31 +01:00
st95hf	NFC: st95hf: Fix memleak in st95hf_in_send_cmd	2020-08-24 17:34:25 -07:00
st-nci	nfc: st-nci: Remove unnecessary cast	2020-08-20 16:17:45 -07:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mei_phy.c	nfc/mei: convert to SPDX license tags	2019-03-28 02:07:54 +09:00
mei_phy.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfcsim.c	nfc: nfcsim: fix use after free during module unload	2021-08-04 12:46:41 +02:00
port100.c	NFC: port100: fix use-after-free in port100_send_complete	2022-03-16 14:15:59 +01:00
trf7970a.c	nfc: remove unneeded break	2020-10-20 10:36:41 -07:00