Takashi Sakamoto d5a2dcee53 firewire: fix memory leak for payload of request subaction to IEC 61883-1 FCP region ... commit 531390a243ef47448f8bad01c186c2787666bf4d upstream. This patch is fix for Linux kernel v2.6.33 or later. For request subaction to IEC 61883-1 FCP region, Linux FireWire subsystem have had an issue of use-after-free. The subsystem allows multiple user space listeners to the region, while data of the payload was likely released before the listeners execute read(2) to access to it for copying to user space. The issue was fixed by a commit 281e20323a ("firewire: core: fix use-after-free regression in FCP handler"). The object of payload is duplicated in kernel space for each listener. When the listener executes ioctl(2) with FW_CDEV_IOC_SEND_RESPONSE request, the object is going to be released. However, it causes memory leak since the commit relies on call of release_request() in drivers/firewire/core-cdev.c. Against the expectation, the function is never called due to the design of release_client_resource(). The function delegates release task to caller when called with non-NULL fourth argument. The implementation of ioctl_send_response() is the case. It should release the object explicitly. This commit fixes the bug. Cc: <stable@vger.kernel.org> Fixes: 281e20323a ("firewire: core: fix use-after-free regression in FCP handler") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Link: https://lore.kernel.org/r/20230117090610.93792-2-o-takashi@sakamocchi.jp Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-02-15 17:22:09 +01:00
..
core-card.c	firewire: core: extend card->lock in fw_core_handle_bus_reset	2022-05-12 12:25:32 +02:00
core-cdev.c	firewire: fix memory leak for payload of request subaction to IEC 61883-1 FCP region	2023-02-15 17:22:09 +01:00
core-device.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
core-iso.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
core-topology.c	firewire: core: extend card->lock in fw_core_handle_bus_reset	2022-05-12 12:25:32 +02:00
core-transaction.c	firewire: remove check of list iterator against head past the loop body	2022-05-12 12:25:32 +02:00
core.h	firewire: ohci: Replace zero-length array with flexible-array	2020-06-15 23:08:31 -05:00
init_ohci1394_dma.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
net.c	net: add annotations on hh->hh_len lockless accesses	2019-11-07 20:07:30 -08:00
nosy-user.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nosy.c	firewire: nosy: Fix a use-after-free bug in nosy_ioctl()	2021-04-07 15:00:11 +02:00
nosy.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ohci.c	firewire-ohci: use dma_alloc_pages	2020-09-25 06:20:48 +02:00
ohci.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sbp2.c	firewire: remove check of list iterator against head past the loop body	2022-05-12 12:25:32 +02:00