Paul Moore 121973ef1a audit: don't take task_lock() in audit_exe_compare() code path ... commit 47846d51348dd62e5231a83be040981b17c955fa upstream. The get_task_exe_file() function locks the given task with task_lock() which when used inside audit_exe_compare() can cause deadlocks on systems that generate audit records when the task_lock() is held. We resolve this problem with two changes: ignoring those cases where the task being audited is not the current task, and changing our approach to obtaining the executable file struct to not require task_lock(). With the intent of the audit exe filter being to filter on audit events generated by processes started by the specified executable, it makes sense that we would only want to use the exe filter on audit records associated with the currently executing process, e.g. @current. If we are asked to filter records using a non-@current task_struct we can safely ignore the exe filter without negatively impacting the admin's expectations for the exe filter. Knowing that we only have to worry about filtering the currently executing task in audit_exe_compare() we can do away with the task_lock() and call get_mm_exe_file() with @current->mm directly. Cc: <stable@vger.kernel.org> Fixes: 5efc244346 ("audit: fix exe_file access in audit_exe_compare") Reported-by: Andreas Steinmetz <anstein99@googlemail.com> Reviewed-by: John Johansen <john.johanse@canonical.com> Reviewed-by: Mateusz Guzik <mjguzik@gmail.com> Signed-off-by: Paul Moore <paul@paul-moore.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-11-28 16:54:56 +00:00
..
bpf	bpf: Fix precision tracking for BPF_ALU | BPF_TO_BE | BPF_END	2023-11-28 16:54:55 +00:00
cgroup	cgroup: Remove duplicates in cgroup v1 tasks file	2023-10-25 11:54:16 +02:00
configs
debug	kgdb: Flush console before entering kgdb on panic	2023-11-28 16:54:53 +00:00
dma	dma-debug: don't call __dma_entry_alloc_check_leak() under free_entries_lock	2023-10-10 21:53:32 +02:00
entry	entry/kvm: Exit to user mode when TIF_NOTIFY_SIGNAL is set	2023-01-04 11:39:22 +01:00
events	perf/core: Bail out early if the request AUX area is out of bound	2023-11-28 16:54:49 +00:00
futex	futex: Don't include process MM in futex key on no-MMU	2023-11-20 11:06:44 +01:00
gcov	gcov: add support for checksum field	2023-01-14 10:16:24 +01:00
irq	genirq/matrix: Exclude managed interrupts in irq_matrix_allocated()	2023-11-20 11:06:44 +01:00
kcsan	kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures	2023-07-27 08:43:57 +02:00
livepatch	livepatch: Fix missing newline character in klp_resolve_symbols()	2023-11-20 11:06:52 +01:00
locking	locking/ww_mutex/test: Fix potential workqueue corruption	2023-11-28 16:54:49 +00:00
power	PM: EM: fix memory leak with using debugfs_lookup()	2023-03-11 16:39:51 +01:00
printk	printk: ringbuffer: Fix truncating buffer size min_t cast	2023-09-19 12:20:21 +02:00
rcu	rcuscale: Move rcu_scale_writer() schedule_timeout_uninterruptible() to _idle()	2023-09-23 11:01:05 +02:00
sched	sched/uclamp: Ignore (util == 0) optimization in feec() when p_util_max = 0	2023-11-20 11:06:43 +01:00
time	timers/nohz: Switch to ONESHOT_STOPPED in the low-res handler when the tick is stopped	2023-08-30 16:23:17 +02:00
trace	tracing/kprobes: Fix the order of argument descriptions	2023-11-20 11:06:57 +01:00
.gitignore	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:47:37 +02:00
acct.c	acct: fix potential integer overflow in encode_comp_t()	2023-01-14 10:16:14 +01:00
async.c	Revert "module, async: async_synchronize_full() on module init iff async is used"	2022-02-23 12:01:00 +01:00
audit_fsnotify.c	audit: fix potential double free on error path from fsnotify_add_inode_mark	2022-08-31 17:15:13 +02:00
audit_tree.c	audit: move put_tree() to avoid trim_trees refcount underflow and UAF	2021-09-03 10:09:31 +02:00
audit_watch.c	audit: don't take task_lock() in audit_exe_compare() code path	2023-11-28 16:54:56 +00:00
audit.c	audit: improve audit queue handling when "audit=1" on cmdline	2022-02-08 18:30:34 +01:00
audit.h	audit: log AUDIT_TIME_* records only from rules	2022-04-08 14:40:00 +02:00
auditfilter.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
auditsc.c	audit: fix possible soft lockup in __audit_inode_child()	2023-09-19 12:20:13 +02:00
backtracetest.c	treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()	2020-07-30 11:15:58 -07:00
bounds.c
capability.c	LSM: Signal to SafeSetID when setting group IDs	2020-10-13 09:17:34 -07:00
compat.c	sched_getaffinity: don't assume 'cpumask_size()' is fully initialized	2023-04-05 11:23:45 +02:00
configs.c
context_tracking.c	context_tracking: Ensure that the critical path cannot be instrumented	2020-06-11 15:14:36 +02:00
cpu_pm.c	PM: cpu: Make notifier chain use a raw_spinlock_t	2021-09-15 09:50:40 +02:00
cpu.c	cpu/hotplug: Make target_store() a nop when target == state	2023-01-14 10:15:20 +01:00
crash_core.c	crash_core, vmcoreinfo: append 'SECTION_SIZE_BITS' to vmcoreinfo	2021-06-23 14:42:52 +02:00
crash_dump.c
cred.c	Revert "Add a reference to ucounts for each cred"	2021-09-08 08:49:00 +02:00
delayacct.c
dma.c
exec_domain.c
exit.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-01 08:23:21 +01:00
extable.c
fail_function.c	kernel/fail_function: fix memory leak with using debugfs_lookup()	2023-03-11 16:40:18 +01:00
fork.c	kernel/fork: beware of __put_task_struct() calling context	2023-09-23 11:01:05 +02:00
freezer.c	Revert "kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing"	2021-04-07 15:00:14 +02:00
gen_kheaders.sh	kbuild: add variables for compression tools	2020-06-06 23:42:01 +09:00
groups.c	LSM: Signal to SafeSetID when setting group IDs	2020-10-13 09:17:34 -07:00
hung_task.c	kernel/hung_task.c: make type annotations consistent	2020-11-02 12:14:19 -08:00
iomem.c
irq_work.c	irq_work, smp: Allow irq_work on call_single_queue	2020-05-28 10:54:15 +02:00
jump_label.c	jump_label: Fix jump_label_text_reserved() vs __init	2021-07-20 16:05:58 +02:00
kallsyms.c	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
kcmp.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	kcov: make some symbols static	2020-08-12 10:58:02 -07:00
kexec_core.c	kexec: fix a memory leak in crash_shrink_memory()	2023-07-27 08:43:40 +02:00
kexec_elf.c
kexec_file.c	kexec: support purgatories with .text.hot sections	2023-06-21 15:45:37 +02:00
kexec_internal.h	panic, kexec: make __crash_kexec() NMI safe	2023-04-20 12:10:29 +02:00
kexec.c	panic, kexec: make __crash_kexec() NMI safe	2023-04-20 12:10:29 +02:00
kheaders.c	kheaders: Use array declaration instead of char	2023-05-17 11:47:33 +02:00
kmod.c	kmod: remove redundant "be an" in the comment	2020-08-12 10:58:01 -07:00
kprobes.c	kprobes: Prohibit probing on CFI preamble symbol	2023-09-19 12:20:05 +02:00
ksysfs.c	kexec: turn all kexec_mutex acquisitions into trylocks	2023-04-20 12:10:29 +02:00
kthread.c	kthread: Fix PF_KTHREAD vs to_kthread() race	2021-09-03 10:09:31 +02:00
latencytop.c
Makefile	futex: Move to kernel/futex/	2023-01-14 10:15:20 +01:00
module_signature.c	module: harden ELF info handling	2021-03-25 09:04:11 +01:00
module_signing.c	module: harden ELF info handling	2021-03-25 09:04:11 +01:00
module-internal.h
module.c	modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules	2023-09-19 12:20:02 +02:00
notifier.c	notifier: Fix broken error handling pattern	2020-09-01 09:58:03 +02:00
nsproxy.c	nsproxy: support CLONE_NEWTIME with setns()	2020-07-08 11:14:22 +02:00
padata.c	crypto: pcrypt - Fix hungtask for PADATA_RESET	2023-11-28 16:54:51 +00:00
panic.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-01 08:23:21 +01:00
params.c	params: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
pid_namespace.c	rcu-tasks: Fix synchronize_rcu_tasks() VS zap_pid_ns_processes()	2023-03-11 16:39:19 +01:00
pid.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
profile.c	profiling: fix shift too large makes kernel panic	2022-08-21 15:16:05 +02:00
ptrace.c	ptrace: Reimplement PTRACE_KILL by always sending SIGKILL	2022-06-09 10:20:49 +02:00
range.c	kernel.h: split out min()/max() et al. helpers	2020-10-16 11:11:19 -07:00
reboot.c	reboot: fix overflow parsing reboot cpu number	2020-11-14 11:26:03 -08:00
regset.c	regset: kill ->get()	2020-07-27 14:31:12 -04:00
relay.c	relayfs: fix out-of-bounds access in relay_file_read	2023-05-17 11:47:34 +02:00
resource.c	dax/kmem: Fix leak of memory-hotplug resources	2023-03-11 16:40:04 +01:00
rseq.c	rseq: Remove broken uapi field layout on 32-bit little endian	2022-04-08 14:40:03 +02:00
scftorture.c	scftorture: Forgive memory-allocation failure if KASAN	2023-09-23 11:01:05 +02:00
scs.c	mm: memcontrol: account kernel stack per node	2020-08-07 11:33:25 -07:00
seccomp.c	seccomp: Fix setting loaded filter count during TSYNC	2021-08-18 08:59:06 +02:00
signal.c	task_work: unconditionally run task_work from get_signal()	2023-01-04 11:39:23 +01:00
smp.c	smp: Fix offline cpu check in flush_smp_call_function_queue()	2022-04-20 09:23:29 +02:00
smpboot.c	sched/core: Initialize the idle task with preemption disabled	2021-07-14 16:55:50 +02:00
smpboot.h
softirq.c	softirq: Add debug check to __raise_softirq_irqoff()	2020-09-16 15:18:56 +02:00
stackleak.c	gcc-plugins/stackleak: Use noinstr in favor of notrace	2022-02-23 12:01:00 +01:00
stacktrace.c	stacktrace: Remove reliable argument from arch_stack_walk() callback	2020-09-18 14:24:16 +01:00
static_call.c	static_call: Fix unused variable warn w/o MODULE	2021-09-08 08:49:00 +02:00
stop_machine.c	stop_machine, rcu: Mark functions as notrace	2020-10-26 12:12:27 +01:00
sys_ni.c	kernel/sys_ni: add compat entry for fadvise64_64	2022-08-31 17:15:13 +02:00
sys.c	kernel/sys.c: fix and improve control flow in __sys_setres[ug]id()	2023-04-26 11:27:38 +02:00
sysctl-test.c
sysctl.c	sysctl: move some boundary constants from sysctl.c to sysctl_vals	2023-06-28 10:28:09 +02:00
task_work.c	task_work: add helper for more targeted task_work canceling	2023-01-04 11:39:23 +01:00
taskstats.c	taskstats: move specifying netlink policy back to ops	2020-10-02 19:11:12 -07:00
test_kprobes.c
torture.c	torture: Fix hang during kthread shutdown phase	2023-08-30 16:23:17 +02:00
tracepoint.c	tracepoint: Use rcu get state and cond sync for static call updates	2021-09-03 10:09:30 +02:00
tsacct.c	taskstats: Cleanup the use of task->exit_code	2022-01-27 10:54:33 +01:00
ucount.c	Revert "Add a reference to ucounts for each cred"	2021-09-08 08:49:00 +02:00
uid16.c
uid16.h
umh.c	usermodehelper: reset umask to default before executing user process	2020-10-06 10:31:52 -07:00
up.c	smp: Fix smp_call_function_single_async prototype	2021-05-14 09:50:46 +02:00
user_namespace.c	Revert "Add a reference to ucounts for each cred"	2021-09-08 08:49:00 +02:00
user-return-notifier.c
user.c	user.c: make uidhash_table static	2020-06-04 19:06:24 -07:00
usermode_driver.c	bpf: Fix umd memory leak in copy_process()	2021-03-30 14:32:03 +02:00
utsname_sysctl.c
utsname.c	nsproxy: add struct nsset	2020-05-09 13:57:12 +02:00
watch_queue.c	watch_queue: fix IOC_WATCH_QUEUE_SET_SIZE alloc error paths	2023-03-17 08:45:13 +01:00
watchdog_hld.c	watchdog/perf: more properly prevent false positives with turbo modes	2023-07-27 08:43:40 +02:00
watchdog.c	watchdog: export lockup_detector_reconfigure	2022-08-25 11:38:20 +02:00
workqueue_internal.h
workqueue.c	workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()	2023-10-25 11:54:14 +02:00