android_kernel_xiaomi_sm8450/drivers/nfc
Fedor Pchelkin 8978315cb4 nfc: fix memory leak of se_io context in nfc_genl_se_io
[ Upstream commit 25ff6f8a5a3b8dc48e8abda6f013e8cc4b14ffea ]

The callback context for sending/receiving APDUs to/from the selected
secure element is allocated inside nfc_genl_se_io and supposed to be
eventually freed in se_io_cb callback function. However, there are several
error paths where the bwi_timer is not charged to call se_io_cb later, and
the cb_context is leaked.

The patch proposes to free the cb_context explicitly on those error paths.

At the moment we can't simply check 'dev->ops->se_io()' return value as it
may be negative in both cases: when the timer was charged and was not.

Fixes: 5ce3f32b52 ("NFC: netlink: SE API implementation")
Reported-by: syzbot+df64c0a2e8d68e78a4fa@syzkaller.appspotmail.com
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-03-11 16:40:13 +01:00
..
fdp nfc: fdp: Fix potential memory leak in fdp_nci_send() 2022-11-10 18:14:17 +01:00
microread treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
nfcmrvl nfc: nfcmrvl: Fix potential memory leak in nfcmrvl_i2c_nci_send() 2022-11-10 18:14:17 +01:00
nxp-nci nfc: nxp-nci: Fix potential memory leak in nxp_nci_send() 2022-11-10 18:14:17 +01:00
pn533 nfc: pn533: Wait for out_urb's completion in pn533_usb_send_frame() 2023-01-18 11:44:59 +01:00
pn544 treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
s3fwrn5 nfc: s3fwrn5: Fix potential memory leak in s3fwrn5_nci_send() 2022-11-10 18:14:17 +01:00
st21nfca nfc: fix memory leak of se_io context in nfc_genl_se_io 2023-03-11 16:40:13 +01:00
st95hf NFC: st95hf: Fix memleak in st95hf_in_send_cmd 2020-08-24 17:34:25 -07:00
st-nci nfc: fix memory leak of se_io context in nfc_genl_se_io 2023-03-11 16:40:13 +01:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mei_phy.c nfc/mei: convert to SPDX license tags 2019-03-28 02:07:54 +09:00
mei_phy.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
nfcsim.c nfc: nfcsim: fix use after free during module unload 2021-08-04 12:46:41 +02:00
port100.c NFC: port100: fix use-after-free in port100_send_complete 2022-03-16 14:15:59 +01:00
trf7970a.c nfc: remove unneeded break 2020-10-20 10:36:41 -07:00