5c0cacdd35
[ Upstream commit 5a2d96623670155d94aca72c320c0ac27bdc6bd2 ]
The following WARNING message was given when rmmod cros_usbpd_notify:
Unexpected driver unregister!
WARNING: CPU: 0 PID: 253 at drivers/base/driver.c:270 driver_unregister+0x8a/0xb0
Modules linked in: cros_usbpd_notify(-)
CPU: 0 PID: 253 Comm: rmmod Not tainted 6.1.0-rc3 #24
...
Call Trace:
<TASK>
cros_usbpd_notify_exit+0x11/0x1e [cros_usbpd_notify]
__x64_sys_delete_module+0x3c7/0x570
? __ia32_sys_delete_module+0x570/0x570
? lock_is_held_type+0xe3/0x140
? syscall_enter_from_user_mode+0x17/0x50
? rcu_read_lock_sched_held+0xa0/0xd0
? syscall_enter_from_user_mode+0x1c/0x50
do_syscall_64+0x37/0x90
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f333fe9b1b7
The reason is that the cros_usbpd_notify_init() does not check the return
value of platform_driver_register(), and the cros_usbpd_notify can
install successfully even if platform_driver_register() failed.
Fix by checking the return value of platform_driver_register() and
unregister cros_usbpd_notify_plat_driver when it failed.
Fixes:
|
||
|---|---|---|
| .. | ||
| wilco_ec | ||
| chromeos_laptop.c | ||
| chromeos_pstore.c | ||
| chromeos_tbmc.c | ||
| cros_ec_chardev.c | ||
| cros_ec_debugfs.c | ||
| cros_ec_i2c.c | ||
| cros_ec_ishtp.c | ||
| cros_ec_lightbar.c | ||
| cros_ec_lpc_mec.c | ||
| cros_ec_lpc_mec.h | ||
| cros_ec_lpc.c | ||
| cros_ec_proto.c | ||
| cros_ec_rpmsg.c | ||
| cros_ec_sensorhub_ring.c | ||
| cros_ec_sensorhub_trace.h | ||
| cros_ec_sensorhub.c | ||
| cros_ec_spi.c | ||
| cros_ec_sysfs.c | ||
| cros_ec_trace.c | ||
| cros_ec_trace.h | ||
| cros_ec_typec.c | ||
| cros_ec_vbc.c | ||
| cros_ec.c | ||
| cros_ec.h | ||
| cros_kbd_led_backlight.c | ||
| cros_usbpd_logger.c | ||
| cros_usbpd_notify.c | ||
| Kconfig | ||
| Makefile | ||