android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/x86: dell-laptop: Drop superfluous exported function

Browse Source 
Since we've switched to the LED trigger for binding with HD-audio,
we can drop the exported function as well as the whole
linux/dell-led.h.

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai
2018-11-26 17:47:46 +01:00
parent b3802783d0
commit f783e128a6
2 changed files with 5 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/platform/x86/dell-laptop.c
View File

@ -29,7 +29,6 @@
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/i8042.h> #include <linux/i8042.h>
#include <linux/debugfs.h> #include <linux/debugfs.h>
#include <linux/dell-led.h>
#include <linux/seq_file.h> #include <linux/seq_file.h>
#include <acpi/video.h> #include <acpi/video.h>
#include "dell-rbtn.h" #include "dell-rbtn.h"
@ -2109,17 +2108,17 @@ static struct notifier_block dell_laptop_notifier = {
.notifier_call = dell_laptop_notifier_call, .notifier_call = dell_laptop_notifier_call,
}; };
int dell_micmute_led_set(int state) static int micmute_led_set(struct led_classdev *led_cdev,
enum led_brightness brightness)
{ {
struct calling_interface_buffer buffer; struct calling_interface_buffer buffer;
struct calling_interface_token *token; struct calling_interface_token *token;
int state = brightness != LED_OFF;
if (state == 0) if (state == 0)
token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE); token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE);
else if (state == 1)
token = dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE);
else else
return -EINVAL; token = dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE);
if (!token) if (!token)
return -ENODEV; return -ENODEV;
@ -2127,18 +2126,7 @@ int dell_micmute_led_set(int state)
dell_fill_request(&buffer, token->location, token->value, 0, 0); dell_fill_request(&buffer, token->location, token->value, 0, 0);
dell_send_request(&buffer, CLASS_TOKEN_WRITE, SELECT_TOKEN_STD); dell_send_request(&buffer, CLASS_TOKEN_WRITE, SELECT_TOKEN_STD);
return state; return 0;
}
EXPORT_SYMBOL_GPL(dell_micmute_led_set);
static int micmute_led_set(struct led_classdev *led_cdev,
enum led_brightness brightness)
{
int state = brightness != LED_OFF;
int err;
err = dell_micmute_led_set(state);
return err < 0 ? err : 0;
} }
static struct led_classdev micmute_led_cdev = { static struct led_classdev micmute_led_cdev = {

7
include/linux/dell-led.h
View File

@ -1,7 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef __DELL_LED_H__
#define __DELL_LED_H__
int dell_micmute_led_set(int on);
#endif