android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: aacraid: Fix udev inquiry race condition

Browse Source 
When udev requests for a devices inquiry string, it might create multiple
threads causing a race condition on the shared inquiry resource string.

Created a buffer with the string for each thread.

Cc: <stable@vger.kernel.org>
Fixes: 3bc8070fb7 ([SCSI] aacraid: SMC vendor identification)
Signed-off-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Raghava Aditya Renukunta 2017-12-26 20:34:22 -08:00 committed by Martin K. Petersen
parent ccd4a43035
commit f4e8708d31
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/scsi/aacraid/aachba.c
View File

@ -913,8 +913,16 @@ static void setinqstr(struct aac_dev *dev, void *data, int tindex)
memset(str, ' ', sizeof(*str)); memset(str, ' ', sizeof(*str));
if (sup_adap_info->adapter_type_text[0]) { if (sup_adap_info->adapter_type_text[0]) {
char *cp = sup_adap_info->adapter_type_text;
int c; int c;
char *cp;
char *cname = kmemdup(sup_adap_info->adapter_type_text,
sizeof(sup_adap_info->adapter_type_text),
GFP_ATOMIC);
if (!cname)
return;
cp = cname;
if ((cp[0] == 'A') && (cp[1] == 'O') && (cp[2] == 'C')) if ((cp[0] == 'A') && (cp[1] == 'O') && (cp[2] == 'C'))
inqstrcpy("SMC", str->vid); inqstrcpy("SMC", str->vid);
else { else {
@ -923,7 +931,7 @@ static void setinqstr(struct aac_dev *dev, void *data, int tindex)
++cp; ++cp;
c = *cp; c = *cp;
*cp = '\0'; *cp = '\0';
inqstrcpy(sup_adap_info->adapter_type_text, str->vid); inqstrcpy(cname, str->vid);
*cp = c; *cp = c;
while (*cp && *cp != ' ') while (*cp && *cp != ' ')
++cp; ++cp;
@ -937,8 +945,8 @@ static void setinqstr(struct aac_dev *dev, void *data, int tindex)
cp[sizeof(str->pid)] = '\0'; cp[sizeof(str->pid)] = '\0';
} }
inqstrcpy (cp, str->pid); inqstrcpy (cp, str->pid);
if (c)
cp[sizeof(str->pid)] = c; kfree(cname);
} else { } else {
struct aac_driver_ident *mp = aac_get_driver_ident(dev->cardtype); struct aac_driver_ident *mp = aac_get_driver_ident(dev->cardtype);