android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tools: gpio-hammer: Avoid potential overflow in main

Browse Source 
If '-o' was used more than 64 times in a single invocation of gpio-hammer,
this could lead to an overflow of the 'lines' array. This commit fixes
this by avoiding the overflow and giving a proper diagnostic back to the
user

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This commit is contained in:
Gabriel Ravier 2020-03-12 15:50:21 +01:00 committed by Bartosz Golaszewski
parent 525b0858ff
commit d1ee7e1f5c
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/gpio/gpio-hammer.c
View File

@ -135,7 +135,14 @@ int main(int argc, char **argv)
device_name = optarg; device_name = optarg;
break; break;
case 'o': case 'o':
lines[i] = strtoul(optarg, NULL, 10); /*
* Avoid overflow. Do not immediately error, we want to
* be able to accurately report on the amount of times
* '-o' was given to give an accurate error message
*/
if (i < GPIOHANDLES_MAX)
lines[i] = strtoul(optarg, NULL, 10);
i++; i++;
break; break;
case '?': case '?':
@ -143,6 +150,14 @@ int main(int argc, char **argv)
return -1; return -1;
} }
} }
if (i >= GPIOHANDLES_MAX) {
fprintf(stderr,
"Only %d occurences of '-o' are allowed, %d were found\n",
GPIOHANDLES_MAX, i + 1);
return -1;
}
nlines = i; nlines = i;
if (!device_name || !nlines) { if (!device_name || !nlines) {