android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: dwc3: pci: Fix return value check in dwc3_byt_enable_ulpi_refclock()

Browse Source 
In case of error, the function pcim_iomap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 7740d04d901d ("usb: dwc3: pci: Enable ULPI Refclk on platforms where the firmware does not")
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Wei Yongjun
2018-07-31 14:38:52 +00:00
committed by Felipe Balbi
parent dfe1a51d2a
commit b497fff6f5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/dwc3/dwc3-pci.c
View File

@ -85,8 +85,8 @@ static int dwc3_byt_enable_ulpi_refclock(struct pci_dev *pci)
u32 value; u32 value;
reg = pcim_iomap(pci, GP_RWBAR, 0); reg = pcim_iomap(pci, GP_RWBAR, 0);
if (IS_ERR(reg)) if (!reg)
return PTR_ERR(reg); return -ENOMEM;
value = readl(reg + GP_RWREG1); value = readl(reg + GP_RWREG1);
if (!(value & GP_RWREG1_ULPI_REFCLK_DISABLE)) if (!(value & GP_RWREG1_ULPI_REFCLK_DISABLE))