android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: sprd: Fix DMA buffer leak issue

Browse Source 
[ Upstream commit cd119fdc3ee1450fbf7f78862b5de44c42b6e47f ]

Release DMA buffer when _probe() returns failure to avoid memory leak.

Fixes: f4487db58e ("serial: sprd: Add DMA mode support")
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230725064053.235448-2-chunyan.zhang@unisoc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Chunyan Zhang 2023-07-25 14:40:53 +08:00 committed by Greg Kroah-Hartman
parent 6232bd4dca
commit 9a26aaea6c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/tty/serial/sprd_serial.c
View File

@ -367,7 +367,7 @@ static void sprd_rx_free_buf(struct sprd_uart_port *sp)
if (sp->rx_dma.virt) if (sp->rx_dma.virt)
dma_free_coherent(sp->port.dev, SPRD_UART_RX_SIZE, dma_free_coherent(sp->port.dev, SPRD_UART_RX_SIZE,
sp->rx_dma.virt, sp->rx_dma.phys_addr); sp->rx_dma.virt, sp->rx_dma.phys_addr);
sp->rx_dma.virt = NULL;
} }
static int sprd_rx_dma_config(struct uart_port *port, u32 burst) static int sprd_rx_dma_config(struct uart_port *port, u32 burst)
@ -1230,7 +1230,7 @@ static int sprd_probe(struct platform_device *pdev)
ret = uart_register_driver(&sprd_uart_driver); ret = uart_register_driver(&sprd_uart_driver);
if (ret < 0) { if (ret < 0) {
pr_err("Failed to register SPRD-UART driver\n"); pr_err("Failed to register SPRD-UART driver\n");
return ret; goto free_rx_buf;
} }
} }
@ -1249,6 +1249,7 @@ static int sprd_probe(struct platform_device *pdev)
sprd_port[index] = NULL; sprd_port[index] = NULL;
if (--sprd_ports_num == 0) if (--sprd_ports_num == 0)
uart_unregister_driver(&sprd_uart_driver); uart_unregister_driver(&sprd_uart_driver);
free_rx_buf:
sprd_rx_free_buf(sport); sprd_rx_free_buf(sport);
return ret; return ret;
} }