android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()

Browse Source 
The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d06310 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jingoo Han 2013-07-03 15:06:16 -07:00 committed by Linus Torvalds
parent a8e23d7b50
commit 7fcbf5fd5e
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/rtc/rtc-coh901331.c
View File

@ -154,10 +154,8 @@ static int __exit coh901331_remove(struct platform_device *pdev)
{ {
struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev); struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
if (rtap) { if (rtap)
clk_unprepare(rtap->clk); clk_unprepare(rtap->clk);
platform_set_drvdata(pdev, NULL);
}
return 0; return 0;
} }
@ -220,7 +218,6 @@ static int __init coh901331_probe(struct platform_device *pdev)
return 0; return 0;
out_no_rtc: out_no_rtc:
platform_set_drvdata(pdev, NULL);
clk_unprepare(rtap->clk); clk_unprepare(rtap->clk);
return ret; return ret;
} }