android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf annotate: Rename 'colors.code' to 'colors.jump_arrows'

Browse Source 
USe 'jump_arrows' config name instead of 'code' on 'colors' section.
'colors.code' config is only for jump arrows on assembly code listings
i.e.

    │     ┌──jmp    1333
    │     │  xchg   %ax,%ax
    │     │  mov    %r15,%r10
    │     └─→cmp    %r15,%r14

But this config name seems unfit.

 'jump_arrows' is more descriptive than 'code'.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1452240971-25418-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Taeung Song 2016-01-08 17:16:11 +09:00 committed by Arnaldo Carvalho de Melo
parent 3379e0c3ef
commit 78ce08dfbd
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/Documentation/perf-config.txt
View File

@ -62,7 +62,7 @@ Given a $HOME/.perfconfig like this:
medium = green, default medium = green, default
normal = lightgray, default normal = lightgray, default
selected = white, lightgray selected = white, lightgray
code = blue, default jump_arrows = blue, default
addr = magenta, default addr = magenta, default
root = white, blue root = white, blue

2
tools/perf/Documentation/perfconfig.example
View File

@ -5,7 +5,7 @@
medium = green, lightgray medium = green, lightgray
normal = black, lightgray normal = black, lightgray
selected = lightgray, magenta selected = lightgray, magenta
code = blue, lightgray jump_arrows = blue, lightgray
addr = magenta, lightgray addr = magenta, lightgray
[tui] [tui]

4
tools/perf/ui/browser.c
View File

@ -531,8 +531,8 @@ static struct ui_browser_colorset {
.bg = "yellow", .bg = "yellow",
}, },
{ {
.colorset = HE_COLORSET_CODE, .colorset = HE_COLORSET_JUMP_ARROWS,
.name = "code", .name = "jump_arrows",
.fg = "blue", .fg = "blue",
.bg = "default", .bg = "default",
}, },

2
tools/perf/ui/browser.h
View File

@ -7,7 +7,7 @@
#define HE_COLORSET_MEDIUM 51 #define HE_COLORSET_MEDIUM 51
#define HE_COLORSET_NORMAL 52 #define HE_COLORSET_NORMAL 52
#define HE_COLORSET_SELECTED 53 #define HE_COLORSET_SELECTED 53
#define HE_COLORSET_CODE 54 #define HE_COLORSET_JUMP_ARROWS 54
#define HE_COLORSET_ADDR 55 #define HE_COLORSET_ADDR 55
#define HE_COLORSET_ROOT 56 #define HE_COLORSET_ROOT 56

2
tools/perf/ui/browsers/annotate.c
View File

@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
to = (u64)btarget->idx; to = (u64)btarget->idx;
} }
ui_browser__set_color(browser, HE_COLORSET_CODE); ui_browser__set_color(browser, HE_COLORSET_JUMP_ARROWS);
__ui_browser__line_arrow(browser, pcnt_width + 2 + ab->addr_width, __ui_browser__line_arrow(browser, pcnt_width + 2 + ab->addr_width,
from, to); from, to);
} }