android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create

Browse Source 
[ Upstream commit c6077aa66fa230d12f37fef01161ef080d13b726 ]

[Why]
For subtraction, coverity reports integer overflow
warning message when variable type is uint32_t.

[How]
Change variable type to int32_t.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Tom Chung <chiahsuan.chung@amd.com>
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Hersen Wu 2024-04-26 11:58:11 -04:00 committed by Greg Kroah-Hartman
parent 9160830546
commit 74c5d8b057
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c
View File

@ -58,7 +58,7 @@ struct gpio_service *dal_gpio_service_create(
struct dc_context *ctx) struct dc_context *ctx)
{ {
struct gpio_service *service; struct gpio_service *service;
uint32_t index_of_id; int32_t index_of_id;
service = kzalloc(sizeof(struct gpio_service), GFP_KERNEL); service = kzalloc(sizeof(struct gpio_service), GFP_KERNEL);
@ -114,7 +114,7 @@ struct gpio_service *dal_gpio_service_create(
return service; return service;
failure_2: failure_2:
while (index_of_id) { while (index_of_id > 0) {
--index_of_id; --index_of_id;
kfree(service->busyness[index_of_id]); kfree(service->busyness[index_of_id]);
} }