android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regulator: palmas: Remove *rdev[PALMAS_NUM_REGS] from struct palmas_pmic

Browse Source 
This driver is using devm_regulator_register() so it is not necessary
to save *rdev for clean up. Actually the pmic->rdev[id] is not used now.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Axel Lin 2019-03-10 23:06:09 +08:00 committed by Mark Brown
parent 88f268a5bc
commit 74b060d684
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/regulator/palmas-regulator.c
View File

@ -991,9 +991,6 @@ static int palmas_ldo_registration(struct palmas_pmic *pmic,
return PTR_ERR(rdev); return PTR_ERR(rdev);
} }
/* Save regulator for cleanup */
pmic->rdev[id] = rdev;
/* Initialise sleep/init values from platform data */ /* Initialise sleep/init values from platform data */
if (pdata) { if (pdata) {
reg_init = pdata->reg_init[id]; reg_init = pdata->reg_init[id];
@ -1101,9 +1098,6 @@ static int tps65917_ldo_registration(struct palmas_pmic *pmic,
return PTR_ERR(rdev); return PTR_ERR(rdev);
} }
/* Save regulator for cleanup */
pmic->rdev[id] = rdev;
/* Initialise sleep/init values from platform data */ /* Initialise sleep/init values from platform data */
if (pdata) { if (pdata) {
reg_init = pdata->reg_init[id]; reg_init = pdata->reg_init[id];
@ -1288,9 +1282,6 @@ static int palmas_smps_registration(struct palmas_pmic *pmic,
pdev_name); pdev_name);
return PTR_ERR(rdev); return PTR_ERR(rdev);
} }
/* Save regulator for cleanup */
pmic->rdev[id] = rdev;
} }
return 0; return 0;
@ -1395,9 +1386,6 @@ static int tps65917_smps_registration(struct palmas_pmic *pmic,
pdev_name); pdev_name);
return PTR_ERR(rdev); return PTR_ERR(rdev);
} }
/* Save regulator for cleanup */
pmic->rdev[id] = rdev;
} }
return 0; return 0;

1
include/linux/mfd/palmas.h
View File

@ -553,7 +553,6 @@ struct palmas_pmic {
struct palmas *palmas; struct palmas *palmas;
struct device *dev; struct device *dev;
struct regulator_desc desc[PALMAS_NUM_REGS]; struct regulator_desc desc[PALMAS_NUM_REGS];
struct regulator_dev *rdev[PALMAS_NUM_REGS];
struct mutex mutex; struct mutex mutex;
int smps123; int smps123;