android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG_ON() Conversion in drivers/isdn

Browse Source 
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
This commit is contained in:
Eric Sesterhenn 2006-03-26 18:19:26 +02:00 committed by Adrian Bunk
parent 56ee48277f
commit 6dd44a7446
5 changed files with 9 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/isdn/hisax/hisax_fcpcipnp.c
View File

@ -387,8 +387,7 @@ static void hdlc_fill_fifo(struct fritz_bcs *bcs)
DBG(0x40, "hdlc_fill_fifo"); DBG(0x40, "hdlc_fill_fifo");
if (skb->len == 0) BUG_ON(skb->len == 0);
BUG();
bcs->ctrl.sr.cmd &= ~HDLC_CMD_XME; bcs->ctrl.sr.cmd &= ~HDLC_CMD_XME;
if (bcs->tx_skb->len > bcs->fifo_size) { if (bcs->tx_skb->len > bcs->fifo_size) {
@ -630,9 +629,7 @@ static void fritz_b_l2l1(struct hisax_if *ifc, int pr, void *arg)
switch (pr) { switch (pr) {
case PH_DATA | REQUEST: case PH_DATA | REQUEST:
if (bcs->tx_skb) BUG_ON(bcs->tx_skb);
BUG();
bcs->tx_skb = skb; bcs->tx_skb = skb;
DBG_SKB(1, skb); DBG_SKB(1, skb);
hdlc_fill_fifo(bcs); hdlc_fill_fifo(bcs);

9
drivers/isdn/hisax/hisax_isac.c
View File

@ -476,12 +476,10 @@ static void isac_fill_fifo(struct isac *isac)
unsigned char cmd; unsigned char cmd;
u_char *ptr; u_char *ptr;
if (!isac->tx_skb) BUG_ON(!isac->tx_skb);
BUG();
count = isac->tx_skb->len; count = isac->tx_skb->len;
if (count <= 0) BUG_ON(count <= 0);
BUG();
DBG(DBG_IRQ, "count %d", count); DBG(DBG_IRQ, "count %d", count);
@ -859,8 +857,7 @@ void isac_d_l2l1(struct hisax_if *hisax_d_if, int pr, void *arg)
dev_kfree_skb(skb); dev_kfree_skb(skb);
break; break;
} }
if (isac->tx_skb) BUG_ON(isac->tx_skb);
BUG();
isac->tx_skb = skb; isac->tx_skb = skb;
isac_fill_fifo(isac); isac_fill_fifo(isac);

4
drivers/isdn/hisax/st5481_b.c
View File

@ -356,9 +356,7 @@ void st5481_b_l2l1(struct hisax_if *ifc, int pr, void *arg)
switch (pr) { switch (pr) {
case PH_DATA | REQUEST: case PH_DATA | REQUEST:
if (bcs->b_out.tx_skb) BUG_ON(bcs->b_out.tx_skb);
BUG();
bcs->b_out.tx_skb = skb; bcs->b_out.tx_skb = skb;
break; break;
case PH_ACTIVATE | REQUEST: case PH_ACTIVATE | REQUEST:

4
drivers/isdn/hisax/st5481_d.c
View File

@ -596,9 +596,7 @@ void st5481_d_l2l1(struct hisax_if *hisax_d_if, int pr, void *arg)
break; break;
case PH_DATA | REQUEST: case PH_DATA | REQUEST:
DBG(2, "PH_DATA REQUEST len %d", skb->len); DBG(2, "PH_DATA REQUEST len %d", skb->len);
if (adapter->d_out.tx_skb) BUG_ON(adapter->d_out.tx_skb);
BUG();
adapter->d_out.tx_skb = skb; adapter->d_out.tx_skb = skb;
FsmEvent(&adapter->d_out.fsm, EV_DOUT_START_XMIT, NULL); FsmEvent(&adapter->d_out.fsm, EV_DOUT_START_XMIT, NULL);
break; break;

6
drivers/isdn/i4l/isdn_ppp.c
View File

@ -974,8 +974,7 @@ void isdn_ppp_receive(isdn_net_dev * net_dev, isdn_net_local * lp, struct sk_buf
int slot; int slot;
int proto; int proto;
if (net_dev->local->master) BUG_ON(net_dev->local->master); // we're called with the master device always
BUG(); // we're called with the master device always
slot = lp->ppp_slot; slot = lp->ppp_slot;
if (slot < 0 || slot >= ISDN_MAX_CHANNELS) { if (slot < 0 || slot >= ISDN_MAX_CHANNELS) {
@ -2527,8 +2526,7 @@ static struct sk_buff *isdn_ppp_decompress(struct sk_buff *skb,struct ippp_struc
printk(KERN_DEBUG "ippp: no decompressor defined!\n"); printk(KERN_DEBUG "ippp: no decompressor defined!\n");
return skb; return skb;
} }
if (!stat) // if we have a compressor, stat has been set as well BUG_ON(!stat); // if we have a compressor, stat has been set as well
BUG();
if((master && *proto == PPP_COMP) || (!master && *proto == PPP_COMPFRAG) ) { if((master && *proto == PPP_COMP) || (!master && *proto == PPP_COMPFRAG) ) {
// compressed packets are compressed by their protocol type // compressed packets are compressed by their protocol type