android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] drivers/video/s3fb.c: fix a use-before-check

Browse Source 
NULL checks should be before the first dereference.

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Ondrej Zajicek <santiago@crfreenet.org>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Adrian Bunk 2007-03-22 00:11:16 -08:00 committed by Linus Torvalds
parent fffda91e2e
commit 47ebea8351
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/video/s3fb.c
View File

@ -1000,11 +1000,12 @@ static int __devinit s3_pci_probe(struct pci_dev *dev, const struct pci_device_i
static void __devexit s3_pci_remove(struct pci_dev *dev) static void __devexit s3_pci_remove(struct pci_dev *dev)
{ {
struct fb_info *info = pci_get_drvdata(dev); struct fb_info *info = pci_get_drvdata(dev);
struct s3fb_info *par = info->par;
if (info) { if (info) {
#ifdef CONFIG_MTRR #ifdef CONFIG_MTRR
struct s3fb_info *par = info->par;
if (par->mtrr_reg >= 0) { if (par->mtrr_reg >= 0) {
mtrr_del(par->mtrr_reg, 0, 0); mtrr_del(par->mtrr_reg, 0, 0);
par->mtrr_reg = -1; par->mtrr_reg = -1;