android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

padata: use integer wrap around to prevent deadlock on seq_nr overflow

Browse Source 
commit 9a22b2812393d93d84358a760c347c21939029a6 upstream.

When submitting more than 2^32 padata objects to padata_do_serial, the
current sorting implementation incorrectly sorts padata objects with
overflowed seq_nr, causing them to be placed before existing objects in
the reorder list. This leads to a deadlock in the serialization process
as padata_find_next cannot match padata->seq_nr and pd->processed
because the padata instance with overflowed seq_nr will be selected
next.

To fix this, we use an unsigned integer wrap around to correctly sort
padata objects in scenarios with integer overflow.

Fixes: bfde23ce20 ("padata: unbind parallel jobs from specific CPUs")
Cc: <stable@vger.kernel.org>
Co-developed-by: Christian Gafert <christian.gafert@rohde-schwarz.com>
Signed-off-by: Christian Gafert <christian.gafert@rohde-schwarz.com>
Co-developed-by: Max Ferger <max.ferger@rohde-schwarz.com>
Signed-off-by: Max Ferger <max.ferger@rohde-schwarz.com>
Signed-off-by: Van Giang Nguyen <vangiang.nguyen@rohde-schwarz.com>
Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
VanGiang Nguyen 2024-08-09 06:21:42 +00:00 committed by Greg Kroah-Hartman
parent 7d0079d644
commit 46c4079460
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/padata.c
View File

@ -409,7 +409,8 @@ void padata_do_serial(struct padata_priv *padata)
/* Sort in ascending order of sequence number. */ /* Sort in ascending order of sequence number. */
list_for_each_prev(pos, &reorder->list) { list_for_each_prev(pos, &reorder->list) {
cur = list_entry(pos, struct padata_priv, list); cur = list_entry(pos, struct padata_priv, list);
if (cur->seq_nr < padata->seq_nr) /* Compare by difference to consider integer wrap around */
if ((signed int)(cur->seq_nr - padata->seq_nr) < 0)
break; break;
} }
list_add(&padata->list, pos); list_add(&padata->list, pos);