android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: es1688_lib: Deletion of an unnecessary check before the function call "release_and_free_resource"

Browse Source 
The release_and_free_resource() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Markus Elfring 2014-11-21 19:05:50 +01:00 committed by Takashi Iwai
parent d712eaf29d
commit 42d7721012
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sound/isa/es1688/es1688_lib.c
View File

@ -614,8 +614,7 @@ static int snd_es1688_free(struct snd_es1688 *chip)
{ {
if (chip->hardware != ES1688_HW_UNDEF) if (chip->hardware != ES1688_HW_UNDEF)
snd_es1688_init(chip, 0); snd_es1688_init(chip, 0);
if (chip->res_port) release_and_free_resource(chip->res_port);
release_and_free_resource(chip->res_port);
if (chip->irq >= 0) if (chip->irq >= 0)
free_irq(chip->irq, (void *) chip); free_irq(chip->irq, (void *) chip);
if (chip->dma8 >= 0) { if (chip->dma8 >= 0) {