android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V4L/DVB: ir-core: fix table resize during keymap init

Browse Source 
drivers/media/IR/ir-keytable.c would alloc a suitably sized keymap table
only to have it resized as it is populated with the initial keymap.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab 2010-05-18 02:06:06 -03:00
parent d46844300c
commit 42880cd438
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/IR/ir-keytable.c
View File

@ -78,6 +78,7 @@ static int ir_resize_table(struct ir_scancode_table *rc_tab)
* @rc_tab: the struct ir_scancode_table to set the keycode in * @rc_tab: the struct ir_scancode_table to set the keycode in
* @scancode: the scancode for the ir command * @scancode: the scancode for the ir command
* @keycode: the keycode for the ir command * @keycode: the keycode for the ir command
* @resize: whether the keytable may be shrunk
* @return: -EINVAL if the keycode could not be inserted, otherwise zero. * @return: -EINVAL if the keycode could not be inserted, otherwise zero.
* *
* This routine is used internally to manipulate the scancode->keycode table. * This routine is used internally to manipulate the scancode->keycode table.
@ -85,7 +86,8 @@ static int ir_resize_table(struct ir_scancode_table *rc_tab)
*/ */
static int ir_do_setkeycode(struct input_dev *dev, static int ir_do_setkeycode(struct input_dev *dev,
struct ir_scancode_table *rc_tab, struct ir_scancode_table *rc_tab,
unsigned scancode, unsigned keycode) unsigned scancode, unsigned keycode,
bool resize)
{ {
unsigned int i; unsigned int i;
int old_keycode = KEY_RESERVED; int old_keycode = KEY_RESERVED;
@ -129,7 +131,7 @@ static int ir_do_setkeycode(struct input_dev *dev,
if (old_keycode == KEY_RESERVED && keycode != KEY_RESERVED) { if (old_keycode == KEY_RESERVED && keycode != KEY_RESERVED) {
/* No previous mapping found, we might need to grow the table */ /* No previous mapping found, we might need to grow the table */
if (ir_resize_table(rc_tab)) if (resize && ir_resize_table(rc_tab))
return -ENOMEM; return -ENOMEM;
IR_dprintk(1, "#%d: New scan 0x%04x with key 0x%04x\n", IR_dprintk(1, "#%d: New scan 0x%04x with key 0x%04x\n",
@ -177,7 +179,7 @@ static int ir_setkeycode(struct input_dev *dev,
struct ir_scancode_table *rc_tab = &ir_dev->rc_tab; struct ir_scancode_table *rc_tab = &ir_dev->rc_tab;
spin_lock_irqsave(&rc_tab->lock, flags); spin_lock_irqsave(&rc_tab->lock, flags);
rc = ir_do_setkeycode(dev, rc_tab, scancode, keycode); rc = ir_do_setkeycode(dev, rc_tab, scancode, keycode, true);
spin_unlock_irqrestore(&rc_tab->lock, flags); spin_unlock_irqrestore(&rc_tab->lock, flags);
return rc; return rc;
} }
@ -204,7 +206,7 @@ static int ir_setkeytable(struct input_dev *dev,
spin_lock_irqsave(&rc_tab->lock, flags); spin_lock_irqsave(&rc_tab->lock, flags);
for (i = 0; i < from->size; i++) { for (i = 0; i < from->size; i++) {
rc = ir_do_setkeycode(dev, to, from->scan[i].scancode, rc = ir_do_setkeycode(dev, to, from->scan[i].scancode,
from->scan[i].keycode); from->scan[i].keycode, false);
if (rc) if (rc)
break; break;
} }