android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: vim2m: don't use curr_ctx->dev before checking

Browse Source 
It seems that it is possible that dev to be null, as there's
a warning printing:
	"Instance released before the end of transaction"

Solves this warning:
	drivers/media/platform/vim2m.c: drivers/media/platform/vim2m.c:525 device_work() warn: variable dereferenced before check 'curr_ctx' (see line 523)

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Mauro Carvalho Chehab 2019-02-07 12:28:19 -05:00
parent a442940534
commit 22f05d646d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/platform/vim2m.c
View File

@ -520,13 +520,14 @@ static void device_work(struct work_struct *w)
unsigned long flags;
curr_ctx = container_of(w, struct vim2m_ctx, work_run.work);
vim2m_dev = curr_ctx->dev;
if (NULL == curr_ctx) {
pr_err("Instance released before the end of transaction\n");
return;
}
vim2m_dev = curr_ctx->dev;
src_vb = v4l2_m2m_src_buf_remove(curr_ctx->fh.m2m_ctx);
dst_vb = v4l2_m2m_dst_buf_remove(curr_ctx->fh.m2m_ctx);