android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: atmel_mxt_ts - don't try to free unallocated kernel memory

Browse Source 
If the user attempts to update Atmel device with an invalid configuration
cfg file, error handling code is trying to free cfg file memory which is
not allocated yet hence results into kernel crash.

This patch fixes the order of memory free operations.

Signed-off-by: Sanjeev Chugh <sanjeev_chugh@mentor.com>
Fixes: a4891f105837 ("Input: atmel_mxt_ts - zero terminate config firmware file")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Sanjeev Chugh
2018-12-28 17:04:31 -08:00
committed by Dmitry Torokhov
parent d52266fc74
commit 1e3c336ad8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/input/touchscreen/atmel_mxt_ts.c
View File

@ -1585,10 +1585,10 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw)
/* T7 config may have changed */ /* T7 config may have changed */
mxt_init_t7_power_cfg(data); mxt_init_t7_power_cfg(data);
release_raw:
kfree(cfg.raw);
release_mem: release_mem:
kfree(cfg.mem); kfree(cfg.mem);
release_raw:
kfree(cfg.raw);
return ret; return ret;
} }