android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libata-core: auditting chk_status v check_status

Browse Source 
Did a complete audit of these and found we have another error case.

ata_bus_softreset calls ata_check_status which means that it tries to do
an ioread8 on the port blindly and check versus 0xFF for an error.

It should of course be using the ap->ops method for this via chk_status,
and this bug causes a wrog status call on the NS87415 at least.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Alan Cox
2007-10-23 16:50:02 +01:00
committed by Jeff Garzik
parent 2dcb407e61
commit 150981b030
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/ata/libata-core.c
View File

@ -3267,7 +3267,7 @@ static int ata_bus_softreset(struct ata_port *ap, unsigned int devmask,
* the bus shows 0xFF because the odd clown forgets the D7 * the bus shows 0xFF because the odd clown forgets the D7
* pulldown resistor. * pulldown resistor.
*/ */
if (ata_check_status(ap) == 0xFF) if (ata_chk_status(ap) == 0xFF)
return -ENODEV; return -ENODEV;
return ata_bus_post_reset(ap, devmask, deadline); return ata_bus_post_reset(ap, devmask, deadline);