android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/get_maintainer.pl: add --remove-duplicates

Browse Source 
Allow control over the elimination of duplicate email names and addresses

--remove-duplicates will use the first email name or address presented
--noremove-duplicates will emit all names and addresses

--remove-duplicates is enabled by default

For instance:

$ ./scripts/get_maintainer.pl -f drivers/char/tty_ioctl.c
Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox <alan@linux.intel.com>
Mike Frysinger <vapier@gentoo.org>
Alexey Dobriyan <adobriyan@gmail.com>
linux-kernel@vger.kernel.org

$ ./scripts/get_maintainer.pl -f --noremove-duplicates drivers/char/tty_ioctl.c
Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox <alan@redhat.com>
Alan Cox <alan@linux.intel.com>
Alan Cox <alan@lxorguk.ukuu.org.uk>
Mike Frysinger <vapier@gentoo.org>
Alexey Dobriyan <adobriyan@gmail.com>
linux-kernel@vger.kernel.org

Using --remove-duplicates could eliminate multiple maintainers that
share the same name but not the same email address.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2009-09-21 17:04:22 -07:00 committed by Linus Torvalds
parent 4249831613
commit 11ecf53c97
1 changed files with 57 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
scripts/get_maintainer.pl
View File

@ -30,6 +30,7 @@ my $email_git_max_maintainers = 5;
my $email_git_min_percent = 5; my $email_git_min_percent = 5;
my $email_git_since = "1-year-ago"; my $email_git_since = "1-year-ago";
my $email_git_blame = 0; my $email_git_blame = 0;
my $email_remove_duplicates = 1;
my $output_multiline = 1; my $output_multiline = 1;
my $output_separator = ", "; my $output_separator = ", ";
my $scm = 0; my $scm = 0;
@ -71,6 +72,7 @@ if (!GetOptions(
'git-min-percent=i' => \$email_git_min_percent, 'git-min-percent=i' => \$email_git_min_percent,
'git-since=s' => \$email_git_since, 'git-since=s' => \$email_git_since,
'git-blame!' => \$email_git_blame, 'git-blame!' => \$email_git_blame,
'remove-duplicates!' => \$email_remove_duplicates,
'm!' => \$email_maintainer, 'm!' => \$email_maintainer,
'n!' => \$email_usename, 'n!' => \$email_usename,
'l!' => \$email_list, 'l!' => \$email_list,
@ -158,32 +160,28 @@ close(MAINT);
my %mailmap; my %mailmap;
open(MAILMAP, "<${lk_path}.mailmap") || warn "$P: Can't open .mailmap\n"; if ($email_remove_duplicates) {
while (<MAILMAP>) { open(MAILMAP, "<${lk_path}.mailmap") || warn "$P: Can't open .mailmap\n";
my $line = $_; while (<MAILMAP>) {
my $line = $_;
next if ($line =~ m/^\s*#/); next if ($line =~ m/^\s*#/);
next if ($line =~ m/^\s*$/); next if ($line =~ m/^\s*$/);
my ($name, $address) = parse_email($line); my ($name, $address) = parse_email($line);
$line = format_email($name, $address); $line = format_email($name, $address);
next if ($line =~ m/^\s*$/); next if ($line =~ m/^\s*$/);
if (exists($mailmap{$name})) { if (exists($mailmap{$name})) {
my $obj = $mailmap{$name}; my $obj = $mailmap{$name};
push(@$obj, $address); push(@$obj, $address);
} else { } else {
my @arr = ($address); my @arr = ($address);
$mailmap{$name} = \@arr; $mailmap{$name} = \@arr;
} }
}
close(MAILMAP);
foreach my $name (sort {$mailmap{$a} <=> $mailmap{$b}} keys %mailmap) {
my $obj = $mailmap{$name};
foreach my $address (@$obj) {
} }
close(MAILMAP);
} }
## use the filenames on the command line or find the filenames in the patchfiles ## use the filenames on the command line or find the filenames in the patchfiles
@ -373,6 +371,7 @@ MAINTAINER field selection options:
--n => include name 'Full Name <addr\@domain.tld>' --n => include name 'Full Name <addr\@domain.tld>'
--l => include list(s) if any --l => include list(s) if any
--s => include subscriber only list(s) if any --s => include subscriber only list(s) if any
--remove-duplicates => minimize duplicate email names/addresses
--scm => print SCM tree(s) if any --scm => print SCM tree(s) if any
--status => print status if any --status => print status if any
--subsystem => print subsystem name if any --subsystem => print subsystem name if any
@ -389,7 +388,7 @@ Other options:
--help => show this help information --help => show this help information
Default options: Default options:
[--email --git --m --n --l --multiline --pattern-depth=0] [--email --git --m --n --l --multiline --pattern-depth=0 --remove-duplicates]
Notes: Notes:
Using "-f directory" may give unexpected results: Using "-f directory" may give unexpected results:
@ -438,12 +437,12 @@ sub parse_email {
my $name = ""; my $name = "";
my $address = ""; my $address = "";
if ($formatted_email =~ /^([^<]+)<(.*\@.*)>.*$/) { if ($formatted_email =~ /^([^<]+)<(.+\@.*)>.*$/) {
$name = $1; $name = $1;
$address = $2; $address = $2;
} elsif ($formatted_email =~ /^\s*<(.*\@.*)>.*$/) { } elsif ($formatted_email =~ /^\s*<(.+\@\S*)>.*$/) {
$address = $1; $address = $1;
} elsif ($formatted_email =~ /^\s*(.*\@.*)$/) { } elsif ($formatted_email =~ /^(.+\@\S*)$/) {
$address = $1; $address = $1;
} }
@ -542,14 +541,16 @@ sub add_categories {
} }
} }
sub email_address_inuse { my %email_hash_name;
my ($test_address) = @_; my %email_hash_address;
foreach my $line (@email_to) { sub email_inuse {
my ($name, $address) = parse_email($line); my ($name, $address) = @_;
return 1 if (($name eq "") && ($address eq ""));
return 1 if (($name ne "") && exists($email_hash_name{$name}));
return 1 if (($address ne "") && exists($email_hash_address{$address}));
return 1 if ($address eq $test_address);
}
return 0; return 0;
} }
@ -558,8 +559,12 @@ sub push_email_address {
my ($name, $address) = parse_email($line); my ($name, $address) = parse_email($line);
if (!email_address_inuse($address)) { if (!$email_remove_duplicates) {
push(@email_to, format_email($name, $address)); push(@email_to, format_email($name, $address));
} elsif (!email_inuse($name, $address)) {
push(@email_to, format_email($name, $address));
$email_hash_name{$name}++;
$email_hash_address{$address}++;
} }
} }
@ -600,6 +605,9 @@ sub mailmap {
my ($name, $address) = parse_email($line); my ($name, $address) = parse_email($line);
if (!exists($hash{$name})) { if (!exists($hash{$name})) {
$hash{$name} = $address; $hash{$name} = $address;
} elsif ($address ne $hash{$name}) {
$address = $hash{$name};
$line = format_email($name, $address);
} }
if (exists($mailmap{$name})) { if (exists($mailmap{$name})) {
my $obj = $mailmap{$name}; my $obj = $mailmap{$name};
@ -652,31 +660,23 @@ sub recent_git_signoffs {
$total_sign_offs = @lines; $total_sign_offs = @lines;
@lines = mailmap(@lines); if ($email_remove_duplicates) {
@lines = mailmap(@lines);
}
@lines = sort(@lines); @lines = sort(@lines);
# uniq -c
foreach my $line (@lines) {
$hash{$line}++;
}
# sort -rn
@lines = ();
foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
push(@lines,"$hash{$line} $line");
}
foreach my $line (@lines) { # uniq -c
if ($line =~ m/([0-9]+)\s+(.*)/) { $hash{$_}++ for @lines;
my $sign_offs = $1;
$line = $2; # sort -rn
$count++; foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
if ($sign_offs < $email_git_min_signatures || my $sign_offs = $hash{$line};
$count > $email_git_max_maintainers || $count++;
$sign_offs * 100 / $total_sign_offs < $email_git_min_percent) { last if ($sign_offs < $email_git_min_signatures ||
last; $count > $email_git_max_maintainers ||
} $sign_offs * 100 / $total_sign_offs < $email_git_min_percent);
push_email_address($line); push_email_address($line);
}
} }
} }
@ -743,7 +743,9 @@ sub git_assign_blame {
$total_sign_offs += @lines; $total_sign_offs += @lines;
@lines = mailmap(@lines); if ($email_remove_duplicates) {
@lines = mailmap(@lines);
}
$hash{$_}++ for @lines; $hash{$_}++ for @lines;
} }