android/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR and PTR_ERR

Browse Source 
Fix inconsistent IS_ERR and PTR_ERR in imx8m_ddrc_probe().
Detected using Coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
YueHaibing 2019-12-30 16:47:31 +08:00 committed by Chanwoo Choi
parent 28135762b8
commit 10800fec61
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/devfreq/imx8m-ddrc.c
View File

@ -395,15 +395,27 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
} }
priv->dram_core = devm_clk_get(dev, "core"); priv->dram_core = devm_clk_get(dev, "core");
if (IS_ERR(priv->dram_core)) {
ret = PTR_ERR(priv->dram_core);
dev_err(dev, "failed to fetch core clock: %d\n", ret);
return ret;
}
priv->dram_pll = devm_clk_get(dev, "pll"); priv->dram_pll = devm_clk_get(dev, "pll");
if (IS_ERR(priv->dram_pll)) {
ret = PTR_ERR(priv->dram_pll);
dev_err(dev, "failed to fetch pll clock: %d\n", ret);
return ret;
}
priv->dram_alt = devm_clk_get(dev, "alt"); priv->dram_alt = devm_clk_get(dev, "alt");
if (IS_ERR(priv->dram_alt)) {
ret = PTR_ERR(priv->dram_alt);
dev_err(dev, "failed to fetch alt clock: %d\n", ret);
return ret;
}
priv->dram_apb = devm_clk_get(dev, "apb"); priv->dram_apb = devm_clk_get(dev, "apb");
if (IS_ERR(priv->dram_core) || if (IS_ERR(priv->dram_apb)) {
IS_ERR(priv->dram_pll) || ret = PTR_ERR(priv->dram_apb);
IS_ERR(priv->dram_alt) || dev_err(dev, "failed to fetch apb clock: %d\n", ret);
IS_ERR(priv->dram_apb)) {
ret = PTR_ERR(priv->devfreq);
dev_err(dev, "failed to fetch clocks: %d\n", ret);
return ret; return ret;
} }