2006-01-03 03:04:38 +09:00
|
|
|
/*
|
|
|
|
* net/tipc/bearer.c: TIPC bearer code
|
2007-02-09 23:25:21 +09:00
|
|
|
*
|
2013-12-11 13:45:39 +09:00
|
|
|
* Copyright (c) 1996-2006, 2013, Ericsson AB
|
2011-01-08 03:00:11 +09:00
|
|
|
* Copyright (c) 2004-2006, 2010-2011, Wind River Systems
|
2006-01-03 03:04:38 +09:00
|
|
|
* All rights reserved.
|
|
|
|
*
|
2006-01-11 21:30:43 +09:00
|
|
|
* Redistribution and use in source and binary forms, with or without
|
2006-01-03 03:04:38 +09:00
|
|
|
* modification, are permitted provided that the following conditions are met:
|
|
|
|
*
|
2006-01-11 21:30:43 +09:00
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
|
|
|
* 3. Neither the names of the copyright holders nor the names of its
|
|
|
|
* contributors may be used to endorse or promote products derived from
|
|
|
|
* this software without specific prior written permission.
|
2006-01-03 03:04:38 +09:00
|
|
|
*
|
2006-01-11 21:30:43 +09:00
|
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
|
|
* Software Foundation.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
2006-01-03 03:04:38 +09:00
|
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "core.h"
|
|
|
|
#include "config.h"
|
|
|
|
#include "bearer.h"
|
|
|
|
#include "discover.h"
|
|
|
|
|
2013-04-17 15:18:28 +09:00
|
|
|
#define MAX_ADDR_STR 60
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2013-12-11 13:45:40 +09:00
|
|
|
static struct tipc_media * const media_info_array[] = {
|
2013-12-11 13:45:39 +09:00
|
|
|
ð_media_info,
|
|
|
|
#ifdef CONFIG_TIPC_MEDIA_IB
|
|
|
|
&ib_media_info,
|
|
|
|
#endif
|
|
|
|
NULL
|
|
|
|
};
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2011-01-08 03:00:11 +09:00
|
|
|
struct tipc_bearer tipc_bearers[MAX_BEARERS];
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2011-04-22 03:58:26 +09:00
|
|
|
static void bearer_disable(struct tipc_bearer *b_ptr);
|
|
|
|
|
2006-01-03 03:04:38 +09:00
|
|
|
/**
|
2011-10-19 00:34:29 +09:00
|
|
|
* tipc_media_find - locates specified media object by name
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2011-12-30 10:19:42 +09:00
|
|
|
struct tipc_media *tipc_media_find(const char *name)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
|
|
|
u32 i;
|
|
|
|
|
2013-12-11 13:45:40 +09:00
|
|
|
for (i = 0; media_info_array[i] != NULL; i++) {
|
|
|
|
if (!strcmp(media_info_array[i]->name, name))
|
2013-12-11 13:45:39 +09:00
|
|
|
break;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
2013-12-11 13:45:40 +09:00
|
|
|
return media_info_array[i];
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
2011-10-07 05:40:55 +09:00
|
|
|
/**
|
|
|
|
* media_find_id - locates specified media object by type identifier
|
|
|
|
*/
|
2011-12-30 10:19:42 +09:00
|
|
|
static struct tipc_media *media_find_id(u8 type)
|
2011-10-07 05:40:55 +09:00
|
|
|
{
|
|
|
|
u32 i;
|
|
|
|
|
2013-12-11 13:45:40 +09:00
|
|
|
for (i = 0; media_info_array[i] != NULL; i++) {
|
|
|
|
if (media_info_array[i]->type_id == type)
|
2013-12-11 13:45:39 +09:00
|
|
|
break;
|
2011-10-07 05:40:55 +09:00
|
|
|
}
|
2013-12-11 13:45:40 +09:00
|
|
|
return media_info_array[i];
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2006-01-18 08:38:21 +09:00
|
|
|
* tipc_media_addr_printf - record media address in print buffer
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2012-06-29 13:50:23 +09:00
|
|
|
void tipc_media_addr_printf(char *buf, int len, struct tipc_media_addr *a)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2011-10-08 00:31:49 +09:00
|
|
|
char addr_str[MAX_ADDR_STR];
|
2011-12-30 10:19:42 +09:00
|
|
|
struct tipc_media *m_ptr;
|
2012-06-29 13:50:23 +09:00
|
|
|
int ret;
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2011-10-08 04:19:11 +09:00
|
|
|
m_ptr = media_find_id(a->media_id);
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2011-10-08 00:31:49 +09:00
|
|
|
if (m_ptr && !m_ptr->addr2str(a, addr_str, sizeof(addr_str)))
|
2012-06-29 13:50:23 +09:00
|
|
|
ret = tipc_snprintf(buf, len, "%s(%s)", m_ptr->name, addr_str);
|
2011-10-08 00:31:49 +09:00
|
|
|
else {
|
|
|
|
u32 i;
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2012-06-29 13:50:23 +09:00
|
|
|
ret = tipc_snprintf(buf, len, "UNKNOWN(%u)", a->media_id);
|
2011-10-08 04:19:11 +09:00
|
|
|
for (i = 0; i < sizeof(a->value); i++)
|
2012-06-29 13:50:23 +09:00
|
|
|
ret += tipc_snprintf(buf - ret, len + ret,
|
|
|
|
"-%02x", a->value[i]);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2006-01-18 08:38:21 +09:00
|
|
|
* tipc_media_get_names - record names of registered media in buffer
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2006-01-18 08:38:21 +09:00
|
|
|
struct sk_buff *tipc_media_get_names(void)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
|
|
|
struct sk_buff *buf;
|
|
|
|
int i;
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
buf = tipc_cfg_reply_alloc(MAX_MEDIA * TLV_SPACE(TIPC_MAX_MEDIA_NAME));
|
2006-01-03 03:04:38 +09:00
|
|
|
if (!buf)
|
|
|
|
return NULL;
|
|
|
|
|
2013-12-11 13:45:40 +09:00
|
|
|
for (i = 0; media_info_array[i] != NULL; i++) {
|
2011-10-07 22:25:12 +09:00
|
|
|
tipc_cfg_append_tlv(buf, TIPC_TLV_MEDIA_NAME,
|
2013-12-11 13:45:40 +09:00
|
|
|
media_info_array[i]->name,
|
|
|
|
strlen(media_info_array[i]->name) + 1);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
return buf;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* bearer_name_validate - validate & (optionally) deconstruct bearer name
|
2012-07-10 19:55:09 +09:00
|
|
|
* @name: ptr to bearer name string
|
|
|
|
* @name_parts: ptr to area for bearer name components (or NULL if not needed)
|
2007-02-09 23:25:21 +09:00
|
|
|
*
|
2006-01-03 03:04:38 +09:00
|
|
|
* Returns 1 if bearer name is valid, otherwise 0.
|
|
|
|
*/
|
2007-02-09 23:25:21 +09:00
|
|
|
static int bearer_name_validate(const char *name,
|
2011-12-30 11:39:49 +09:00
|
|
|
struct tipc_bearer_names *name_parts)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
|
|
|
char name_copy[TIPC_MAX_BEARER_NAME];
|
|
|
|
char *media_name;
|
|
|
|
char *if_name;
|
|
|
|
u32 media_len;
|
|
|
|
u32 if_len;
|
|
|
|
|
|
|
|
/* copy bearer name & ensure length is OK */
|
|
|
|
name_copy[TIPC_MAX_BEARER_NAME - 1] = 0;
|
|
|
|
/* need above in case non-Posix strncpy() doesn't pad with nulls */
|
|
|
|
strncpy(name_copy, name, TIPC_MAX_BEARER_NAME);
|
|
|
|
if (name_copy[TIPC_MAX_BEARER_NAME - 1] != 0)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* ensure all component parts of bearer name are present */
|
|
|
|
media_name = name_copy;
|
2011-01-01 03:59:33 +09:00
|
|
|
if_name = strchr(media_name, ':');
|
|
|
|
if (if_name == NULL)
|
2006-01-03 03:04:38 +09:00
|
|
|
return 0;
|
|
|
|
*(if_name++) = 0;
|
|
|
|
media_len = if_name - media_name;
|
|
|
|
if_len = strlen(if_name) + 1;
|
|
|
|
|
|
|
|
/* validate component parts of bearer name */
|
2007-02-09 23:25:21 +09:00
|
|
|
if ((media_len <= 1) || (media_len > TIPC_MAX_MEDIA_NAME) ||
|
2012-08-16 21:09:08 +09:00
|
|
|
(if_len <= 1) || (if_len > TIPC_MAX_IF_NAME))
|
2006-01-03 03:04:38 +09:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* return bearer name components, if necessary */
|
|
|
|
if (name_parts) {
|
|
|
|
strcpy(name_parts->media_name, media_name);
|
|
|
|
strcpy(name_parts->if_name, if_name);
|
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2011-10-19 00:34:29 +09:00
|
|
|
* tipc_bearer_find - locates bearer object with matching bearer name
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2011-10-19 00:34:29 +09:00
|
|
|
struct tipc_bearer *tipc_bearer_find(const char *name)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2011-01-08 03:00:11 +09:00
|
|
|
struct tipc_bearer *b_ptr;
|
2006-01-03 03:04:38 +09:00
|
|
|
u32 i;
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
for (i = 0, b_ptr = tipc_bearers; i < MAX_BEARERS; i++, b_ptr++) {
|
2011-01-08 03:00:11 +09:00
|
|
|
if (b_ptr->active && (!strcmp(b_ptr->name, name)))
|
2006-01-03 03:04:38 +09:00
|
|
|
return b_ptr;
|
|
|
|
}
|
2006-03-21 15:36:47 +09:00
|
|
|
return NULL;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2006-01-18 08:38:21 +09:00
|
|
|
* tipc_bearer_find_interface - locates bearer object with matching interface name
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2011-01-08 03:00:11 +09:00
|
|
|
struct tipc_bearer *tipc_bearer_find_interface(const char *if_name)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2011-01-08 03:00:11 +09:00
|
|
|
struct tipc_bearer *b_ptr;
|
2006-01-03 03:04:38 +09:00
|
|
|
char *b_if_name;
|
|
|
|
u32 i;
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
for (i = 0, b_ptr = tipc_bearers; i < MAX_BEARERS; i++, b_ptr++) {
|
2006-01-03 03:04:38 +09:00
|
|
|
if (!b_ptr->active)
|
|
|
|
continue;
|
2011-01-08 03:00:11 +09:00
|
|
|
b_if_name = strchr(b_ptr->name, ':') + 1;
|
2006-01-03 03:04:38 +09:00
|
|
|
if (!strcmp(b_if_name, if_name))
|
|
|
|
return b_ptr;
|
|
|
|
}
|
2006-03-21 15:36:47 +09:00
|
|
|
return NULL;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2006-01-18 08:38:21 +09:00
|
|
|
* tipc_bearer_get_names - record names of bearers in buffer
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2006-01-18 08:38:21 +09:00
|
|
|
struct sk_buff *tipc_bearer_get_names(void)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
|
|
|
struct sk_buff *buf;
|
2013-12-11 13:45:40 +09:00
|
|
|
struct tipc_bearer *b;
|
2006-01-03 03:04:38 +09:00
|
|
|
int i, j;
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
buf = tipc_cfg_reply_alloc(MAX_BEARERS * TLV_SPACE(TIPC_MAX_BEARER_NAME));
|
2006-01-03 03:04:38 +09:00
|
|
|
if (!buf)
|
|
|
|
return NULL;
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
read_lock_bh(&tipc_net_lock);
|
2013-12-11 13:45:40 +09:00
|
|
|
for (i = 0; media_info_array[i] != NULL; i++) {
|
2006-01-03 03:04:38 +09:00
|
|
|
for (j = 0; j < MAX_BEARERS; j++) {
|
2013-12-11 13:45:40 +09:00
|
|
|
b = &tipc_bearers[j];
|
|
|
|
if (b->active && (b->media == media_info_array[i])) {
|
2007-02-09 23:25:21 +09:00
|
|
|
tipc_cfg_append_tlv(buf, TIPC_TLV_BEARER_NAME,
|
2013-12-11 13:45:40 +09:00
|
|
|
b->name,
|
|
|
|
strlen(b->name) + 1);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2006-01-18 08:38:21 +09:00
|
|
|
read_unlock_bh(&tipc_net_lock);
|
2006-01-03 03:04:38 +09:00
|
|
|
return buf;
|
|
|
|
}
|
|
|
|
|
2011-01-08 03:00:11 +09:00
|
|
|
void tipc_bearer_add_dest(struct tipc_bearer *b_ptr, u32 dest)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2006-01-18 08:38:21 +09:00
|
|
|
tipc_nmap_add(&b_ptr->nodes, dest);
|
|
|
|
tipc_bcbearer_sort();
|
2011-04-22 09:05:25 +09:00
|
|
|
tipc_disc_add_dest(b_ptr->link_req);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
2011-01-08 03:00:11 +09:00
|
|
|
void tipc_bearer_remove_dest(struct tipc_bearer *b_ptr, u32 dest)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2006-01-18 08:38:21 +09:00
|
|
|
tipc_nmap_remove(&b_ptr->nodes, dest);
|
|
|
|
tipc_bcbearer_sort();
|
2011-04-22 09:05:25 +09:00
|
|
|
tipc_disc_remove_dest(b_ptr->link_req);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* tipc_enable_bearer - enable bearer with the given name
|
2007-02-09 23:25:21 +09:00
|
|
|
*/
|
2011-03-01 04:56:15 +09:00
|
|
|
int tipc_enable_bearer(const char *name, u32 disc_domain, u32 priority)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2011-01-08 03:00:11 +09:00
|
|
|
struct tipc_bearer *b_ptr;
|
2011-12-30 10:19:42 +09:00
|
|
|
struct tipc_media *m_ptr;
|
2011-12-30 11:39:49 +09:00
|
|
|
struct tipc_bearer_names b_names;
|
2006-01-03 03:04:38 +09:00
|
|
|
char addr_string[16];
|
|
|
|
u32 bearer_id;
|
|
|
|
u32 with_this_prio;
|
|
|
|
u32 i;
|
|
|
|
int res = -EINVAL;
|
|
|
|
|
2011-11-09 03:48:28 +09:00
|
|
|
if (!tipc_own_addr) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, not supported in standalone mode\n",
|
|
|
|
name);
|
2006-01-03 03:04:38 +09:00
|
|
|
return -ENOPROTOOPT;
|
2006-06-26 15:52:17 +09:00
|
|
|
}
|
2011-12-30 11:39:49 +09:00
|
|
|
if (!bearer_name_validate(name, &b_names)) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, illegal name\n", name);
|
2006-01-14 06:22:22 +09:00
|
|
|
return -EINVAL;
|
2006-06-26 15:52:17 +09:00
|
|
|
}
|
2011-04-21 06:24:07 +09:00
|
|
|
if (tipc_addr_domain_valid(disc_domain) &&
|
|
|
|
(disc_domain != tipc_own_addr)) {
|
|
|
|
if (tipc_in_scope(disc_domain, tipc_own_addr)) {
|
|
|
|
disc_domain = tipc_own_addr & TIPC_CLUSTER_MASK;
|
|
|
|
res = 0; /* accept any node in own cluster */
|
2012-04-18 07:02:01 +09:00
|
|
|
} else if (in_own_cluster_exact(disc_domain))
|
2011-04-21 06:24:07 +09:00
|
|
|
res = 0; /* accept specified node in own cluster */
|
|
|
|
}
|
|
|
|
if (res) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, illegal discovery domain\n",
|
|
|
|
name);
|
2006-06-26 15:52:17 +09:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
2011-11-04 02:15:10 +09:00
|
|
|
if ((priority > TIPC_MAX_LINK_PRI) &&
|
2006-06-26 15:52:17 +09:00
|
|
|
(priority != TIPC_MEDIA_LINK_PRI)) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, illegal priority\n", name);
|
2006-01-03 03:04:38 +09:00
|
|
|
return -EINVAL;
|
2006-06-26 15:52:17 +09:00
|
|
|
}
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
write_lock_bh(&tipc_net_lock);
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2011-12-30 11:39:49 +09:00
|
|
|
m_ptr = tipc_media_find(b_names.media_name);
|
2006-01-03 03:04:38 +09:00
|
|
|
if (!m_ptr) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, media <%s> not registered\n",
|
|
|
|
name, b_names.media_name);
|
2011-04-22 03:58:26 +09:00
|
|
|
goto exit;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
2006-01-14 06:22:22 +09:00
|
|
|
|
|
|
|
if (priority == TIPC_MEDIA_LINK_PRI)
|
2006-01-03 03:04:38 +09:00
|
|
|
priority = m_ptr->priority;
|
|
|
|
|
|
|
|
restart:
|
|
|
|
bearer_id = MAX_BEARERS;
|
|
|
|
with_this_prio = 1;
|
|
|
|
for (i = MAX_BEARERS; i-- != 0; ) {
|
2006-01-18 08:38:21 +09:00
|
|
|
if (!tipc_bearers[i].active) {
|
2006-01-03 03:04:38 +09:00
|
|
|
bearer_id = i;
|
|
|
|
continue;
|
|
|
|
}
|
2011-01-08 03:00:11 +09:00
|
|
|
if (!strcmp(name, tipc_bearers[i].name)) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, already enabled\n",
|
|
|
|
name);
|
2011-04-22 03:58:26 +09:00
|
|
|
goto exit;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
2006-01-18 08:38:21 +09:00
|
|
|
if ((tipc_bearers[i].priority == priority) &&
|
2006-01-03 03:04:38 +09:00
|
|
|
(++with_this_prio > 2)) {
|
|
|
|
if (priority-- == 0) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, duplicate priority\n",
|
|
|
|
name);
|
2011-04-22 03:58:26 +09:00
|
|
|
goto exit;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> priority adjustment required %u->%u\n",
|
|
|
|
name, priority + 1, priority);
|
2006-01-03 03:04:38 +09:00
|
|
|
goto restart;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (bearer_id >= MAX_BEARERS) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, bearer limit reached (%u)\n",
|
|
|
|
name, MAX_BEARERS);
|
2011-04-22 03:58:26 +09:00
|
|
|
goto exit;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
b_ptr = &tipc_bearers[bearer_id];
|
2011-01-08 03:00:11 +09:00
|
|
|
strcpy(b_ptr->name, name);
|
2013-10-18 14:23:17 +09:00
|
|
|
res = m_ptr->enable_media(b_ptr);
|
2006-01-03 03:04:38 +09:00
|
|
|
if (res) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, enable failure (%d)\n",
|
|
|
|
name, -res);
|
2011-04-22 03:58:26 +09:00
|
|
|
goto exit;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
b_ptr->identity = bearer_id;
|
|
|
|
b_ptr->media = m_ptr;
|
2011-10-19 00:34:29 +09:00
|
|
|
b_ptr->tolerance = m_ptr->tolerance;
|
|
|
|
b_ptr->window = m_ptr->window;
|
2006-01-03 03:04:38 +09:00
|
|
|
b_ptr->net_plane = bearer_id + 'A';
|
|
|
|
b_ptr->active = 1;
|
|
|
|
b_ptr->priority = priority;
|
|
|
|
INIT_LIST_HEAD(&b_ptr->links);
|
2011-01-08 03:00:11 +09:00
|
|
|
spin_lock_init(&b_ptr->lock);
|
2011-04-22 03:58:26 +09:00
|
|
|
|
2013-04-17 15:18:26 +09:00
|
|
|
res = tipc_disc_create(b_ptr, &b_ptr->bcast_addr, disc_domain);
|
2011-04-22 03:58:26 +09:00
|
|
|
if (res) {
|
|
|
|
bearer_disable(b_ptr);
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Bearer <%s> rejected, discovery object creation failed\n",
|
|
|
|
name);
|
2011-04-22 03:58:26 +09:00
|
|
|
goto exit;
|
|
|
|
}
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_info("Enabled bearer <%s>, discovery domain %s, priority %u\n",
|
|
|
|
name,
|
|
|
|
tipc_addr_string_fill(addr_string, disc_domain), priority);
|
2011-04-22 03:58:26 +09:00
|
|
|
exit:
|
2006-01-18 08:38:21 +09:00
|
|
|
write_unlock_bh(&tipc_net_lock);
|
2006-01-03 03:04:38 +09:00
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
tipc: remove interface state mirroring in bearer
struct 'tipc_bearer' is a generic representation of the underlying
media type, and exists in a one-to-one relationship to each interface
TIPC is using. The struct contains a 'blocked' flag that mirrors the
operational and execution state of the represented interface, and is
updated through notification calls from the latter. The users of
tipc_bearer are checking this flag before each attempt to send a
packet via the interface.
This state mirroring serves no purpose in the current code base. TIPC
links will not discover a media failure any faster through this
mechanism, and in reality the flag only adds overhead at packet
sending and reception.
Furthermore, the fact that the flag needs to be protected by a spinlock
aggregated into tipc_bearer has turned out to cause a serious and
completely unnecessary deadlock problem.
CPU0 CPU1
---- ----
Time 0: bearer_disable() link_timeout()
Time 1: spin_lock_bh(&b_ptr->lock) tipc_link_push_queue()
Time 2: tipc_link_delete() tipc_bearer_blocked(b_ptr)
Time 3: k_cancel_timer(&req->timer) spin_lock_bh(&b_ptr->lock)
Time 4: del_timer_sync(&req->timer)
I.e., del_timer_sync() on CPU0 never returns, because the timer handler
on CPU1 is waiting for the bearer lock.
We eliminate the 'blocked' flag from struct tipc_bearer, along with all
tests on this flag. This not only resolves the deadlock, but also
simplifies and speeds up the data path execution of TIPC. It also fits
well into our ongoing effort to make the locking policy simpler and
more manageable.
An effect of this change is that we can get rid of functions such as
tipc_bearer_blocked(), tipc_continue() and tipc_block_bearer().
We replace the latter with a new function, tipc_reset_bearer(), which
resets all links associated to the bearer immediately after an
interface goes down.
A user might notice one slight change in link behaviour after this
change. When an interface goes down, (e.g. through a NETDEV_DOWN
event) all attached links will be reset immediately, instead of
leaving it to each link to detect the failure through a timer-driven
mechanism. We consider this an improvement, and see no obvious risks
with the new behavior.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Paul Gortmaker <Paul.Gortmaker@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-12-07 00:08:00 +09:00
|
|
|
* tipc_reset_bearer - Reset all links established over this bearer
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
tipc: remove interface state mirroring in bearer
struct 'tipc_bearer' is a generic representation of the underlying
media type, and exists in a one-to-one relationship to each interface
TIPC is using. The struct contains a 'blocked' flag that mirrors the
operational and execution state of the represented interface, and is
updated through notification calls from the latter. The users of
tipc_bearer are checking this flag before each attempt to send a
packet via the interface.
This state mirroring serves no purpose in the current code base. TIPC
links will not discover a media failure any faster through this
mechanism, and in reality the flag only adds overhead at packet
sending and reception.
Furthermore, the fact that the flag needs to be protected by a spinlock
aggregated into tipc_bearer has turned out to cause a serious and
completely unnecessary deadlock problem.
CPU0 CPU1
---- ----
Time 0: bearer_disable() link_timeout()
Time 1: spin_lock_bh(&b_ptr->lock) tipc_link_push_queue()
Time 2: tipc_link_delete() tipc_bearer_blocked(b_ptr)
Time 3: k_cancel_timer(&req->timer) spin_lock_bh(&b_ptr->lock)
Time 4: del_timer_sync(&req->timer)
I.e., del_timer_sync() on CPU0 never returns, because the timer handler
on CPU1 is waiting for the bearer lock.
We eliminate the 'blocked' flag from struct tipc_bearer, along with all
tests on this flag. This not only resolves the deadlock, but also
simplifies and speeds up the data path execution of TIPC. It also fits
well into our ongoing effort to make the locking policy simpler and
more manageable.
An effect of this change is that we can get rid of functions such as
tipc_bearer_blocked(), tipc_continue() and tipc_block_bearer().
We replace the latter with a new function, tipc_reset_bearer(), which
resets all links associated to the bearer immediately after an
interface goes down.
A user might notice one slight change in link behaviour after this
change. When an interface goes down, (e.g. through a NETDEV_DOWN
event) all attached links will be reset immediately, instead of
leaving it to each link to detect the failure through a timer-driven
mechanism. We consider this an improvement, and see no obvious risks
with the new behavior.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Paul Gortmaker <Paul.Gortmaker@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-12-07 00:08:00 +09:00
|
|
|
int tipc_reset_bearer(struct tipc_bearer *b_ptr)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2011-12-30 10:58:42 +09:00
|
|
|
struct tipc_link *l_ptr;
|
|
|
|
struct tipc_link *temp_l_ptr;
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
read_lock_bh(&tipc_net_lock);
|
tipc: remove interface state mirroring in bearer
struct 'tipc_bearer' is a generic representation of the underlying
media type, and exists in a one-to-one relationship to each interface
TIPC is using. The struct contains a 'blocked' flag that mirrors the
operational and execution state of the represented interface, and is
updated through notification calls from the latter. The users of
tipc_bearer are checking this flag before each attempt to send a
packet via the interface.
This state mirroring serves no purpose in the current code base. TIPC
links will not discover a media failure any faster through this
mechanism, and in reality the flag only adds overhead at packet
sending and reception.
Furthermore, the fact that the flag needs to be protected by a spinlock
aggregated into tipc_bearer has turned out to cause a serious and
completely unnecessary deadlock problem.
CPU0 CPU1
---- ----
Time 0: bearer_disable() link_timeout()
Time 1: spin_lock_bh(&b_ptr->lock) tipc_link_push_queue()
Time 2: tipc_link_delete() tipc_bearer_blocked(b_ptr)
Time 3: k_cancel_timer(&req->timer) spin_lock_bh(&b_ptr->lock)
Time 4: del_timer_sync(&req->timer)
I.e., del_timer_sync() on CPU0 never returns, because the timer handler
on CPU1 is waiting for the bearer lock.
We eliminate the 'blocked' flag from struct tipc_bearer, along with all
tests on this flag. This not only resolves the deadlock, but also
simplifies and speeds up the data path execution of TIPC. It also fits
well into our ongoing effort to make the locking policy simpler and
more manageable.
An effect of this change is that we can get rid of functions such as
tipc_bearer_blocked(), tipc_continue() and tipc_block_bearer().
We replace the latter with a new function, tipc_reset_bearer(), which
resets all links associated to the bearer immediately after an
interface goes down.
A user might notice one slight change in link behaviour after this
change. When an interface goes down, (e.g. through a NETDEV_DOWN
event) all attached links will be reset immediately, instead of
leaving it to each link to detect the failure through a timer-driven
mechanism. We consider this an improvement, and see no obvious risks
with the new behavior.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Paul Gortmaker <Paul.Gortmaker@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-12-07 00:08:00 +09:00
|
|
|
pr_info("Resetting bearer <%s>\n", b_ptr->name);
|
2011-01-08 03:00:11 +09:00
|
|
|
spin_lock_bh(&b_ptr->lock);
|
2006-01-03 03:04:38 +09:00
|
|
|
list_for_each_entry_safe(l_ptr, temp_l_ptr, &b_ptr->links, link_list) {
|
2008-09-03 15:38:32 +09:00
|
|
|
struct tipc_node *n_ptr = l_ptr->owner;
|
2006-01-03 03:04:38 +09:00
|
|
|
|
|
|
|
spin_lock_bh(&n_ptr->lock);
|
2006-01-18 08:38:21 +09:00
|
|
|
tipc_link_reset(l_ptr);
|
2006-01-03 03:04:38 +09:00
|
|
|
spin_unlock_bh(&n_ptr->lock);
|
|
|
|
}
|
2011-01-08 03:00:11 +09:00
|
|
|
spin_unlock_bh(&b_ptr->lock);
|
2006-01-18 08:38:21 +09:00
|
|
|
read_unlock_bh(&tipc_net_lock);
|
2008-07-15 14:44:01 +09:00
|
|
|
return 0;
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2012-05-01 04:29:02 +09:00
|
|
|
* bearer_disable
|
2007-02-09 23:25:21 +09:00
|
|
|
*
|
2006-01-18 08:38:21 +09:00
|
|
|
* Note: This routine assumes caller holds tipc_net_lock.
|
2006-01-03 03:04:38 +09:00
|
|
|
*/
|
2011-01-08 03:00:11 +09:00
|
|
|
static void bearer_disable(struct tipc_bearer *b_ptr)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
2011-12-30 10:58:42 +09:00
|
|
|
struct tipc_link *l_ptr;
|
|
|
|
struct tipc_link *temp_l_ptr;
|
tipc: avoid possible deadlock while enable and disable bearer
We met lockdep warning when enable and disable the bearer for commands such as:
tipc-config -netid=1234 -addr=1.1.3 -be=eth:eth0
tipc-config -netid=1234 -addr=1.1.3 -bd=eth:eth0
---------------------------------------------------
[ 327.693595] ======================================================
[ 327.693994] [ INFO: possible circular locking dependency detected ]
[ 327.694519] 3.11.0-rc3-wwd-default #4 Tainted: G O
[ 327.694882] -------------------------------------------------------
[ 327.695385] tipc-config/5825 is trying to acquire lock:
[ 327.695754] (((timer))#2){+.-...}, at: [<ffffffff8105be80>] del_timer_sync+0x0/0xd0
[ 327.696018]
[ 327.696018] but task is already holding lock:
[ 327.696018] (&(&b_ptr->lock)->rlock){+.-...}, at: [<ffffffffa02be58d>] bearer_disable+ 0xdd/0x120 [tipc]
[ 327.696018]
[ 327.696018] which lock already depends on the new lock.
[ 327.696018]
[ 327.696018]
[ 327.696018] the existing dependency chain (in reverse order) is:
[ 327.696018]
[ 327.696018] -> #1 (&(&b_ptr->lock)->rlock){+.-...}:
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff814d65b1>] _raw_spin_lock_bh+0x41/0x80
[ 327.696018] [<ffffffffa02c5d48>] disc_timeout+0x18/0xd0 [tipc]
[ 327.696018] [<ffffffff8105b92a>] call_timer_fn+0xda/0x1e0
[ 327.696018] [<ffffffff8105bcd7>] run_timer_softirq+0x2a7/0x2d0
[ 327.696018] [<ffffffff8105379a>] __do_softirq+0x16a/0x2e0
[ 327.696018] [<ffffffff81053a35>] irq_exit+0xd5/0xe0
[ 327.696018] [<ffffffff81033005>] smp_apic_timer_interrupt+0x45/0x60
[ 327.696018] [<ffffffff814df4af>] apic_timer_interrupt+0x6f/0x80
[ 327.696018] [<ffffffff8100b70e>] arch_cpu_idle+0x1e/0x30
[ 327.696018] [<ffffffff810a039d>] cpu_idle_loop+0x1fd/0x280
[ 327.696018] [<ffffffff810a043e>] cpu_startup_entry+0x1e/0x20
[ 327.696018] [<ffffffff81031589>] start_secondary+0x89/0x90
[ 327.696018]
[ 327.696018] -> #0 (((timer))#2){+.-...}:
[ 327.696018] [<ffffffff810b33fe>] check_prev_add+0x43e/0x4b0
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff8105bebd>] del_timer_sync+0x3d/0xd0
[ 327.696018] [<ffffffffa02c5855>] tipc_disc_delete+0x15/0x30 [tipc]
[ 327.696018] [<ffffffffa02be59f>] bearer_disable+0xef/0x120 [tipc]
[ 327.696018] [<ffffffffa02be74f>] tipc_disable_bearer+0x2f/0x60 [tipc]
[ 327.696018] [<ffffffffa02bfb32>] tipc_cfg_do_cmd+0x2e2/0x550 [tipc]
[ 327.696018] [<ffffffffa02c8c79>] handle_cmd+0x49/0xe0 [tipc]
[ 327.696018] [<ffffffff8143e898>] genl_family_rcv_msg+0x268/0x340
[ 327.696018] [<ffffffff8143ed30>] genl_rcv_msg+0x70/0xd0
[ 327.696018] [<ffffffff8143d4c9>] netlink_rcv_skb+0x89/0xb0
[ 327.696018] [<ffffffff8143e617>] genl_rcv+0x27/0x40
[ 327.696018] [<ffffffff8143d21e>] netlink_unicast+0x15e/0x1b0
[ 327.696018] [<ffffffff8143ddcf>] netlink_sendmsg+0x22f/0x400
[ 327.696018] [<ffffffff813f7836>] __sock_sendmsg+0x66/0x80
[ 327.696018] [<ffffffff813f7957>] sock_aio_write+0x107/0x120
[ 327.696018] [<ffffffff8117f76d>] do_sync_write+0x7d/0xc0
[ 327.696018] [<ffffffff8117fc56>] vfs_write+0x186/0x190
[ 327.696018] [<ffffffff811803e0>] SyS_write+0x60/0xb0
[ 327.696018] [<ffffffff814de852>] system_call_fastpath+0x16/0x1b
[ 327.696018]
[ 327.696018] other info that might help us debug this:
[ 327.696018]
[ 327.696018] Possible unsafe locking scenario:
[ 327.696018]
[ 327.696018] CPU0 CPU1
[ 327.696018] ---- ----
[ 327.696018] lock(&(&b_ptr->lock)->rlock);
[ 327.696018] lock(((timer))#2);
[ 327.696018] lock(&(&b_ptr->lock)->rlock);
[ 327.696018] lock(((timer))#2);
[ 327.696018]
[ 327.696018] *** DEADLOCK ***
[ 327.696018]
[ 327.696018] 5 locks held by tipc-config/5825:
[ 327.696018] #0: (cb_lock){++++++}, at: [<ffffffff8143e608>] genl_rcv+0x18/0x40
[ 327.696018] #1: (genl_mutex){+.+.+.}, at: [<ffffffff8143ed66>] genl_rcv_msg+0xa6/0xd0
[ 327.696018] #2: (config_mutex){+.+.+.}, at: [<ffffffffa02bf889>] tipc_cfg_do_cmd+0x39/ 0x550 [tipc]
[ 327.696018] #3: (tipc_net_lock){++.-..}, at: [<ffffffffa02be738>] tipc_disable_bearer+ 0x18/0x60 [tipc]
[ 327.696018] #4: (&(&b_ptr->lock)->rlock){+.-...}, at: [<ffffffffa02be58d>] bearer_disable+0xdd/0x120 [tipc]
[ 327.696018]
[ 327.696018] stack backtrace:
[ 327.696018] CPU: 2 PID: 5825 Comm: tipc-config Tainted: G O 3.11.0-rc3-wwd- default #4
[ 327.696018] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 327.696018] 00000000ffffffff ffff880037fa77a8 ffffffff814d03dd 0000000000000000
[ 327.696018] ffff880037fa7808 ffff880037fa77e8 ffffffff810b1c4f 0000000037fa77e8
[ 327.696018] ffff880037fa7808 ffff880037e4db40 0000000000000000 ffff880037e4e318
[ 327.696018] Call Trace:
[ 327.696018] [<ffffffff814d03dd>] dump_stack+0x4d/0xa0
[ 327.696018] [<ffffffff810b1c4f>] print_circular_bug+0x10f/0x120
[ 327.696018] [<ffffffff810b33fe>] check_prev_add+0x43e/0x4b0
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff81087a28>] ? sched_clock_cpu+0xd8/0x110
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff8105be80>] ? try_to_del_timer_sync+0x70/0x70
[ 327.696018] [<ffffffff8105bebd>] del_timer_sync+0x3d/0xd0
[ 327.696018] [<ffffffff8105be80>] ? try_to_del_timer_sync+0x70/0x70
[ 327.696018] [<ffffffffa02c5855>] tipc_disc_delete+0x15/0x30 [tipc]
[ 327.696018] [<ffffffffa02be59f>] bearer_disable+0xef/0x120 [tipc]
[ 327.696018] [<ffffffffa02be74f>] tipc_disable_bearer+0x2f/0x60 [tipc]
[ 327.696018] [<ffffffffa02bfb32>] tipc_cfg_do_cmd+0x2e2/0x550 [tipc]
[ 327.696018] [<ffffffff81218783>] ? security_capable+0x13/0x20
[ 327.696018] [<ffffffffa02c8c79>] handle_cmd+0x49/0xe0 [tipc]
[ 327.696018] [<ffffffff8143e898>] genl_family_rcv_msg+0x268/0x340
[ 327.696018] [<ffffffff8143ed30>] genl_rcv_msg+0x70/0xd0
[ 327.696018] [<ffffffff8143ecc0>] ? genl_lock+0x20/0x20
[ 327.696018] [<ffffffff8143d4c9>] netlink_rcv_skb+0x89/0xb0
[ 327.696018] [<ffffffff8143e608>] ? genl_rcv+0x18/0x40
[ 327.696018] [<ffffffff8143e617>] genl_rcv+0x27/0x40
[ 327.696018] [<ffffffff8143d21e>] netlink_unicast+0x15e/0x1b0
[ 327.696018] [<ffffffff81289d7c>] ? memcpy_fromiovec+0x6c/0x90
[ 327.696018] [<ffffffff8143ddcf>] netlink_sendmsg+0x22f/0x400
[ 327.696018] [<ffffffff813f7836>] __sock_sendmsg+0x66/0x80
[ 327.696018] [<ffffffff813f7957>] sock_aio_write+0x107/0x120
[ 327.696018] [<ffffffff813fe29c>] ? release_sock+0x8c/0xa0
[ 327.696018] [<ffffffff8117f76d>] do_sync_write+0x7d/0xc0
[ 327.696018] [<ffffffff8117fa24>] ? rw_verify_area+0x54/0x100
[ 327.696018] [<ffffffff8117fc56>] vfs_write+0x186/0x190
[ 327.696018] [<ffffffff811803e0>] SyS_write+0x60/0xb0
[ 327.696018] [<ffffffff814de852>] system_call_fastpath+0x16/0x1b
-----------------------------------------------------------------------
The problem is that the tipc_link_delete() will cancel the timer disc_timeout() when
the b_ptr->lock is hold, but the disc_timeout() still call b_ptr->lock to finish the
work, so the dead lock occurs.
We should unlock the b_ptr->lock when del the disc_timeout().
Remove link_timeout() still met the same problem, the patch:
http://article.gmane.org/gmane.network.tipc.general/4380
fix the problem, so no need to send patch for fix link_timeout() deadlock warming.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-08-09 18:12:58 +09:00
|
|
|
struct tipc_link_req *temp_req;
|
2006-01-03 03:04:38 +09:00
|
|
|
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_info("Disabling bearer <%s>\n", b_ptr->name);
|
2011-01-08 03:00:11 +09:00
|
|
|
spin_lock_bh(&b_ptr->lock);
|
2013-10-18 14:23:17 +09:00
|
|
|
b_ptr->media->disable_media(b_ptr);
|
2006-01-03 03:04:38 +09:00
|
|
|
list_for_each_entry_safe(l_ptr, temp_l_ptr, &b_ptr->links, link_list) {
|
2006-01-18 08:38:21 +09:00
|
|
|
tipc_link_delete(l_ptr);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
tipc: avoid possible deadlock while enable and disable bearer
We met lockdep warning when enable and disable the bearer for commands such as:
tipc-config -netid=1234 -addr=1.1.3 -be=eth:eth0
tipc-config -netid=1234 -addr=1.1.3 -bd=eth:eth0
---------------------------------------------------
[ 327.693595] ======================================================
[ 327.693994] [ INFO: possible circular locking dependency detected ]
[ 327.694519] 3.11.0-rc3-wwd-default #4 Tainted: G O
[ 327.694882] -------------------------------------------------------
[ 327.695385] tipc-config/5825 is trying to acquire lock:
[ 327.695754] (((timer))#2){+.-...}, at: [<ffffffff8105be80>] del_timer_sync+0x0/0xd0
[ 327.696018]
[ 327.696018] but task is already holding lock:
[ 327.696018] (&(&b_ptr->lock)->rlock){+.-...}, at: [<ffffffffa02be58d>] bearer_disable+ 0xdd/0x120 [tipc]
[ 327.696018]
[ 327.696018] which lock already depends on the new lock.
[ 327.696018]
[ 327.696018]
[ 327.696018] the existing dependency chain (in reverse order) is:
[ 327.696018]
[ 327.696018] -> #1 (&(&b_ptr->lock)->rlock){+.-...}:
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff814d65b1>] _raw_spin_lock_bh+0x41/0x80
[ 327.696018] [<ffffffffa02c5d48>] disc_timeout+0x18/0xd0 [tipc]
[ 327.696018] [<ffffffff8105b92a>] call_timer_fn+0xda/0x1e0
[ 327.696018] [<ffffffff8105bcd7>] run_timer_softirq+0x2a7/0x2d0
[ 327.696018] [<ffffffff8105379a>] __do_softirq+0x16a/0x2e0
[ 327.696018] [<ffffffff81053a35>] irq_exit+0xd5/0xe0
[ 327.696018] [<ffffffff81033005>] smp_apic_timer_interrupt+0x45/0x60
[ 327.696018] [<ffffffff814df4af>] apic_timer_interrupt+0x6f/0x80
[ 327.696018] [<ffffffff8100b70e>] arch_cpu_idle+0x1e/0x30
[ 327.696018] [<ffffffff810a039d>] cpu_idle_loop+0x1fd/0x280
[ 327.696018] [<ffffffff810a043e>] cpu_startup_entry+0x1e/0x20
[ 327.696018] [<ffffffff81031589>] start_secondary+0x89/0x90
[ 327.696018]
[ 327.696018] -> #0 (((timer))#2){+.-...}:
[ 327.696018] [<ffffffff810b33fe>] check_prev_add+0x43e/0x4b0
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff8105bebd>] del_timer_sync+0x3d/0xd0
[ 327.696018] [<ffffffffa02c5855>] tipc_disc_delete+0x15/0x30 [tipc]
[ 327.696018] [<ffffffffa02be59f>] bearer_disable+0xef/0x120 [tipc]
[ 327.696018] [<ffffffffa02be74f>] tipc_disable_bearer+0x2f/0x60 [tipc]
[ 327.696018] [<ffffffffa02bfb32>] tipc_cfg_do_cmd+0x2e2/0x550 [tipc]
[ 327.696018] [<ffffffffa02c8c79>] handle_cmd+0x49/0xe0 [tipc]
[ 327.696018] [<ffffffff8143e898>] genl_family_rcv_msg+0x268/0x340
[ 327.696018] [<ffffffff8143ed30>] genl_rcv_msg+0x70/0xd0
[ 327.696018] [<ffffffff8143d4c9>] netlink_rcv_skb+0x89/0xb0
[ 327.696018] [<ffffffff8143e617>] genl_rcv+0x27/0x40
[ 327.696018] [<ffffffff8143d21e>] netlink_unicast+0x15e/0x1b0
[ 327.696018] [<ffffffff8143ddcf>] netlink_sendmsg+0x22f/0x400
[ 327.696018] [<ffffffff813f7836>] __sock_sendmsg+0x66/0x80
[ 327.696018] [<ffffffff813f7957>] sock_aio_write+0x107/0x120
[ 327.696018] [<ffffffff8117f76d>] do_sync_write+0x7d/0xc0
[ 327.696018] [<ffffffff8117fc56>] vfs_write+0x186/0x190
[ 327.696018] [<ffffffff811803e0>] SyS_write+0x60/0xb0
[ 327.696018] [<ffffffff814de852>] system_call_fastpath+0x16/0x1b
[ 327.696018]
[ 327.696018] other info that might help us debug this:
[ 327.696018]
[ 327.696018] Possible unsafe locking scenario:
[ 327.696018]
[ 327.696018] CPU0 CPU1
[ 327.696018] ---- ----
[ 327.696018] lock(&(&b_ptr->lock)->rlock);
[ 327.696018] lock(((timer))#2);
[ 327.696018] lock(&(&b_ptr->lock)->rlock);
[ 327.696018] lock(((timer))#2);
[ 327.696018]
[ 327.696018] *** DEADLOCK ***
[ 327.696018]
[ 327.696018] 5 locks held by tipc-config/5825:
[ 327.696018] #0: (cb_lock){++++++}, at: [<ffffffff8143e608>] genl_rcv+0x18/0x40
[ 327.696018] #1: (genl_mutex){+.+.+.}, at: [<ffffffff8143ed66>] genl_rcv_msg+0xa6/0xd0
[ 327.696018] #2: (config_mutex){+.+.+.}, at: [<ffffffffa02bf889>] tipc_cfg_do_cmd+0x39/ 0x550 [tipc]
[ 327.696018] #3: (tipc_net_lock){++.-..}, at: [<ffffffffa02be738>] tipc_disable_bearer+ 0x18/0x60 [tipc]
[ 327.696018] #4: (&(&b_ptr->lock)->rlock){+.-...}, at: [<ffffffffa02be58d>] bearer_disable+0xdd/0x120 [tipc]
[ 327.696018]
[ 327.696018] stack backtrace:
[ 327.696018] CPU: 2 PID: 5825 Comm: tipc-config Tainted: G O 3.11.0-rc3-wwd- default #4
[ 327.696018] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 327.696018] 00000000ffffffff ffff880037fa77a8 ffffffff814d03dd 0000000000000000
[ 327.696018] ffff880037fa7808 ffff880037fa77e8 ffffffff810b1c4f 0000000037fa77e8
[ 327.696018] ffff880037fa7808 ffff880037e4db40 0000000000000000 ffff880037e4e318
[ 327.696018] Call Trace:
[ 327.696018] [<ffffffff814d03dd>] dump_stack+0x4d/0xa0
[ 327.696018] [<ffffffff810b1c4f>] print_circular_bug+0x10f/0x120
[ 327.696018] [<ffffffff810b33fe>] check_prev_add+0x43e/0x4b0
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff81087a28>] ? sched_clock_cpu+0xd8/0x110
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff8105be80>] ? try_to_del_timer_sync+0x70/0x70
[ 327.696018] [<ffffffff8105bebd>] del_timer_sync+0x3d/0xd0
[ 327.696018] [<ffffffff8105be80>] ? try_to_del_timer_sync+0x70/0x70
[ 327.696018] [<ffffffffa02c5855>] tipc_disc_delete+0x15/0x30 [tipc]
[ 327.696018] [<ffffffffa02be59f>] bearer_disable+0xef/0x120 [tipc]
[ 327.696018] [<ffffffffa02be74f>] tipc_disable_bearer+0x2f/0x60 [tipc]
[ 327.696018] [<ffffffffa02bfb32>] tipc_cfg_do_cmd+0x2e2/0x550 [tipc]
[ 327.696018] [<ffffffff81218783>] ? security_capable+0x13/0x20
[ 327.696018] [<ffffffffa02c8c79>] handle_cmd+0x49/0xe0 [tipc]
[ 327.696018] [<ffffffff8143e898>] genl_family_rcv_msg+0x268/0x340
[ 327.696018] [<ffffffff8143ed30>] genl_rcv_msg+0x70/0xd0
[ 327.696018] [<ffffffff8143ecc0>] ? genl_lock+0x20/0x20
[ 327.696018] [<ffffffff8143d4c9>] netlink_rcv_skb+0x89/0xb0
[ 327.696018] [<ffffffff8143e608>] ? genl_rcv+0x18/0x40
[ 327.696018] [<ffffffff8143e617>] genl_rcv+0x27/0x40
[ 327.696018] [<ffffffff8143d21e>] netlink_unicast+0x15e/0x1b0
[ 327.696018] [<ffffffff81289d7c>] ? memcpy_fromiovec+0x6c/0x90
[ 327.696018] [<ffffffff8143ddcf>] netlink_sendmsg+0x22f/0x400
[ 327.696018] [<ffffffff813f7836>] __sock_sendmsg+0x66/0x80
[ 327.696018] [<ffffffff813f7957>] sock_aio_write+0x107/0x120
[ 327.696018] [<ffffffff813fe29c>] ? release_sock+0x8c/0xa0
[ 327.696018] [<ffffffff8117f76d>] do_sync_write+0x7d/0xc0
[ 327.696018] [<ffffffff8117fa24>] ? rw_verify_area+0x54/0x100
[ 327.696018] [<ffffffff8117fc56>] vfs_write+0x186/0x190
[ 327.696018] [<ffffffff811803e0>] SyS_write+0x60/0xb0
[ 327.696018] [<ffffffff814de852>] system_call_fastpath+0x16/0x1b
-----------------------------------------------------------------------
The problem is that the tipc_link_delete() will cancel the timer disc_timeout() when
the b_ptr->lock is hold, but the disc_timeout() still call b_ptr->lock to finish the
work, so the dead lock occurs.
We should unlock the b_ptr->lock when del the disc_timeout().
Remove link_timeout() still met the same problem, the patch:
http://article.gmane.org/gmane.network.tipc.general/4380
fix the problem, so no need to send patch for fix link_timeout() deadlock warming.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-08-09 18:12:58 +09:00
|
|
|
temp_req = b_ptr->link_req;
|
|
|
|
b_ptr->link_req = NULL;
|
2011-01-08 03:00:11 +09:00
|
|
|
spin_unlock_bh(&b_ptr->lock);
|
tipc: avoid possible deadlock while enable and disable bearer
We met lockdep warning when enable and disable the bearer for commands such as:
tipc-config -netid=1234 -addr=1.1.3 -be=eth:eth0
tipc-config -netid=1234 -addr=1.1.3 -bd=eth:eth0
---------------------------------------------------
[ 327.693595] ======================================================
[ 327.693994] [ INFO: possible circular locking dependency detected ]
[ 327.694519] 3.11.0-rc3-wwd-default #4 Tainted: G O
[ 327.694882] -------------------------------------------------------
[ 327.695385] tipc-config/5825 is trying to acquire lock:
[ 327.695754] (((timer))#2){+.-...}, at: [<ffffffff8105be80>] del_timer_sync+0x0/0xd0
[ 327.696018]
[ 327.696018] but task is already holding lock:
[ 327.696018] (&(&b_ptr->lock)->rlock){+.-...}, at: [<ffffffffa02be58d>] bearer_disable+ 0xdd/0x120 [tipc]
[ 327.696018]
[ 327.696018] which lock already depends on the new lock.
[ 327.696018]
[ 327.696018]
[ 327.696018] the existing dependency chain (in reverse order) is:
[ 327.696018]
[ 327.696018] -> #1 (&(&b_ptr->lock)->rlock){+.-...}:
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff814d65b1>] _raw_spin_lock_bh+0x41/0x80
[ 327.696018] [<ffffffffa02c5d48>] disc_timeout+0x18/0xd0 [tipc]
[ 327.696018] [<ffffffff8105b92a>] call_timer_fn+0xda/0x1e0
[ 327.696018] [<ffffffff8105bcd7>] run_timer_softirq+0x2a7/0x2d0
[ 327.696018] [<ffffffff8105379a>] __do_softirq+0x16a/0x2e0
[ 327.696018] [<ffffffff81053a35>] irq_exit+0xd5/0xe0
[ 327.696018] [<ffffffff81033005>] smp_apic_timer_interrupt+0x45/0x60
[ 327.696018] [<ffffffff814df4af>] apic_timer_interrupt+0x6f/0x80
[ 327.696018] [<ffffffff8100b70e>] arch_cpu_idle+0x1e/0x30
[ 327.696018] [<ffffffff810a039d>] cpu_idle_loop+0x1fd/0x280
[ 327.696018] [<ffffffff810a043e>] cpu_startup_entry+0x1e/0x20
[ 327.696018] [<ffffffff81031589>] start_secondary+0x89/0x90
[ 327.696018]
[ 327.696018] -> #0 (((timer))#2){+.-...}:
[ 327.696018] [<ffffffff810b33fe>] check_prev_add+0x43e/0x4b0
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff8105bebd>] del_timer_sync+0x3d/0xd0
[ 327.696018] [<ffffffffa02c5855>] tipc_disc_delete+0x15/0x30 [tipc]
[ 327.696018] [<ffffffffa02be59f>] bearer_disable+0xef/0x120 [tipc]
[ 327.696018] [<ffffffffa02be74f>] tipc_disable_bearer+0x2f/0x60 [tipc]
[ 327.696018] [<ffffffffa02bfb32>] tipc_cfg_do_cmd+0x2e2/0x550 [tipc]
[ 327.696018] [<ffffffffa02c8c79>] handle_cmd+0x49/0xe0 [tipc]
[ 327.696018] [<ffffffff8143e898>] genl_family_rcv_msg+0x268/0x340
[ 327.696018] [<ffffffff8143ed30>] genl_rcv_msg+0x70/0xd0
[ 327.696018] [<ffffffff8143d4c9>] netlink_rcv_skb+0x89/0xb0
[ 327.696018] [<ffffffff8143e617>] genl_rcv+0x27/0x40
[ 327.696018] [<ffffffff8143d21e>] netlink_unicast+0x15e/0x1b0
[ 327.696018] [<ffffffff8143ddcf>] netlink_sendmsg+0x22f/0x400
[ 327.696018] [<ffffffff813f7836>] __sock_sendmsg+0x66/0x80
[ 327.696018] [<ffffffff813f7957>] sock_aio_write+0x107/0x120
[ 327.696018] [<ffffffff8117f76d>] do_sync_write+0x7d/0xc0
[ 327.696018] [<ffffffff8117fc56>] vfs_write+0x186/0x190
[ 327.696018] [<ffffffff811803e0>] SyS_write+0x60/0xb0
[ 327.696018] [<ffffffff814de852>] system_call_fastpath+0x16/0x1b
[ 327.696018]
[ 327.696018] other info that might help us debug this:
[ 327.696018]
[ 327.696018] Possible unsafe locking scenario:
[ 327.696018]
[ 327.696018] CPU0 CPU1
[ 327.696018] ---- ----
[ 327.696018] lock(&(&b_ptr->lock)->rlock);
[ 327.696018] lock(((timer))#2);
[ 327.696018] lock(&(&b_ptr->lock)->rlock);
[ 327.696018] lock(((timer))#2);
[ 327.696018]
[ 327.696018] *** DEADLOCK ***
[ 327.696018]
[ 327.696018] 5 locks held by tipc-config/5825:
[ 327.696018] #0: (cb_lock){++++++}, at: [<ffffffff8143e608>] genl_rcv+0x18/0x40
[ 327.696018] #1: (genl_mutex){+.+.+.}, at: [<ffffffff8143ed66>] genl_rcv_msg+0xa6/0xd0
[ 327.696018] #2: (config_mutex){+.+.+.}, at: [<ffffffffa02bf889>] tipc_cfg_do_cmd+0x39/ 0x550 [tipc]
[ 327.696018] #3: (tipc_net_lock){++.-..}, at: [<ffffffffa02be738>] tipc_disable_bearer+ 0x18/0x60 [tipc]
[ 327.696018] #4: (&(&b_ptr->lock)->rlock){+.-...}, at: [<ffffffffa02be58d>] bearer_disable+0xdd/0x120 [tipc]
[ 327.696018]
[ 327.696018] stack backtrace:
[ 327.696018] CPU: 2 PID: 5825 Comm: tipc-config Tainted: G O 3.11.0-rc3-wwd- default #4
[ 327.696018] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
[ 327.696018] 00000000ffffffff ffff880037fa77a8 ffffffff814d03dd 0000000000000000
[ 327.696018] ffff880037fa7808 ffff880037fa77e8 ffffffff810b1c4f 0000000037fa77e8
[ 327.696018] ffff880037fa7808 ffff880037e4db40 0000000000000000 ffff880037e4e318
[ 327.696018] Call Trace:
[ 327.696018] [<ffffffff814d03dd>] dump_stack+0x4d/0xa0
[ 327.696018] [<ffffffff810b1c4f>] print_circular_bug+0x10f/0x120
[ 327.696018] [<ffffffff810b33fe>] check_prev_add+0x43e/0x4b0
[ 327.696018] [<ffffffff810b3b4d>] validate_chain+0x6dd/0x870
[ 327.696018] [<ffffffff81087a28>] ? sched_clock_cpu+0xd8/0x110
[ 327.696018] [<ffffffff810b40bb>] __lock_acquire+0x3db/0x670
[ 327.696018] [<ffffffff810b4453>] lock_acquire+0x103/0x130
[ 327.696018] [<ffffffff8105be80>] ? try_to_del_timer_sync+0x70/0x70
[ 327.696018] [<ffffffff8105bebd>] del_timer_sync+0x3d/0xd0
[ 327.696018] [<ffffffff8105be80>] ? try_to_del_timer_sync+0x70/0x70
[ 327.696018] [<ffffffffa02c5855>] tipc_disc_delete+0x15/0x30 [tipc]
[ 327.696018] [<ffffffffa02be59f>] bearer_disable+0xef/0x120 [tipc]
[ 327.696018] [<ffffffffa02be74f>] tipc_disable_bearer+0x2f/0x60 [tipc]
[ 327.696018] [<ffffffffa02bfb32>] tipc_cfg_do_cmd+0x2e2/0x550 [tipc]
[ 327.696018] [<ffffffff81218783>] ? security_capable+0x13/0x20
[ 327.696018] [<ffffffffa02c8c79>] handle_cmd+0x49/0xe0 [tipc]
[ 327.696018] [<ffffffff8143e898>] genl_family_rcv_msg+0x268/0x340
[ 327.696018] [<ffffffff8143ed30>] genl_rcv_msg+0x70/0xd0
[ 327.696018] [<ffffffff8143ecc0>] ? genl_lock+0x20/0x20
[ 327.696018] [<ffffffff8143d4c9>] netlink_rcv_skb+0x89/0xb0
[ 327.696018] [<ffffffff8143e608>] ? genl_rcv+0x18/0x40
[ 327.696018] [<ffffffff8143e617>] genl_rcv+0x27/0x40
[ 327.696018] [<ffffffff8143d21e>] netlink_unicast+0x15e/0x1b0
[ 327.696018] [<ffffffff81289d7c>] ? memcpy_fromiovec+0x6c/0x90
[ 327.696018] [<ffffffff8143ddcf>] netlink_sendmsg+0x22f/0x400
[ 327.696018] [<ffffffff813f7836>] __sock_sendmsg+0x66/0x80
[ 327.696018] [<ffffffff813f7957>] sock_aio_write+0x107/0x120
[ 327.696018] [<ffffffff813fe29c>] ? release_sock+0x8c/0xa0
[ 327.696018] [<ffffffff8117f76d>] do_sync_write+0x7d/0xc0
[ 327.696018] [<ffffffff8117fa24>] ? rw_verify_area+0x54/0x100
[ 327.696018] [<ffffffff8117fc56>] vfs_write+0x186/0x190
[ 327.696018] [<ffffffff811803e0>] SyS_write+0x60/0xb0
[ 327.696018] [<ffffffff814de852>] system_call_fastpath+0x16/0x1b
-----------------------------------------------------------------------
The problem is that the tipc_link_delete() will cancel the timer disc_timeout() when
the b_ptr->lock is hold, but the disc_timeout() still call b_ptr->lock to finish the
work, so the dead lock occurs.
We should unlock the b_ptr->lock when del the disc_timeout().
Remove link_timeout() still met the same problem, the patch:
http://article.gmane.org/gmane.network.tipc.general/4380
fix the problem, so no need to send patch for fix link_timeout() deadlock warming.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-08-09 18:12:58 +09:00
|
|
|
|
|
|
|
if (temp_req)
|
|
|
|
tipc_disc_delete(temp_req);
|
|
|
|
|
2011-01-08 03:00:11 +09:00
|
|
|
memset(b_ptr, 0, sizeof(struct tipc_bearer));
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
int tipc_disable_bearer(const char *name)
|
|
|
|
{
|
2011-01-08 03:00:11 +09:00
|
|
|
struct tipc_bearer *b_ptr;
|
2006-01-03 03:04:38 +09:00
|
|
|
int res;
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
write_lock_bh(&tipc_net_lock);
|
2011-10-19 00:34:29 +09:00
|
|
|
b_ptr = tipc_bearer_find(name);
|
2010-10-14 22:58:26 +09:00
|
|
|
if (b_ptr == NULL) {
|
2012-06-29 13:16:37 +09:00
|
|
|
pr_warn("Attempt to disable unknown bearer <%s>\n", name);
|
2010-10-14 22:58:26 +09:00
|
|
|
res = -EINVAL;
|
2010-11-30 21:00:56 +09:00
|
|
|
} else {
|
|
|
|
bearer_disable(b_ptr);
|
|
|
|
res = 0;
|
|
|
|
}
|
2006-01-18 08:38:21 +09:00
|
|
|
write_unlock_bh(&tipc_net_lock);
|
2006-01-03 03:04:38 +09:00
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
2006-01-18 08:38:21 +09:00
|
|
|
void tipc_bearer_stop(void)
|
2006-01-03 03:04:38 +09:00
|
|
|
{
|
|
|
|
u32 i;
|
|
|
|
|
|
|
|
for (i = 0; i < MAX_BEARERS; i++) {
|
2006-01-18 08:38:21 +09:00
|
|
|
if (tipc_bearers[i].active)
|
2010-10-14 22:58:26 +09:00
|
|
|
bearer_disable(&tipc_bearers[i]);
|
2006-01-03 03:04:38 +09:00
|
|
|
}
|
|
|
|
}
|