Josef Bacik
fb2fecbad5
btrfs: check the right error variable in btrfs_del_dir_entries_in_log
...
With my new locking code dbench is so much faster that I tripped over a
transaction abort from ENOSPC. This turned out to be because
btrfs_del_dir_entries_in_log was checking for ret == -ENOSPC, but this
function sets err on error, and returns err. So instead of properly
marking the inode as needing a full commit, we were returning -ENOSPC
and aborting in __btrfs_unlink_inode. Fix this by checking the proper
variable so that we return the correct thing in the case of ENOSPC.
The ENOENT needs to be checked, because btrfs_lookup_dir_item_index()
can return -ENOENT if the dir item isn't in the tree log (which would
happen if we hadn't fsync'ed this guy). We actually handle that case in
__btrfs_unlink_inode, so it's an expected error to get back.
Fixes: 4a500fd178c8 ("Btrfs: Metadata ENOSPC handling for tree log")
CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ add note and comment about ENOENT ]
Signed-off-by: David Sterba <dsterba@suse.com>
2020-08-21 12:20:01 +02:00
..
2020-03-27 09:29:56 +00:00
2020-04-20 15:45:22 -06:00
2020-04-20 15:45:22 -06:00
2020-07-15 15:49:04 -07:00
2020-07-08 08:27:56 +02:00
2020-04-20 15:45:22 -06:00
2020-08-21 12:20:01 +02:00
2020-07-08 08:27:56 +02:00
2020-06-01 13:22:53 +02:00
2020-07-23 15:44:11 -05:00
2020-05-05 09:22:21 -06:00
2020-06-01 15:45:27 -07:00
2020-04-20 15:45:22 -06:00
2020-06-01 12:10:17 -07:00
2020-04-27 09:34:55 +02:00
2020-06-05 16:43:16 -07:00
2020-06-01 15:45:27 -07:00
2020-07-09 10:14:29 +03:00
2020-06-24 09:47:44 +08:00
2020-07-21 10:44:19 +09:00
2020-06-09 09:39:14 -07:00
2020-06-15 09:32:10 -07:00
2020-06-09 11:28:59 -07:00
2020-06-04 19:06:25 -07:00
2020-06-03 16:27:18 -07:00
2020-07-15 14:18:20 +02:00
2020-07-07 23:40:12 +02:00
2020-06-02 15:29:19 -07:00
2020-05-22 08:45:46 -06:00
2020-03-29 23:23:00 +02:00
2020-06-06 10:08:17 -07:00
2020-06-09 09:39:14 -07:00
2020-06-13 12:44:30 -07:00
2020-06-02 15:29:19 -07:00
2020-06-15 09:32:10 -07:00
2020-06-15 23:08:31 -05:00
2020-06-02 20:11:35 -07:00
2020-06-09 09:39:14 -07:00
2020-02-04 03:05:26 +00:00
2020-07-17 14:47:38 -04:00
2020-07-22 16:47:14 -04:00
2020-06-10 19:14:17 -07:00
2020-06-14 01:57:21 +09:00
2020-06-14 01:57:21 +09:00
2020-06-02 12:21:36 -07:00
2020-06-26 00:27:37 -07:00
2020-06-02 10:59:07 -07:00
2020-06-05 16:44:36 -07:00
2020-07-16 07:24:47 +02:00
2020-07-03 23:20:14 -07:00
2020-06-01 16:18:46 -07:00
2020-06-02 10:59:07 -07:00
2020-04-27 02:07:40 -04:00
2020-02-07 14:48:37 -05:00
2020-06-04 13:53:10 -07:00
2020-06-14 01:57:21 +09:00
2020-07-24 12:42:41 -07:00
2020-06-05 14:05:57 -07:00
2020-04-20 15:45:22 -06:00
2020-06-02 10:59:11 -07:00
2020-06-02 15:29:19 -07:00
2020-03-25 11:50:48 +01:00
2020-05-07 08:45:47 -06:00
2020-05-12 16:44:00 -07:00
2020-06-22 19:22:57 -07:00
2020-07-20 17:59:31 +09:00
2020-06-15 23:08:25 -05:00
2020-06-03 23:16:55 -04:00
2020-05-07 16:55:47 -05:00
2020-06-10 16:02:54 -07:00
2020-06-10 16:02:54 -07:00
2020-06-04 19:18:29 -07:00
2020-06-10 16:02:54 -07:00
2020-06-04 19:18:29 -07:00
2020-06-04 19:18:29 -07:00
2020-06-18 09:24:35 -06:00
2020-06-02 10:59:07 -07:00
2020-05-14 16:44:23 +02:00
2020-06-05 13:45:21 -07:00
2020-06-09 09:39:14 -07:00
2020-04-02 19:15:03 -07:00
2020-06-03 16:27:18 -07:00
2020-06-14 09:47:25 -07:00
2020-04-27 02:07:40 -04:00
2020-05-06 22:33:43 -04:00
2020-05-14 10:00:35 -07:00
2020-06-09 09:39:14 -07:00
2020-03-03 10:55:06 -05:00
2020-06-29 09:40:55 -07:00
2020-05-19 18:29:36 -04:00
2020-04-10 15:36:22 -07:00
2020-05-14 16:44:25 +02:00
2020-04-02 09:35:26 -07:00
2020-06-05 16:19:28 -07:00
2020-02-07 14:48:35 -05:00
2020-06-05 16:26:36 -07:00
2020-06-05 16:19:28 -07:00
2020-07-23 11:20:55 -06:00
2020-06-15 08:51:34 -06:00
2020-06-15 08:51:38 -06:00
2020-06-03 23:16:55 -04:00
2020-06-14 01:57:21 +09:00
2020-06-14 01:57:21 +09:00
2020-05-22 08:45:46 -06:00
2020-06-11 10:33:13 -07:00
2020-03-05 21:00:40 -05:00
2020-05-14 16:44:24 +02:00
2020-06-02 10:59:07 -07:00
2020-06-08 11:04:19 -07:00
2020-07-14 14:45:41 +02:00
2020-05-13 11:41:22 +02:00
2020-06-02 12:21:36 -07:00
2020-06-13 09:56:21 -07:00
2020-04-27 10:37:14 -04:00
2020-06-08 11:04:19 -07:00
2020-06-04 13:54:34 -07:00
2020-07-08 08:27:57 +02:00
2020-05-01 20:29:54 -04:00
2020-05-29 19:10:42 -04:00
2020-06-04 19:06:25 -07:00
2020-06-13 09:56:21 -07:00
2020-06-02 19:45:12 -07:00
2020-06-10 16:09:11 -07:00
2020-06-09 15:40:50 -07:00
2020-01-14 12:20:53 +01:00
2020-06-09 09:39:14 -07:00
2020-05-14 16:44:24 +02:00
2020-04-09 15:33:09 -04:00