android_kernel_samsung_sm8650/fs/ntfs3
Zeng Heng c86a2517df ntfs: Fix panic about slab-out-of-bounds caused by ntfs_listxattr()
[ Upstream commit 3c675ddffb17a8b1e32efad5c983254af18b12c2 ]

Here is a BUG report from syzbot:

BUG: KASAN: slab-out-of-bounds in ntfs_list_ea fs/ntfs3/xattr.c:191 [inline]
BUG: KASAN: slab-out-of-bounds in ntfs_listxattr+0x401/0x570 fs/ntfs3/xattr.c:710
Read of size 1 at addr ffff888021acaf3d by task syz-executor128/3632

Call Trace:
 ntfs_list_ea fs/ntfs3/xattr.c:191 [inline]
 ntfs_listxattr+0x401/0x570 fs/ntfs3/xattr.c:710
 vfs_listxattr fs/xattr.c:457 [inline]
 listxattr+0x293/0x2d0 fs/xattr.c:804

Fix the logic of ea_all iteration. When the ea->name_len is 0,
return immediately, or Add2Ptr() would visit invalid memory
in the next loop.

Fixes: be71b5cba2 ("fs/ntfs3: Add attrib operations")
Reported-by: syzbot+9fcea5ef6dc4dc72d334@syzkaller.appspotmail.com
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
[almaz.alexandrovich@paragon-software.com: lines of the patch have changed]
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-07-19 16:22:04 +02:00
..
lib fs/ntfs3: Add missing header and guards to lib/ headers 2021-09-13 19:41:44 +03:00
attrib.c fs/ntfs3: Fix attr_punch_hole() null pointer derenference 2023-01-24 07:24:41 +01:00
attrlist.c fs/ntfs3: Validate data run offset 2023-01-04 11:28:54 +01:00
bitfunc.c fs/ntfs3: Remove a useless shadowing variable 2021-09-23 19:05:46 +03:00
bitmap.c fs/ntfs3: Refactoring of various minor issues 2023-05-17 11:53:51 +02:00
debug.h fs/ntfs3. Add forward declarations for structs to debug.h 2021-09-13 19:41:43 +03:00
dir.c fs/ntfs3: Rework ntfs_utf16_to_nls 2021-10-11 19:28:04 +03:00
file.c fs/ntfs3: don't hold ni_lock when calling truncate_setsize() 2023-01-12 12:02:28 +01:00
frecord.c fs/ntfs3: Validate data run offset 2023-01-04 11:28:54 +01:00
fslog.c fs/ntfs3: Fix slab-out-of-bounds read in hdr_delete_de() 2023-05-11 23:03:33 +09:00
fsntfs.c fs/ntfs3: Validate index root when initialize NTFS security 2023-01-04 11:28:57 +01:00
index.c fs/ntfs3: Fix slab-out-of-bounds read in hdr_delete_de() 2023-05-11 23:03:33 +09:00
inode.c fs/ntfs3: Validate MFT flags before replaying logs 2023-06-09 10:34:28 +02:00
Kconfig
lznt.c fs/ntfs3: Remove tabs before spaces from comment 2021-09-16 17:01:36 +03:00
Makefile
namei.c fs/ntfs3: Refactoring of various minor issues 2023-05-17 11:53:51 +02:00
ntfs_fs.h fs/ntfs3: Fix slab-out-of-bounds read in hdr_delete_de() 2023-05-11 23:03:33 +09:00
ntfs.h fs/ntfs3: Refactoring of various minor issues 2023-05-17 11:53:51 +02:00
record.c fs/ntfs3: Validate resident attribute name 2023-01-04 11:28:56 +01:00
run.c fs/ntfs3: Refactoring attr_punch_hole to restore after errors 2022-08-03 18:25:09 +03:00
super.c fs/ntfs3: Use __GFP_NOWARN allocation at ntfs_fill_super() 2023-01-04 11:28:57 +01:00
upcase.c fs/ntfs3: Change right headers to upcase.c 2021-09-13 19:41:45 +03:00
xattr.c ntfs: Fix panic about slab-out-of-bounds caused by ntfs_listxattr() 2023-07-19 16:22:04 +02:00