David Daney f21afc25f9 smp.h: Use local_irq_{save,restore}() in !SMP version of on_each_cpu().
Thanks to commit f91eb62f71b3 ("init: scream bloody murder if interrupts
are enabled too early"), "bloody murder" is now being screamed.

With a MIPS OCTEON config, we use on_each_cpu() in our
irq_chip.irq_bus_sync_unlock() function.  This gets called in early as a
result of the time_init() call.  Because the !SMP version of
on_each_cpu() unconditionally enables irqs, we get:

    WARNING: at init/main.c:560 start_kernel+0x250/0x410()
    Interrupts were enabled early
    CPU: 0 PID: 0 Comm: swapper Not tainted 3.10.0-rc5-Cavium-Octeon+ #801
    Call Trace:
      show_stack+0x68/0x80
      warn_slowpath_common+0x78/0xb0
      warn_slowpath_fmt+0x38/0x48
      start_kernel+0x250/0x410

Suggested fix: Do what we already do in the SMP version of
on_each_cpu(), and use local_irq_save/local_irq_restore.  Because we
need a flags variable, make it a static inline to avoid name space
issues.

[ Change from v1: Convert on_each_cpu to a static inline function, add
  #include <linux/irqflags.h> to avoid build breakage on some files.

  on_each_cpu_mask() and on_each_cpu_cond() suffer the same problem as
  on_each_cpu(), but they are not causing !SMP bugs for me, so I will
  defer changing them to a less urgent patch. ]

Signed-off-by: David Daney <david.daney@cavium.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-06-14 19:24:42 -10:00
..
2013-05-17 14:31:05 -04:00
2013-05-04 12:31:18 -07:00
2013-03-01 13:39:00 -08:00
2013-01-02 17:36:10 -08:00
2013-05-07 19:46:02 -07:00
2012-10-08 13:50:20 +10:30
2012-12-02 00:05:12 +00:00
2013-04-29 15:40:23 -04:00
2013-03-23 16:11:31 -07:00
2013-03-22 15:18:18 -07:00
2013-05-02 09:03:55 -07:00
2013-03-12 11:30:04 -07:00
2013-05-10 14:37:17 +01:00
2013-05-01 16:36:22 +05:30
2013-03-28 10:10:25 -06:00
2012-12-24 09:36:38 -07:00
2012-09-30 18:02:20 -07:00
2012-10-16 18:49:15 -07:00
2013-02-26 02:46:08 -05:00
2013-05-07 18:38:27 -07:00
2013-03-15 15:09:43 +10:30
2013-04-29 18:28:40 -07:00
2012-11-22 13:43:27 +09:00
2013-05-07 02:16:31 -04:00
2013-02-22 23:31:31 -05:00
2012-11-08 16:58:30 +01:00
2013-05-06 13:07:33 +02:00
2013-01-25 21:03:54 -08:00
2013-02-06 15:59:47 -05:00
2013-01-29 13:59:57 -05:00
2013-01-10 11:44:38 -06:00
2013-04-30 17:04:06 -07:00
2013-04-01 11:04:50 -07:00
2012-10-10 01:15:44 -04:00
2013-04-30 17:04:00 -07:00
2013-03-15 15:09:43 +10:30
2012-12-14 13:06:40 +10:30
2012-12-25 18:45:06 -05:00
2013-04-29 18:28:44 -07:00
2012-12-11 17:22:27 -08:00
2013-05-04 14:47:26 -04:00
2012-10-17 15:53:02 -05:00
2012-10-10 22:41:05 -04:00
2013-05-07 11:22:14 -07:00
2013-04-29 15:54:28 -07:00
2013-03-12 11:40:53 -04:00
2013-03-19 09:47:30 +01:00
2013-02-26 09:34:29 -08:00
2013-04-29 15:54:28 -07:00
2013-04-12 10:26:23 +02:00
2012-10-06 03:05:01 +09:00
2013-04-09 14:13:29 -04:00
2013-02-19 08:43:34 +01:00
2013-03-29 15:31:30 -04:00
2013-04-30 15:50:12 +05:30
2013-03-21 11:47:51 -04:00
2012-10-09 16:22:32 +09:00
2013-01-15 22:43:15 -08:00
2013-03-20 12:10:38 -04:00
2013-03-28 11:10:22 -07:00
2013-04-29 15:54:37 -07:00