Gao Xiang 05e0952ddb erofs: fix wrong primary bvec selection on deduplicated extents ... [ Upstream commit 94c43de73521d8ed7ebcfc6191d9dace1cbf7caa ] When handling deduplicated compressed data, there can be multiple decompressed extents pointing to the same compressed data in one shot. In such cases, the bvecs which belong to the longest extent will be selected as the primary bvecs for real decompressors to decode and the other duplicated bvecs will be directly copied from the primary bvecs. Previously, only relative offsets of the longest extent were checked to decompress the primary bvecs. On rare occasions, it can be incorrect if there are several extents with the same start relative offset. As a result, some short bvecs could be selected for decompression and then cause data corruption. For example, as Shijie Sun reported off-list, considering the following extents of a file: 117: 903345.. 915250 | 11905 : 385024.. 389120 | 4096 ... 119: 919729.. 930323 | 10594 : 385024.. 389120 | 4096 ... 124: 968881.. 980786 | 11905 : 385024.. 389120 | 4096 The start relative offset is the same: 2225, but extent 119 (919729.. 930323) is shorter than the others. Let's restrict the bvec length in addition to the start offset if bvecs are not full. Reported-by: Shijie Sun <sunshijie@xiaomi.com> Fixes: 5c2a64252c ("erofs: introduce partial-referenced pclusters") Tested-by Shijie Sun <sunshijie@xiaomi.com> Reviewed-by: Yue Hu <huyue2@coolpad.com> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> Link: https://lore.kernel.org/r/20230719065459.60083-1-hsiangkao@linux.alibaba.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-08-11 12:08:11 +02:00
..
9p	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
adfs
affs	affs: initialize fsdata in affs_truncate()	2023-02-01 08:34:08 +01:00
afs	afs: Fix accidental truncation when storing data	2023-07-19 16:22:06 +02:00
autofs	autofs: remove unused ino field inode	2022-07-17 17:31:42 -07:00
befs	befs: Convert befs_symlink_read_folio() to use a folio	2022-08-02 12:34:03 -04:00
bfs
btrfs	btrfs: check for commit error at btrfs_attach_transaction_barrier()	2023-08-03 10:24:13 +02:00
cachefiles	cachefiles: use vfs_tmpfile_open() helper	2022-09-24 07:00:00 +02:00
ceph	ceph: never send metrics if disable_send_metrics is set	2023-08-03 10:24:16 +02:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-10 09:33:52 +01:00
configfs	configfs: fix possible memory leak in configfs_create_dir()	2022-12-31 13:32:22 +01:00
cramfs	fs/cramfs/inode.c: initialize file_ra_state	2023-03-10 09:34:09 +01:00
crypto	blk-crypto: add a blk_crypto_config_supported_natively helper	2023-05-11 23:03:00 +09:00
debugfs	debugfs: fix error when writing negative value to atomic_t debugfs file	2022-12-31 13:31:58 +01:00
devpts
dlm	fs: dlm: fix mismatch of plock results from userspace	2023-07-23 13:49:38 +02:00
ecryptfs	whack-a-mole: constifying struct path *	2022-10-06 17:31:02 -07:00
efivarfs	efi: efivars: Fix variable writes without query_variable_store()	2022-10-21 11:09:40 +02:00
efs
erofs	erofs: fix wrong primary bvec selection on deduplicated extents	2023-08-11 12:08:11 +02:00
exfat	exfat: fix inode->i_blocks for non-512 byte sector size device	2023-03-10 09:34:08 +01:00
exportfs	Change calling conventions for filldir_t	2022-08-17 17:25:04 -04:00
ext2	ext2/dax: Fix ext2_setsize when len is page aligned	2023-07-23 13:49:34 +02:00
ext4	ext4: correct inline offset when handling xattrs in inode body	2023-07-27 08:50:31 +02:00
f2fs	f2fs: fix deadlock in i_xattr_sem and inode page lock	2023-07-23 13:49:29 +02:00
fat	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
freevxfs	freevxfs: Convert vxfs_immed_read_folio() to use a folio	2022-08-02 12:34:03 -04:00
fscache	fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()	2023-02-22 12:59:43 +01:00
fuse	fuse: ioctl: translate ENOSYS in outarg	2023-07-27 08:50:25 +02:00
gfs2	gfs2: Fix duplicate should_fault_in_pages() call	2023-07-19 16:21:54 +02:00
hfs	hfs: fix missing hfs_bnode_get() in __hfs_bnode_create	2023-03-10 09:34:07 +01:00
hfsplus	fs: hfsplus: remove WARN_ON() from hfsplus_cat_{read,write}_inode()	2023-05-24 17:32:34 +01:00
hostfs	hostfs: move from strlcpy with unused retval to strscpy	2022-09-19 22:46:25 +02:00
hpfs
hugetlbfs	hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()	2022-12-31 13:33:05 +01:00
iomap	iomap: add a tracepoint for mappings returned by map_blocks	2022-10-02 11:42:19 -07:00
isofs	- hfs and hfsplus kmap API modernization from Fabio Francesco	2022-10-12 11:00:22 -07:00
jbd2	jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint	2023-08-03 10:23:47 +02:00
jffs2	jffs2: reduce stack usage in jffs2_build_xattr_subsystem()	2023-07-19 16:22:11 +02:00
jfs	FS: JFS: Check for read-only mounted filesystem in txBegin	2023-07-27 08:50:33 +02:00
kernfs	kernfs: fix missing kernfs_idr_lock to remove an ID from the IDR	2023-07-19 16:21:53 +02:00
lockd	lockd: drop inappropriate svc_get() from locked_get()	2023-07-19 16:20:56 +02:00
minix	vfs: open inside ->tmpfile()	2022-09-24 07:00:00 +02:00
netfs	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
nfs	NFSv4.1: freeze the session table upon receiving NFS4ERR_BADSESSION	2023-07-19 16:21:43 +02:00
nfs_common
nfsd	nfsd: Remove incorrect check in nfsd4_validate_stateid	2023-08-03 10:24:13 +02:00
nilfs2	nilfs2: prevent general protection fault in nilfs_clear_dirty_page()	2023-06-28 11:12:27 +02:00
nls
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-19 16:22:05 +02:00
ntfs	- hfs and hfsplus kmap API modernization from Fabio Francesco	2022-10-12 11:00:22 -07:00
ntfs3	fs/ntfs3: Check fields while reading	2023-07-23 13:49:27 +02:00
ocfs2	ocfs2: Fix use of slab data with sendpage	2023-07-19 16:21:13 +02:00
omfs
openpromfs
orangefs	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
overlayfs	ovl: fix null pointer dereference in ovl_permission()	2023-08-03 10:23:47 +02:00
proc	proc/vmcore: fix signedness bug in read_from_oldmem()	2023-08-03 10:24:14 +02:00
pstore	pstore/ram: Add check for kstrdup	2023-07-19 16:21:03 +02:00
qnx4
qnx6	fs/qnx6: delete unnecessary checks before brelse()	2022-09-11 21:55:07 -07:00
quota	quota: fix warning in dqgrab()	2023-07-27 08:50:32 +02:00
ramfs	shmem: use ramfs_kill_sb() for kill_sb method of ramfs-based tmpfs	2023-07-19 16:22:11 +02:00
reiserfs	reiserfs: Add security prefix to xattr name in reiserfs_security_write()	2023-05-11 23:03:02 +09:00
romfs
smb	smb3: do not set NTLMSSP_VERSION flag for negotiate not auth request	2023-08-03 10:24:04 +02:00
squashfs	revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"	2023-02-22 12:59:50 +01:00
sysfs
sysv	fs: sysv: Fix sysv_nblocks() returns wrong value	2022-12-31 13:32:00 +01:00
tracefs	tracefs: Only clobber mode/uid/gid on remount if asked	2022-09-08 17:10:54 -04:00
ubifs	ubifs: Fix memory leak in do_rename	2023-05-11 23:03:05 +09:00
udf	udf: Fix uninitialized array access for some pathnames	2023-07-27 08:50:32 +02:00
ufs	ufs: replace ll_rw_block()	2022-09-11 20:26:07 -07:00
unicode
vboxsf
verity	fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY	2023-04-06 12:10:34 +02:00
xfs	xfs: fix xfs_inodegc_stop racing with mod_delayed_work	2023-07-19 16:22:15 +02:00
zonefs	zonefs: Always invalidate last cached page on append write	2023-04-06 12:10:52 +02:00
aio.c	aio: fix mremap after fork null-deref	2023-02-22 12:59:46 +01:00
anon_inodes.c	dynamic_dname(): drop unused dentry argument	2022-08-20 11:34:04 -04:00
attr.c	attr: use consistent sgid stripping checks	2023-03-03 11:52:25 +01:00
bad_inode.c	vfs: open inside ->tmpfile()	2022-09-24 07:00:00 +02:00
binfmt_elf_fdpic.c	elfcore: Add a cprm parameter to elf_core_extra_{phdrs,data_size}	2023-01-18 11:58:12 +01:00
binfmt_elf_test.c
binfmt_elf.c	mm: always expand the stack with the mmap write lock held	2023-07-01 13:16:25 +02:00
binfmt_flat.c
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2022-12-31 13:32:57 +01:00
binfmt_script.c
buffer.c	- hfs and hfsplus kmap API modernization from Fabio Francesco	2022-10-12 11:00:22 -07:00
char_dev.c	chardev: fix error handling in cdev_device_add()	2022-12-31 13:32:41 +01:00
compat_binfmt_elf.c
coredump.c	coredump: Move dump_emit_page() to kill unused warning	2023-02-22 12:59:50 +01:00
d_path.c	d_path.c: typo fix...	2022-08-20 11:34:33 -04:00
dax.c	Merge branch 'for-6.0/dax' into libnvdimm-fixes	2022-09-24 18:14:12 -07:00
dcache.c	tmpfile API change	2022-10-10 19:45:17 -07:00
direct-io.c	block: remove PSI accounting from the bio layer	2022-09-20 08:24:38 -06:00
drop_caches.c
eventfd.c	eventfd: provide a eventfd_signal_mask() helper	2023-01-04 11:28:48 +01:00
eventpoll.c	epoll: ep_autoremove_wake_function should use list_del_init_careful	2023-06-21 16:00:54 +02:00
exec.c	mm: always expand the stack with the mmap write lock held	2023-07-01 13:16:25 +02:00
fcntl.c
fhandle.c	do_sys_name_to_handle(): constify path	2022-09-01 17:36:39 -04:00
file_table.c	locks: fix TOCTOU race when granting write lease	2022-08-16 10:59:54 -04:00
file.c	file: always lock position for FMODE_ATOMIC_POS	2023-08-03 10:24:13 +02:00
filesystems.c
fs_context.c	fs: avoid empty option when generating legacy mount string	2023-07-19 16:22:11 +02:00
fs_parser.c	ext4: journal_path mount options should follow links	2023-01-07 11:11:59 +01:00
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c	writeback: fix call of incorrect macro	2023-05-17 11:53:33 +02:00
fsopen.c
init.c
inode.c	fs: Establish locking order for unrelated directories	2023-07-19 16:22:12 +02:00
internal.h	fs: Establish locking order for unrelated directories	2023-07-19 16:22:12 +02:00
ioctl.c
Kconfig	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
Kconfig.binfmt	Xtensa updates for v6.1	2022-10-10 14:21:11 -07:00
kernel_read_file.c
libfs.c	libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value	2022-12-31 13:31:58 +01:00
locks.c	filelocks: use mount idmapping for setlease permission check	2023-03-17 08:50:32 +01:00
Makefile	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
mbcache.c	ext4: fix deadlock due to mbcache entry corruption	2023-01-07 11:12:02 +01:00
mount.h
mpage.c	Folio changes for 6.0	2022-08-03 10:35:43 -07:00
namei.c	fs: no need to check source	2023-07-19 16:22:15 +02:00
namespace.c	fs: drop peer group ids under namespace lock	2023-04-13 16:55:33 +02:00
no-block.c
nsfs.c	dynamic_dname(): drop unused dentry argument	2022-08-20 11:34:04 -04:00
open.c	open: return EINVAL for O_DIRECTORY | O_CREAT	2023-05-24 17:32:34 +01:00
pipe.c	dynamic_dname(): drop unused dentry argument	2022-08-20 11:34:04 -04:00
pnode.c	pnode: terminate at peers of source	2023-01-04 11:29:01 +01:00
pnode.h
posix_acl.c	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
proc_namespace.c
read_write.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
readdir.c	Change calling conventions for filldir_t	2022-08-17 17:25:04 -04:00
remap_range.c	- The usual batches of cleanups from Baoquan He, Muchun Song, Miaohe	2022-08-05 16:32:45 -07:00
select.c
seq_file.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
signalfd.c
splice.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
stack.c
stat.c	vfs: support STATX_DIOALIGN on block devices	2022-09-11 19:47:12 -05:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-24 17:32:51 +01:00
super.c	fscrypt: destroy keyring after security_sb_delete()	2023-03-30 12:49:23 +02:00
sync.c
sysctls.c
timerfd.c
userfaultfd.c	Revert "userfaultfd: don't fail on unrecognized features"	2023-04-26 14:28:37 +02:00
utimes.c
xattr.c	fs: don't audit the capability check in simple_xattr_list()	2022-12-31 13:31:55 +01:00