Andrea Righi
27ac792ca0
PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
...
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:
u64 val = PAGE_ALIGN(size);
always returns a value < 4GB even if size is greater than 4GB.
The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):
#define PAGE_SHIFT 12
#define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK)
The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.
Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.
See also lkml discussion: http://lkml.org/lkml/2008/6/11/237
[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-02-08 09:22:30 -08:00
2008-02-08 09:22:29 -08:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:24:39 -07:00
2008-07-20 17:24:39 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:24:38 -07:00
2006-06-25 10:00:57 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-10-09 12:19:47 +01:00
2005-04-16 15:20:36 -07:00
2007-05-11 19:09:46 +02:00
2007-05-11 19:09:46 +02:00
2007-05-04 17:59:05 -07:00
2007-05-08 11:15:20 -07:00
2005-09-07 16:57:21 -07:00
2008-06-12 18:05:39 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-05-18 13:28:48 -07:00
2005-04-16 15:20:36 -07:00
2006-06-25 10:00:58 -07:00
2005-04-16 15:20:36 -07:00
2006-01-08 20:13:39 -08:00
2005-04-16 15:20:36 -07:00
2006-12-13 09:27:08 -08:00
2006-12-02 21:23:07 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-12-01 14:52:01 -08:00
2008-05-01 08:03:58 -07:00
2007-03-14 15:27:51 -07:00
2006-04-26 12:56:16 +01:00
2006-01-12 09:09:04 -08:00
2008-07-24 10:47:21 -07:00
2008-02-07 08:42:30 -08:00
2005-07-26 14:35:41 -07:00
2006-04-26 12:56:16 +01:00
2005-04-16 15:20:36 -07:00
2007-07-17 10:23:11 -07:00
2005-04-16 15:20:36 -07:00
2005-09-07 16:57:38 -07:00
2007-10-17 08:42:55 -07:00
2008-07-20 17:24:38 -07:00
2006-01-08 20:13:39 -08:00
2006-04-26 12:56:16 +01:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-10-20 00:32:32 +02:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-05-18 13:28:50 -07:00
2006-01-10 08:01:34 -08:00
2007-08-22 19:52:45 -07:00
2005-04-16 15:20:36 -07:00
2006-10-08 12:32:35 -07:00
2008-07-20 17:24:38 -07:00
2007-10-13 09:41:03 -07:00
2007-05-08 11:15:04 -07:00
2005-04-16 15:20:36 -07:00
2008-04-02 15:28:18 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:24:39 -07:00
2006-10-07 10:51:14 -07:00
2005-04-16 15:20:36 -07:00
2006-06-25 10:00:58 -07:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:24:39 -07:00
2006-10-09 12:19:47 +01:00
2008-07-20 17:24:39 -07:00
2008-05-05 12:38:50 -07:00
2008-07-20 17:24:39 -07:00
2006-06-25 10:00:58 -07:00
2007-02-11 10:51:20 -08:00
2007-03-14 15:27:49 -07:00
2008-07-20 17:24:38 -07:00
2006-02-15 15:32:22 -08:00
2007-05-02 19:27:14 +02:00
2005-04-16 15:20:36 -07:00
2007-05-31 07:58:14 -07:00
2007-05-31 07:58:14 -07:00
2008-02-08 09:22:42 -08:00
2008-04-28 08:58:23 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-01-09 15:59:19 -08:00
2006-06-25 10:00:58 -07:00
2006-06-25 10:00:58 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:24:38 -07:00
2008-07-20 17:24:38 -07:00
2006-04-26 12:56:16 +01:00
2008-07-24 10:47:21 -07:00
2008-02-08 09:22:39 -08:00
2005-04-16 15:20:36 -07:00
2007-07-11 16:02:07 -07:00
2005-04-16 15:20:36 -07:00
2007-05-31 07:58:14 -07:00
2008-02-06 10:41:01 -08:00
2007-05-11 08:29:34 -07:00
2008-02-08 09:22:34 -08:00
2008-02-08 09:22:29 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-07-26 11:11:57 -07:00
2005-04-16 15:20:36 -07:00
2006-10-03 23:01:26 +02:00
2008-07-20 17:24:39 -07:00
2007-10-22 21:20:03 +02:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-04-17 10:42:34 -04:00
2005-04-16 15:20:36 -07:00
2006-04-26 12:56:16 +01:00
2008-05-18 13:28:50 -07:00
2006-04-26 12:56:16 +01:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-10-08 12:32:36 -07:00
2008-01-31 19:27:19 -08:00
2007-04-25 22:24:04 -07:00
2005-04-16 15:20:36 -07:00
2006-03-26 08:57:00 -08:00
2005-04-16 15:20:36 -07:00
2006-10-06 08:53:40 -07:00
2008-02-08 09:22:42 -08:00
2008-04-28 08:58:23 -07:00
2008-07-20 17:24:38 -07:00
2006-12-09 09:41:18 -08:00
2006-10-15 11:00:58 -07:00
2005-04-16 15:20:36 -07:00
2006-10-07 10:51:14 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-02-07 08:42:32 -08:00
2007-08-22 19:52:45 -07:00
2007-08-22 19:52:45 -07:00
2007-05-09 12:30:56 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:24:38 -07:00
2005-04-16 15:20:36 -07:00
2006-06-25 10:00:57 -07:00
2008-05-02 16:18:28 -07:00
2008-05-18 13:28:48 -07:00
2005-04-16 15:20:36 -07:00
2008-04-29 08:06:27 -07:00
2008-03-04 08:04:11 -08:00
2008-02-07 08:42:30 -08:00
2007-05-31 07:58:14 -07:00
2005-04-16 15:20:36 -07:00
2006-01-12 09:09:02 -08:00