Felipe Contreras b3b301c5fe ACPI / video: improve quirk check in acpi_video_bqc_quirk()
If the _BCL package ordering is descending, the first level
(br->levels[2]) is likely to be 0, and if the number of levels
matches the number of steps, we might confuse a returned level to
mean the index.

For example:

  current_level = max_level = 100
  test_level = 0
  returned level = 100

In this case 100 means the level, not the index, and _BCM failed.
Still, if the _BCL package ordering is descending, the index of
level 0 is also 100, so we assume _BQC is indexed, when it's not.

This causes all _BQC calls to return bogus values causing weird
behavior from the user's perspective.  For example:

xbacklight -set 10; xbacklight -set 20;

would flash to 90% and then slowly down to the desired level (20).

The solution is simple; test anything other than the first level
(e.g. 1).

[rjw: Changelog]
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2013-08-04 23:45:39 +02:00
..
2013-07-26 08:57:56 -04:00
2013-07-18 12:48:40 -07:00
2013-06-27 13:42:16 -04:00
2013-07-02 14:23:01 -07:00
2013-07-28 19:08:33 +05:30
2013-07-23 16:01:28 -07:00
2013-07-10 14:46:40 -07:00
2013-07-26 11:20:10 -07:00
2013-07-26 11:36:12 -07:00
2013-08-02 13:12:52 -07:00
2013-07-02 11:44:19 -07:00
2013-06-28 13:01:40 +02:00
2013-07-22 09:34:46 +08:00
2013-07-24 16:36:41 -06:00
2013-07-23 14:38:20 -07:00
2013-07-31 17:54:24 -07:00
2013-07-10 14:50:58 -07:00
2013-07-31 11:37:43 -07:00