Stephen Boyd b34121a8fe platform/x86: intel_scu_ipc: Don't override scu in intel_scu_ipc_dev_simple_command() ... [ Upstream commit efce78584e583226e9a1f6cb2fb555d6ff47c3e7 ] Andy discovered this bug during patch review. The 'scu' argument to this function shouldn't be overridden by the function itself. It doesn't make any sense. Looking at the commit history, we see that commit f57fa18583 ("platform/x86: intel_scu_ipc: Introduce new SCU IPC API") removed the setting of the scu to ipcdev in other functions, but not this one. That was an oversight. Remove this line so that we stop overriding the scu instance that is used by this function. Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Closes: https://lore.kernel.org/r/ZPjdZ3xNmBEBvNiS@smile.fi.intel.com Cc: Prashant Malani <pmalani@chromium.org> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Fixes: f57fa18583 ("platform/x86: intel_scu_ipc: Introduce new SCU IPC API") Signed-off-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20230913212723.3055315-4-swboyd@chromium.org Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-10-06 14:56:39 +02:00
..
chrome	platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER	2023-09-13 09:43:03 +02:00
goldfish	platform: goldfish: pipe: Use platform_get_irq() to get the interrupt	2022-03-18 13:55:21 +01:00
loongarch	platform/loongarch: laptop: Fix possible UAF and simplify generic_acpi_laptop_init()	2022-10-29 16:29:31 +08:00
mellanox	platform/mellanox: NVSW_SN2201 should depend on ACPI	2023-09-19 12:28:09 +02:00
mips	MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.	2022-06-09 22:24:19 +02:00
olpc	platform/olpc: Fix uninitialized data in debugfs write	2022-07-28 20:40:15 +02:00
surface	platform/surface: aggregator_tabletsw: Add support for book mode in KIP subsystem	2023-06-14 11:15:15 +02:00
x86	platform/x86: intel_scu_ipc: Don't override scu in intel_scu_ipc_dev_simple_command()	2023-10-06 14:56:39 +02:00
Kconfig	LoongArch: Add ACPI-based generic laptop driver	2022-10-12 16:36:20 +08:00
Makefile	LoongArch: Add ACPI-based generic laptop driver	2022-10-12 16:36:20 +08:00