Yuan Can ac93f8ac66 media: i2c: ov772x: Fix memleak in ov772x_probe() ... [ Upstream commit 7485edb2b6ca5960205c0a49bedfd09bba30e521 ] A memory leak was reported when testing ov772x with bpf mock device: AssertionError: unreferenced object 0xffff888109afa7a8 (size 8): comm "python3", pid 279, jiffies 4294805921 (age 20.681s) hex dump (first 8 bytes): 80 22 88 15 81 88 ff ff ."...... backtrace: [<000000009990b438>] __kmalloc_node+0x44/0x1b0 [<000000009e32f7d7>] kvmalloc_node+0x34/0x180 [<00000000faf48134>] v4l2_ctrl_handler_init_class+0x11d/0x180 [videodev] [<00000000da376937>] ov772x_probe+0x1c3/0x68c [ov772x] [<000000003f0d225e>] i2c_device_probe+0x28d/0x680 [<00000000e0b6db89>] really_probe+0x17c/0x3f0 [<000000001b19fcee>] __driver_probe_device+0xe3/0x170 [<0000000048370519>] driver_probe_device+0x49/0x120 [<000000005ead07a0>] __device_attach_driver+0xf7/0x150 [<0000000043f452b8>] bus_for_each_drv+0x114/0x180 [<00000000358e5596>] __device_attach+0x1e5/0x2d0 [<0000000043f83c5d>] bus_probe_device+0x126/0x140 [<00000000ee0f3046>] device_add+0x810/0x1130 [<00000000e0278184>] i2c_new_client_device+0x359/0x4f0 [<0000000070baf34f>] of_i2c_register_device+0xf1/0x110 [<00000000a9f2159d>] of_i2c_notify+0x100/0x160 unreferenced object 0xffff888119825c00 (size 256): comm "python3", pid 279, jiffies 4294805921 (age 20.681s) hex dump (first 32 bytes): 00 b4 a5 17 81 88 ff ff 00 5e 82 19 81 88 ff ff .........^...... 10 5c 82 19 81 88 ff ff 10 5c 82 19 81 88 ff ff .\.......\...... backtrace: [<000000009990b438>] __kmalloc_node+0x44/0x1b0 [<000000009e32f7d7>] kvmalloc_node+0x34/0x180 [<0000000073d88e0b>] v4l2_ctrl_new.cold+0x19b/0x86f [videodev] [<00000000b1f576fb>] v4l2_ctrl_new_std+0x16f/0x210 [videodev] [<00000000caf7ac99>] ov772x_probe+0x1fa/0x68c [ov772x] [<000000003f0d225e>] i2c_device_probe+0x28d/0x680 [<00000000e0b6db89>] really_probe+0x17c/0x3f0 [<000000001b19fcee>] __driver_probe_device+0xe3/0x170 [<0000000048370519>] driver_probe_device+0x49/0x120 [<000000005ead07a0>] __device_attach_driver+0xf7/0x150 [<0000000043f452b8>] bus_for_each_drv+0x114/0x180 [<00000000358e5596>] __device_attach+0x1e5/0x2d0 [<0000000043f83c5d>] bus_probe_device+0x126/0x140 [<00000000ee0f3046>] device_add+0x810/0x1130 [<00000000e0278184>] i2c_new_client_device+0x359/0x4f0 [<0000000070baf34f>] of_i2c_register_device+0xf1/0x110 The reason is that if priv->hdl.error is set, ov772x_probe() jumps to the error_mutex_destroy without doing v4l2_ctrl_handler_free(), and all resources allocated in v4l2_ctrl_handler_init() and v4l2_ctrl_new_std() are leaked. Fixes: 1112babde2 ("media: i2c: Copy ov772x soc_camera sensor driver") Signed-off-by: Yuan Can <yuancan@huawei.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-03-10 09:33:42 +01:00
..
cec	media fixes for v6.1-rc2	2022-10-22 15:30:15 -07:00
common	media: videobuf2-core: take mmap_lock in vb2_get_unmapped_area()	2022-12-07 11:25:40 -08:00
dvb-core	media: dvb-core: Fix UAF due to refcount races at releasing	2023-01-07 11:11:49 +01:00
dvb-frontends	media: stv0288: use explicitly signed char	2023-01-07 11:11:36 +01:00
firewire	media: Makefiles: remove extra spaces	2022-03-12 16:59:52 +01:00
i2c	media: i2c: ov772x: Fix memleak in ov772x_probe()	2023-03-10 09:33:42 +01:00
mc	media: mc: Get media_device directly from pad	2023-03-10 09:33:42 +01:00
mmc	media: media/*/Kconfig: sort entries	2022-03-18 05:58:35 +01:00
pci	media: saa7164: fix missing pci_disable_device()	2022-12-31 13:32:22 +01:00
platform	media: platform: ti: Add missing check for devm_regulator_get	2023-03-10 09:33:41 +01:00
radio	media: si470x: Fix use-after-free in si470x_int_in_callback()	2022-12-31 13:33:04 +01:00
rc	media: imon: fix a race condition in send_packet()	2022-12-31 13:32:16 +01:00
spi	media updates for v5.18-rc1	2022-03-23 14:51:35 -07:00
test-drivers	media: vimc: Fix wrong function called when vimc_init() fails	2022-12-31 13:32:16 +01:00
tuners	media fixes for v6.1-rc2	2022-10-22 15:30:15 -07:00
usb	media: uvcvideo: Refactor power_line_frequency_controls_limited	2023-03-10 09:33:30 +01:00
v4l2-core	media: v4l2-ctrls-api.c: move ctrl->is_new = 1 to the correct line	2023-02-09 11:28:01 +01:00
Kconfig	media: remove reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER	2022-09-08 18:19:29 +02:00
Makefile	media: Makefiles: remove extra spaces	2022-03-12 16:59:52 +01:00