Bartosz Golaszewski 86fdf151b9 gpiolib: protect the GPIO device against being dropped while in use by user-space
[ Upstream commit bdbbae241a04f387ba910b8609f95fad5f1470c7 ]

While any of the GPIO cdev syscalls is in progress, the kernel can call
gpiochip_remove() (for instance, when a USB GPIO expander is disconnected)
which will set gdev->chip to NULL after which any subsequent access will
cause a crash.

To avoid that: use an RW-semaphore in which the syscalls take it for
reading (so that we don't needlessly prohibit the user-space from calling
syscalls simultaneously) while gpiochip_remove() takes it for writing so
that it can only happen once all syscalls return.

Fixes: d7c51b47ac11 ("gpio: userspace ABI for reading/writing GPIO lines")
Fixes: 3c0d9c635ae2 ("gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL")
Fixes: aad955842d1c ("gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL")
Fixes: a54756cb24ea ("gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL")
Fixes: 7b8e00d98168 ("gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
[Nick: fixed a build failure with CDEV_V1 disabled]
Co-authored-by: Nick Hainke <vincent@systemli.org>
Reviewed-by: Kent Gibson <warthog618@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-12-31 13:32:42 +01:00
..
2022-10-08 09:46:29 -07:00
2022-10-08 09:46:29 -07:00
2022-10-08 09:46:29 -07:00
2022-01-11 12:31:35 -08:00
2021-04-14 10:19:22 +01:00
2022-08-04 18:34:05 -07:00
2021-05-05 16:07:41 +02:00
2022-10-08 09:46:29 -07:00
2022-06-23 23:18:13 +02:00
2022-10-08 09:46:29 -07:00
2022-06-21 18:01:11 +03:00
2019-11-07 09:27:48 +01:00
2022-06-06 14:09:16 +03:00
2022-04-01 10:26:09 -07:00
2021-11-08 11:55:21 -08:00
2022-01-14 18:50:52 -05:00
2022-10-08 09:46:29 -07:00
2022-08-04 18:34:05 -07:00
2019-12-09 10:40:18 +01:00
2022-10-10 13:28:06 -07:00
2022-10-11 10:53:25 -07:00
2022-10-11 10:53:25 -07:00