Lennart Sorensen 6f979eb3fc drivers: net: cpsw: Fix broken loop condition in switch mode
0d961b3b52f566f823070ce2366511a7f64b928c (drivers: net: cpsw: fix buggy
loop condition) accidentally fixed a loop comparison in too many places
while fixing a real bug.

It was correct to fix the dual_emac mode section since there 'i' is used
as an index into priv->slaves which is a 0 based array.

However the other two changes (which are only used in switch mode)
are wrong since there 'i' is actually the ALE port number, and port 0
is the host port, while port 1 and up are the slave ports.

Putting the loop condition back in the switch mode section fixes it.

A comment has been added to point out the intent clearly to avoid future
confusion.  Also a comment is fixed that said the opposite of what was
actually happening.

Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
Acked-by: Heiko Schocher <hs@denx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-10-31 16:17:56 -04:00
..
2014-10-11 11:34:07 -07:00
2014-10-15 07:23:49 +02:00
2014-10-08 17:37:16 -04:00
2014-10-10 22:07:55 -04:00
2014-10-15 07:23:49 +02:00
2014-10-10 16:40:14 -04:00
2014-10-07 21:29:18 -04:00
2014-10-15 06:58:16 +02:00
2014-10-11 06:47:50 -04:00
2014-10-11 20:29:01 -04:00
2014-10-08 17:37:16 -04:00
2014-10-15 07:23:49 +02:00
2014-10-10 16:40:14 -04:00
2014-10-11 20:29:01 -04:00