Quentin Perret 6d2f8909a5
sched: Fix out-of-bound access in uclamp ...
Util-clamp places tasks in different buckets based on their clamp values
for performance reasons. However, the size of buckets is currently
computed using a rounding division, which can lead to an off-by-one
error in some configurations.
For instance, with 20 buckets, the bucket size will be 1024/20=51. A
task with a clamp of 1024 will be mapped to bucket id 1024/51=20. Sadly,
correct indexes are in range [0,19], hence leading to an out of bound
memory access.
Clamp the bucket id to fix the issue.
Fixes: 69842cba9ace ("sched/uclamp: Add CPU's clamp buckets refcounting")
Suggested-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lkml.kernel.org/r/20210430151412.160913-1-qperret@google.com
2021-05-06 15:33:26 +02:00
2021-04-27 13:42:11 -07:00
2021-04-16 16:49:37 -04:00
2021-01-06 17:39:38 +01:00
2021-04-27 18:09:44 -07:00
2021-02-26 13:59:32 -08:00
2021-04-26 09:41:15 -07:00
2021-04-19 20:03:29 +02:00
2021-04-19 15:08:49 -07:00
2021-04-26 09:43:16 -07:00
2021-04-22 14:36:03 +02:00
2021-04-27 18:14:38 -07:00
2021-04-28 12:37:53 -07:00
2021-04-08 19:37:21 +02:00
2021-03-30 15:34:17 +02:00
2021-03-24 17:20:18 -07:00
2021-05-06 15:33:26 +02:00
2021-04-26 15:10:25 -07:00
2021-04-26 09:43:16 -07:00
2020-12-15 22:46:15 -08:00
2020-07-16 12:35:15 -07:00
2021-02-23 10:25:27 -05:00
2020-12-03 14:58:35 +01:00
2020-12-03 14:58:35 +01:00
2021-03-22 15:23:32 -04:00
2021-03-24 12:11:48 -04:00
2021-03-22 15:23:32 -04:00
2021-04-27 13:50:58 -07:00
2020-07-30 11:15:58 -07:00
2021-01-24 14:27:16 +01:00
2021-04-08 16:04:20 -07:00
2020-08-23 17:36:59 -05:00
2020-06-11 15:14:36 +02:00
2020-09-01 09:58:03 +02:00
2021-04-21 13:55:43 +02:00
2020-12-15 22:46:18 -08:00
2020-05-20 14:44:21 -05:00
2021-04-14 18:04:08 +02:00
2020-12-15 22:46:19 -08:00
2021-04-28 14:56:09 -07:00
2021-03-27 14:09:10 -06:00
2021-03-29 15:56:48 +02:00
2020-06-06 23:42:01 +09:00
2021-02-26 09:41:03 -08:00
2020-11-02 12:14:19 -08:00
2020-11-24 16:47:49 +01:00
2021-03-19 13:16:44 +01:00
2021-04-08 16:04:21 -07:00
2020-12-15 19:36:48 -08:00
2021-02-17 14:12:24 +01:00
2020-11-02 18:00:20 -08:00
2021-02-21 09:29:23 -08:00
2021-02-10 15:49:38 -05:00
2021-02-22 12:33:26 +00:00
2020-10-05 13:37:03 +02:00
2020-08-12 10:58:01 -07:00
2021-02-19 14:57:12 -05:00
2021-04-28 13:33:57 -07:00
2021-04-08 16:04:20 -07:00
2021-01-19 10:24:45 +01:00
2021-01-19 10:24:45 +01:00
2021-04-08 16:04:20 -07:00
2020-09-01 09:58:03 +02:00
2020-12-14 16:40:27 -08:00
2020-09-04 17:51:55 +10:00
2020-11-14 11:26:04 -08:00
2020-12-17 13:01:31 -08:00
2020-12-14 16:40:27 -08:00
2020-12-15 19:36:48 -08:00
2021-04-10 13:35:54 +02:00
2021-04-20 10:13:58 +02:00
2020-10-16 11:11:19 -07:00
2021-03-18 16:58:02 +01:00
2020-07-27 14:31:12 -04:00
2020-12-15 22:46:18 -08:00
2020-11-25 18:52:35 +01:00
2021-01-12 14:26:31 +01:00
2021-04-14 18:04:09 +02:00
2021-01-04 13:53:41 -08:00
2020-12-01 10:30:28 +00:00
2021-03-30 22:34:30 -07:00
2021-04-28 13:33:57 -07:00
2021-03-06 13:00:58 +01:00
2021-01-22 15:09:42 +01:00
2021-04-28 12:00:13 -07:00
2020-09-19 13:13:39 -07:00
2020-09-18 14:24:16 +01:00
2021-04-09 13:22:12 +02:00
2021-03-23 16:01:58 +01:00
2021-03-17 15:51:17 +01:00
2021-04-13 17:31:44 +01:00
2021-04-29 11:06:13 -07:00
2021-04-11 19:30:25 -06:00
2020-11-16 08:08:54 -08:00
2021-03-08 14:22:28 -08:00
2021-02-09 12:27:29 -05:00
2021-03-16 16:49:31 +01:00
2020-10-06 10:31:52 -07:00
2021-03-06 12:59:10 +01:00
2021-04-20 14:28:33 -07:00
2020-08-19 14:14:12 +02:00
2021-03-19 22:23:19 +01:00
2020-08-19 14:13:20 +02:00
2021-01-26 11:16:34 +00:00
2021-04-04 13:26:49 -04:00
2021-04-27 10:16:46 -07:00
6d2f8909a5