Michael Halcrow 6c6f57f3be eCryptfs: comments for some structs ... Andrew Morton wrote: > > +struct ecryptfs_global_auth_tok { > > +#define ECRYPTFS_AUTH_TOK_INVALID 0x00000001 > > + u32 flags; > > + struct list_head mount_crypt_stat_list; > > + struct key *global_auth_tok_key; > > + struct ecryptfs_auth_tok *global_auth_tok; > > + unsigned char sig[ECRYPTFS_SIG_SIZE_HEX + 1]; > > +}; > > + > > +struct ecryptfs_key_tfm { > > + struct crypto_blkcipher *key_tfm; > > + size_t key_size; > > + struct mutex key_tfm_mutex; > > + struct list_head key_tfm_list; > > + unsigned char cipher_name[ECRYPTFS_MAX_CIPHER_NAME_SIZE + 1]; > > +}; > > Please consider commenting your struct fields carefully: it's a > great way to help other to understand your code. Add some comments to the ecryptfs_global_auth_tok and ecryptfs_key_tfm structs to make their functions more easily ascertained. Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2007-10-16 09:43:11 -07:00
..
crypto.c	eCryptfs: grammatical fix (destruct to destroy)	2007-10-16 09:43:11 -07:00
debug.c	eCryptfs: update comment and debug statement	2007-10-16 09:43:11 -07:00
dentry.c	[PATCH] eCryptfs: fix possible NULL ptr deref in ecryptfs_d_release()	2007-03-16 19:25:05 -07:00
ecryptfs_kernel.h	eCryptfs: comments for some structs	2007-10-16 09:43:11 -07:00
file.c	sendfile: remove .sendfile from filesystems that use generic_file_sendfile()	2007-07-10 08:04:13 +02:00
inode.c	revert "eCryptfs: fix lookup error for special files"	2007-08-31 01:42:22 -07:00
keystore.c	ecryptfs: printk warning fixes	2007-10-16 09:43:11 -07:00
main.c	eCryptfs: grammatical fix (destruct to destroy)	2007-10-16 09:43:11 -07:00
Makefile	[PATCH] eCryptfs: Public key; packet management	2007-02-12 09:48:36 -08:00
messaging.c	Detach sched.h from mm.h	2007-05-21 09:18:19 -07:00
mmap.c	fs: remove some AOP_TRUNCATED_PAGE	2007-10-16 09:42:58 -07:00
netlink.c	[NET]: make netlink user -> kernel interface synchronious	2007-10-10 21:15:29 -07:00
super.c	eCryptfs: grammatical fix (destruct to destroy)	2007-10-16 09:43:11 -07:00