Stanislaw Gruszka 673e63c688 net: fix ethtool->set_flags not intended -EINVAL return value
After commit d5dbda23804156ae6f35025ade5307a49d1db6d7 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-03-27 23:35:24 -07:00
..
2011-03-27 23:34:59 -07:00
2011-03-04 12:24:31 -08:00
2010-08-12 06:38:24 +10:00
2011-01-20 18:30:17 -08:00
2010-10-15 21:18:59 +02:00
2011-01-20 18:30:17 -08:00
2010-11-23 20:14:46 +00:00
2010-05-27 09:12:53 -07:00
2011-01-31 14:03:00 -08:00
2011-01-15 20:07:45 -05:00
2011-01-13 08:03:12 -08:00
2010-11-10 14:54:09 +01:00
2010-11-10 14:54:09 +01:00
2010-12-13 16:11:13 -08:00
2010-06-24 21:30:09 -07:00
2010-10-25 21:18:20 -04:00
2010-11-29 08:35:12 +11:00
2010-12-16 17:53:38 +01:00
2011-02-16 13:30:48 +01:00
2011-02-16 13:30:48 +01:00
2010-10-25 08:02:40 -07:00
2010-08-19 17:18:00 -07:00
2011-01-10 08:51:44 -08:00
2010-08-04 11:00:45 +02:00
2010-10-22 15:55:22 +02:00
2011-02-03 15:39:16 -08:00
2010-10-21 14:47:59 +02:00
2011-01-12 20:16:43 -05:00
2011-03-14 19:12:20 -04:00
2010-08-19 17:18:03 -07:00
2010-12-08 10:30:34 -08:00
2011-01-10 08:51:44 -08:00
2011-01-07 17:50:27 +11:00
2011-03-17 21:31:32 -04:00
2011-01-07 17:50:23 +11:00
2010-12-07 20:16:56 +01:00
2011-03-04 17:53:39 -08:00
2010-10-25 14:11:37 -07:00
2011-03-05 10:56:00 +01:00
2010-10-12 16:53:37 +02:00
2010-08-11 09:23:22 +02:00
2010-11-15 22:40:38 +01:00
2011-02-23 00:53:26 +00:00
2010-06-16 18:08:13 +02:00
2010-06-03 03:21:52 -07:00
2010-11-16 10:58:30 -08:00
2010-09-21 18:04:47 -07:00
2011-02-27 16:11:51 -08:00
2010-08-19 17:16:23 -07:00
2010-10-26 16:52:08 -07:00
2010-08-09 20:45:05 -07:00
2010-11-24 11:16:42 -08:00
2011-03-11 14:15:35 +01:00
2010-10-07 14:08:55 +01:00
2010-06-03 03:21:52 -07:00
2010-08-10 11:49:21 -07:00
2010-12-09 20:17:07 -08:00
2010-08-12 11:27:58 +02:00
2011-01-31 14:03:00 -08:00
2011-02-17 11:12:40 -08:00
2010-10-22 15:34:12 -05:00
2011-01-13 17:32:31 -08:00
2011-02-01 08:23:22 +10:00
2011-01-13 17:32:47 -08:00
2011-02-13 16:54:24 -08:00
2011-01-24 14:45:11 +10:30
2010-09-09 18:57:24 -07:00
2010-11-12 07:55:32 -08:00
2011-01-14 13:12:45 +00:00
2010-06-16 18:03:15 +02:00
2011-03-16 09:58:31 -07:00
2010-12-06 11:03:46 -08:00
2010-06-03 03:21:52 -07:00
2011-01-13 17:32:41 -08:00
2011-01-13 17:32:46 -08:00
2011-02-15 10:24:31 +01:00
2011-01-16 13:47:07 -05:00
2010-10-12 16:53:34 +02:00
2011-03-11 15:38:44 -05:00
2011-03-14 18:25:53 -04:00
2010-08-19 17:18:02 -07:00
2010-07-05 16:14:52 -06:00
2011-01-13 17:32:43 -08:00
2011-01-16 13:47:07 -05:00
2010-10-24 15:07:11 -07:00
2010-08-21 23:40:14 -07:00
2011-03-11 15:13:26 -05:00
2011-03-15 00:43:16 +01:00
2010-07-19 01:58:48 +02:00
2010-12-10 15:06:43 +01:00
2010-08-04 21:53:17 -07:00
2011-01-13 08:03:21 -08:00
2010-10-29 04:16:31 -04:00
2011-01-14 02:36:43 +00:00
2010-09-08 18:16:55 -07:00
2010-08-09 16:47:27 -04:00
2010-11-15 13:24:06 -05:00
2011-01-13 08:03:18 -08:00
2011-01-13 17:32:42 -08:00
2010-06-03 03:21:52 -07:00
2010-10-30 12:12:50 +02:00
2011-01-07 17:50:27 +11:00
2011-01-13 08:03:19 -08:00
2010-10-27 17:28:36 +01:00
2010-10-07 14:08:55 +01:00
2010-08-09 16:48:44 -04:00
2011-01-13 17:32:42 -08:00
2010-08-30 13:23:33 -07:00
2011-02-28 18:00:31 -08:00
2011-02-21 12:53:08 -08:00
2011-02-02 15:28:18 +01:00
2010-09-09 20:41:20 +02:00
2010-11-29 08:55:25 +11:00
2010-11-29 08:55:22 +11:00
2010-10-26 16:52:03 -07:00
2010-12-20 09:37:33 +01:00
2011-01-24 14:45:11 +10:30
2010-11-15 13:25:02 -05:00
2011-01-13 08:03:24 -08:00